From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.devel Subject: Re: Upcoming seq.el version problem with the Emacs release Date: Sun, 20 Mar 2016 11:15:27 +0100 Message-ID: <87vb4h316o.fsf@petton.fr> References: <87vb5osrv0.fsf@petton.fr> <877fhz8cb5.fsf@petton.fr> <87lh5jxvm0.fsf@petton.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1458468959 21729 80.91.229.3 (20 Mar 2016 10:15:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Mar 2016 10:15:59 +0000 (UTC) Cc: John Wiegley , Artur Malabarba , emacs-devel To: Bozhidar Batsov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 20 11:15:49 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ahaOh-0005Gs-I8 for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2016 11:15:47 +0100 Original-Received: from localhost ([::1]:52223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahaOb-0007rv-Um for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2016 06:15:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahaOV-0007ny-77 for emacs-devel@gnu.org; Sun, 20 Mar 2016 06:15:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahaOR-0003aL-Sm for emacs-devel@gnu.org; Sun, 20 Mar 2016 06:15:35 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahaOR-0003a8-Kw for emacs-devel@gnu.org; Sun, 20 Mar 2016 06:15:31 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 285D12052A for ; Sun, 20 Mar 2016 06:15:30 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute3.internal (MEProxy); Sun, 20 Mar 2016 06:15:30 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=vZDkNtS4YiHVYQf4LhVwyGrctnY=; b=aso5s Zi1eWguD+hdSw/qcEsJu4Utm+8S9s1EjJetfXd0SdpXrYUchug0mFZzFVT0VtT3n IkJRgntc3ZoI0BxiV00bna5kxW34qcLLwkHPzh+aGbq6qDBij6t9mi67iz10580V 5J9rF0P0D2oPzI++tiNWVD+uvYppIzzk0kfrkQ= X-Sasl-enc: Pc9elI7jYN3+dJZF7aXopLBMoCxTFHOiBzDh4FccdpLr 1458468929 Original-Received: from blueberry (lfbn-1-7726-61.w92-167.abo.wanadoo.fr [92.167.139.61]) by mail.messagingengine.com (Postfix) with ESMTPA id 45E846800B5; Sun, 20 Mar 2016 06:15:29 -0400 (EDT) In-Reply-To: User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201919 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Bozhidar Batsov writes: > I might be missing something here, but what exactly is so problematic - > there are packages that are in Emacs and on ELPA (e.g. cl-lib) and I don't > think they are taking any special measures. The problem is that seq.el (in Emacs) uses `pcase-defmacro', which does not exist in Emacs 24.5. When byte-compiling the file, we get warnings as the byte compiler will think that `pcase-defmacro' is a function. The solution I'm going for is to define locally the macro (when byte-compiling the file in Emacs < 25), using something like the following: (push `(pcase-defmacro . ,(lambda (&rest _) nil)) byte-compile-macro-environment) You can read more about the issue here: https://github.com/NicolasPetton/seq.el/issues/7 Nico =2D-=20 Nicolas Petton http://nicolas-petton.fr --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: GPGTools - http://gpgtools.org iQEcBAEBCAAGBQJW7ng/AAoJECM1h6R8IHkQrhsIAKfliVnJvv5y/zn0QZ7QDfFk 0n1Z0aiMs/3Jgq6XFkseDdKlOVz0zKf3otU2D7A0wDKE43Ugx8xHo+fju9uamJcB Muk8txqk4tXwLUpCoWTQV3SNymtr3O/KxvJfBI88nKcRm1KQYjd+N4m+88FbGbkE d/rpbwOXcHYsmUNRcFf5Msxfziw8nackI9mwyyHsD3wI+jR5SRECekB+VrkgA3Dc Bzdo6MshBLpw2RQWYo1nQTLjqMnJ1fCTC8Qean16w3Ix1cT8DW4Q8aCm1yqYdhiE Kq8Q1Emc65a8v+Ixm7I/vOZ0qfwL+DDsCQ1k2drypwkyJLzm99cdeRALZ7GBwwY= =riO5 -----END PGP SIGNATURE----- --=-=-=--