From: Nicolas Petton <nicolas@petton.fr>
To: Bozhidar Batsov <bozhidar@batsov.com>
Cc: John Wiegley <johnw@gnu.org>,
Artur Malabarba <bruce.connor.am@gmail.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Upcoming seq.el version problem with the Emacs release
Date: Sun, 20 Mar 2016 11:15:27 +0100 [thread overview]
Message-ID: <87vb4h316o.fsf@petton.fr> (raw)
In-Reply-To: <CAM9Zgm0_8Z7pvMvhgWPkhFEXYKmAM0w9iwA+1CuSQ-du3FQbgQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
Bozhidar Batsov <bozhidar@batsov.com> writes:
> I might be missing something here, but what exactly is so problematic -
> there are packages that are in Emacs and on ELPA (e.g. cl-lib) and I don't
> think they are taking any special measures.
The problem is that seq.el (in Emacs) uses `pcase-defmacro', which does
not exist in Emacs 24.5. When byte-compiling the file, we get warnings
as the byte compiler will think that `pcase-defmacro' is a function.
The solution I'm going for is to define locally the macro (when
byte-compiling the file in Emacs < 25), using something like the
following:
(push `(pcase-defmacro . ,(lambda (&rest _) nil))
byte-compile-macro-environment)
You can read more about the issue here:
https://github.com/NicolasPetton/seq.el/issues/7
Nico
--
Nicolas Petton
http://nicolas-petton.fr
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2016-03-20 10:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 13:32 Upcoming seq.el version problem with the Emacs release Nicolas Petton
2016-02-20 6:24 ` John Wiegley
2016-02-20 18:30 ` Nicolas Petton
2016-03-15 21:46 ` Nicolas Petton
2016-03-19 17:44 ` Bozhidar Batsov
2016-03-20 10:15 ` Nicolas Petton [this message]
2016-03-20 14:20 ` Bozhidar Batsov
2016-03-20 20:35 ` Michael Heerdegen
2016-03-21 8:39 ` Nicolas Petton
2016-03-21 13:33 ` Stefan Monnier
2016-03-21 13:45 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb4h316o.fsf@petton.fr \
--to=nicolas@petton.fr \
--cc=bozhidar@batsov.com \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=johnw@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.