From: Matthew Leach <matthew@mattleach.net>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH 3/5] Permit systemd-allocated socket file-descriptors to be used.
Date: Sun, 27 Mar 2016 13:23:52 +0100 [thread overview]
Message-ID: <87vb48w1lz.fsf@mattleach.net> (raw)
In-Reply-To: <m3d1qgm8br.fsf@gnus.org> (Lars Magne Ingebrigtsen's message of "Sun, 27 Mar 2016 14:08:56 +0200")
Hi Lars,
Thanks for the review.
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
[...]
>> +:systemd-fd INT -- use this file-descriptor, passed in through systemd,
>> + and don't call socket() and bind().
>
> There isn't really anything systemd-specific about any of this code (as
> far as I can see): It's about calling `make-network-socket' on a file
> descriptor that's already been opened. So I'd just rename this
> parameter to :allocated-file-descriptor or something and adjust the
> names of the other variables used.
Initially I had the same thought and gave this variable a generic name
as you propose. However, it turns out that systemd has already called
bind() on the socket and a further call to bind() would error. At this
point I thought this interface was too systemd-specific to allow
non-systemd allocated file-descriptors to be passed in.
I could always go back to a generic interface, but stipulate that bind()
must have already been called on the socket?
Thanks,
--
Matt
next prev parent reply other threads:[~2016-03-27 12:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 21:16 [PATCH 0/5] Add systemd socket launching support Matthew Leach
2016-03-26 21:16 ` [PATCH 1/5] Check for libsystemd when building Emacs Matthew Leach
2016-03-26 21:16 ` [PATCH 2/5] Read the number of sockets passed by systemd Matthew Leach
2016-03-26 21:16 ` [PATCH 3/5] Permit systemd-allocated socket file-descriptors to be used Matthew Leach
2016-03-27 12:08 ` Lars Magne Ingebrigtsen
2016-03-27 12:23 ` Matthew Leach [this message]
2016-03-27 12:42 ` Andreas Schwab
2016-03-27 13:38 ` Matthew Leach
2016-03-27 13:05 ` Lars Magne Ingebrigtsen
2016-03-27 13:39 ` Matthew Leach
2016-03-26 21:16 ` [PATCH 4/5] Allow the systed socket fd to be retrieved Matthew Leach
2016-03-26 21:16 ` [PATCH 5/5] When set, use the systemd socket descriptor Matthew Leach
2016-03-27 0:47 ` [PATCH 0/5] Add systemd socket launching support Alan Mackenzie
2016-03-27 0:59 ` Alexis
2016-03-27 8:44 ` Matthew Leach
2016-03-27 11:15 ` Alexis
2016-03-27 8:41 ` Matthew Leach
2016-03-27 13:48 ` Wolfgang Jenkner
2016-03-27 13:53 ` Matthew Leach
2016-03-27 14:18 ` Wolfgang Jenkner
2016-03-27 15:49 ` Mark Oteiza
2016-03-27 18:16 ` Matthew Leach
2016-03-27 14:49 ` Eli Zaretskii
2016-03-27 15:17 ` Matthew Leach
2016-03-27 15:23 ` Eli Zaretskii
2016-03-27 17:21 ` Philipp Stephani
2016-03-27 18:10 ` Matthew Leach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb48w1lz.fsf@mattleach.net \
--to=matthew@mattleach.net \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.