From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.devel Subject: Re: Embedded modifiers in the regex engine Date: Mon, 28 Mar 2016 11:05:02 -0700 Message-ID: <87vb46zdf5.fsf@secretsauce.net> References: <87ziupinhq.fsf@secretsauce.net> <83oab4g407.fsf@gnu.org> <83mvqnet3t.fsf@gnu.org> <87wpppioxi.fsf@secretsauce.net> <83povgakpy.fsf@gnu.org> <871t6v1mdb.fsf@secretsauce.net> <83oa9yy643.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1459188366 32571 80.91.229.3 (28 Mar 2016 18:06:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Mar 2016 18:06:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 28 20:05:52 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akbXv-0001VQ-Lx for ged-emacs-devel@m.gmane.org; Mon, 28 Mar 2016 20:05:47 +0200 Original-Received: from localhost ([::1]:42098 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akbXu-0001CB-UJ for ged-emacs-devel@m.gmane.org; Mon, 28 Mar 2016 14:05:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akbXT-00018q-CG for emacs-devel@gnu.org; Mon, 28 Mar 2016 14:05:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akbXP-0006Hz-Dx for emacs-devel@gnu.org; Mon, 28 Mar 2016 14:05:19 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:48638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akbXP-0006HT-9R for emacs-devel@gnu.org; Mon, 28 Mar 2016 14:05:15 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C214721F36 for ; Mon, 28 Mar 2016 14:05:13 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 28 Mar 2016 14:05:13 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=2V5+E vX2AqNG9g8bwYdCEhKIfWI=; b=D+BxDUzq41jxwbOa4YbxqRQRAzN1Qe5C/0M4z PWih9GZeixo662zvewQNoKRHPKVBdwtLQrI0rV+W9AfGtX4G3qcqlJPOsZ+tK9a2 uvvC0h0Ynihp4Z7s42VeJy9mT56KuZMZhtsTG01+nxYq3WRLa7x4ji30Jwh7ON2k XKjTMc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=2V5+EvX2AqNG9g8bwYdCEhKIfWI=; b=uTSha 1O/XUM36H6eBIZCED8DhDdRipyxpYnNKFgxhzYU8ktpf9y9vYxwGeH6gzg8KLE6R Lo4Z38kju5clTqiGC4FO7qCTrNnjW+6l4lr2w+B/QDOOxLmHXmxwZ/ShOz413SKu M2QL2EETE0FK1+/Nwqu1F6Z1AMTM1G4t3SPL6o= X-Sasl-enc: /0ctz6TDDV14H6604HL3oD7+AbJmahLKqgjnfLn4QhnJ 1459188313 Original-Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 6F0BDC0001A; Mon, 28 Mar 2016 14:05:13 -0400 (EDT) Original-Received: from ip6-localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1akbXC-0006Z5-Kb; Mon, 28 Mar 2016 11:05:02 -0700 User-agent: mu4e 0.9.11; emacs 25.0.92.1 In-reply-to: <83oa9yy643.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.26 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202330 Archived-At: Eli Zaretskii writes: >> From: Dima Kogan >> Date: Sun, 27 Mar 2016 17:23:28 -0700 >> >> Sorry for the delay. Attached are two patches to import most of glibc's >> regex tests to emacs. Assuming these are acceptable to be merged into >> our tree, what specifically are people thinking in terms of updates to >> the regex engine? Is there a particular implementation that we were >> considering? > > What's wrong with the existing one? Maybe nothing. I'd like to add a feature, but if there are plans to abandon the current implementation, then I want to add my feature to whatever the new implementation is. I've seen earlier posts on the list discussing such changes, and it wasn't clear if anybody had specific plans, or if there was consensus. >> --- /dev/null >> +++ b/test/src/regex/regex-resources/BOOST.tests >> @@ -0,0 +1,829 @@ >> +; >> +; >> +; this file contains a script of tests to run through regress.exe > > What is "regress.exe"? These test definitions came verbatim from the glibc sources. I guess the BOOST.tests comment mentions regress.exe. glibc doesn't have it, and neither do we. > Also, please provide log messages for the changes. What kind of log messages? Git logs? These are terse because this project seems to have strict guidelines, and other messages I see are generally very terse. What would you like?