Re: Embedded modifiers in the regex engine

[Dima Kogan <lists@dima.secretsauce.net>]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Dima Kogan <dima@secretsauce.net>
>> Date: Sun, 27 Mar 2016 17:23:28 -0700
>> 
>> Sorry for the delay. Attached are two patches to import most of glibc's
>> regex tests to emacs. Assuming these are acceptable to be merged into
>> our tree, what specifically are people thinking in terms of updates to
>> the regex engine? Is there a particular implementation that we were
>> considering?
>
> What's wrong with the existing one?

Maybe nothing. I'd like to add a feature, but if there are plans to
abandon the current implementation, then I want to add my feature to
whatever the new implementation is. I've seen earlier posts on the list
discussing such changes, and it wasn't clear if anybody had specific
plans, or if there was consensus.


>> --- /dev/null
>> +++ b/test/src/regex/regex-resources/BOOST.tests
>> @@ -0,0 +1,829 @@
>> +; 
>> +; 
>> +; this file contains a script of tests to run through regress.exe
>
> What is "regress.exe"?

These test definitions came verbatim from the glibc sources. I guess the
BOOST.tests comment mentions regress.exe. glibc doesn't have it, and
neither do we.


> Also, please provide log messages for the changes.

What kind of log messages? Git logs? These are terse because this
project seems to have strict guidelines, and other messages I see are
generally very terse. What would you like?