From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Johan Claesson Newsgroups: gmane.emacs.bugs Subject: bug#23164: 25.1.50; xref-find-definitions with local tags-file-name fails Date: Mon, 04 Apr 2016 23:14:40 +0200 Message-ID: <87vb3xm5z3.fsf@bredband.net> References: <87egar3czt.fsf@bredband.net> <87a497cc-15b1-504b-fd4a-8fb3e484e507@yandex.ru> <87zita16ow.fsf@wanadoo.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1459804525 2667 80.91.229.3 (4 Apr 2016 21:15:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2016 21:15:25 +0000 (UTC) Cc: =?UTF-8?Q?=C3=93scar?= Fuentes , 23164@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 04 23:15:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1anBq3-0004F6-1W for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Apr 2016 23:15:11 +0200 Original-Received: from localhost ([::1]:33025 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anBq2-0003wk-4s for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Apr 2016 17:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anBpx-0003tG-Je for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 17:15:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anBpu-0004b0-DI for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 17:15:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anBpu-0004aw-9w for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 17:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1anBpu-0005WE-2z for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 17:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Johan Claesson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Apr 2016 21:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23164-submit@debbugs.gnu.org id=B23164.145980449121184 (code B ref 23164); Mon, 04 Apr 2016 21:15:02 +0000 Original-Received: (at 23164) by debbugs.gnu.org; 4 Apr 2016 21:14:51 +0000 Original-Received: from localhost ([127.0.0.1]:51458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anBpi-0005Vc-Rb for submit@debbugs.gnu.org; Mon, 04 Apr 2016 17:14:51 -0400 Original-Received: from smtprelay-h31.telenor.se ([213.150.131.4]:52410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anBpg-0005VL-KV for 23164@debbugs.gnu.org; Mon, 04 Apr 2016 17:14:49 -0400 Original-Received: from ipb2.telenor.se (ipb2.telenor.se [195.54.127.165]) by smtprelay-h31.telenor.se (Postfix) with ESMTP id A66BFD7EB for <23164@debbugs.gnu.org>; Mon, 4 Apr 2016 23:14:42 +0200 (CEST) X-SENDER-IP: [213.114.153.250] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AgCQA42AJXPPqZctVdHAGDGoFQhmq0S4Fyhg0CgTo6EwEBAQEBAQEGAQEBAUJAhEIBAQMBIzMjBQsIAw4MAgUhAgIPAQQZDAoaE4gSAwoMAa0YjE4hhG4BAQEBBgIBHRljhSSESoQ9gwKCVgWNTYo0nRePGiEBhCk6MIgmAQEB X-IPAS-Result: A2AgCQA42AJXPPqZctVdHAGDGoFQhmq0S4Fyhg0CgTo6EwEBAQEBAQEGAQEBAUJAhEIBAQMBIzMjBQsIAw4MAgUhAgIPAQQZDAoaE4gSAwoMAa0YjE4hhG4BAQEBBgIBHRljhSSESoQ9gwKCVgWNTYo0nRePGiEBhCk6MIgmAQEB X-IronPort-AV: E=Sophos;i="5.24,442,1454972400"; d="scan'208";a="526124610" Original-Received: from c-fa9972d5.04-99-73746f3.cust.bredbandsbolaget.se (HELO goblin) ([213.114.153.250]) by ipb2.telenor.se with ESMTP; 04 Apr 2016 23:14:42 +0200 In-Reply-To: <87zita16ow.fsf@wanadoo.es> ("=?UTF-8?Q?=C3=93scar?= Fuentes"'s message of "Mon, 04 Apr 2016 03:52:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:116040 Archived-At: Hi again, I tried again this time with the TAGS of Emacs itself (emacs/src/TAGS). And like you have already established the problem does not occur in this scenario. It does occur with other valid TAGS files, though.=20=20 After a little bit of tracing i think the difference that matters is that emacs/src/TAGS includes two other TAGS file in the very last lines: ../lisp/TAGS,include ../lwlib/TAGS,include I was not aware of this feature with TAGS files including other TAGS files before but after invoking xref-find-definitions emacs is visiting all 3 TAGS files (src/TAGS, lisp/TAGS and lwlib/TAGS). And xref-find-definitions loops through them all. If these last lines in emacs/src/TAGS are deleted the problem occurs. It also occur with other simple TAGS files that do not include other TAGS files. And the TAGS file i was using when observing the problem the first time was this kind of simple TAGS file. Same in master and emacs-25. Regards, /Johan =C3=93scar Fuentes writes: > Dmitry Gutov writes: > >> Thanks for the report, but that doesn't seem to be the case here. At >> least if I replace "/dev/zero" with "~/vc/emacs/src/TAGS", the >> scenario doesn't lead to an error (I just get "not found"), and if I >> also use e.g. "CALLN" instead of "foo", the jump to the destination >> occurs as expected. > > I can reproduce it here with an existing TAGS file, on emacs -Q. > > GNU Emacs 25.0.92.3 (x86_64-unknown-linux-gnu, X toolkit) of 2016-04-03 > > at commit fc3cd53900eb5e80b91b6d2615b3800fd2f59c16 > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > expand-file-name(nil) > tags-expand-table-name(nil) > visit-tags-table-buffer(t) > etags--xref-find-definitions("foo") > #[514 "\300!\207" [etags--xref-find-definitions] 4 "\n\n(fn BACKEND SYM= BOL)"](etags "foo") > apply(#[514 "\300!\207" [etags--xref-find-definitions] 4 "\n\n(fn BACKE= ND SYMBOL)"] etags "foo") > xref-backend-definitions(etags "foo") > xref--find-xrefs("foo" definitions "foo" nil) > xref--find-definitions("foo" nil) > xref-find-definitions("foo") > eval((xref-find-definitions "foo") nil) > elisp--eval-last-sexp(nil) > eval-last-sexp(nil) > funcall-interactively(eval-last-sexp nil) > call-interactively(eval-last-sexp nil nil) > command-execute(eval-last-sexp)