From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#23276: 25.0.92; Crash in auto-revert when file no longer present Date: Sat, 16 Apr 2016 20:44:18 +0200 Message-ID: <87vb3hgzr1.fsf@gmx.de> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1460832322 30317 80.91.229.3 (16 Apr 2016 18:45:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Apr 2016 18:45:22 +0000 (UTC) Cc: 23276@debbugs.gnu.org To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 16 20:45:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1arVDT-0007XA-9G for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Apr 2016 20:45:11 +0200 Original-Received: from localhost ([::1]:59934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arVDS-0004q0-MD for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Apr 2016 14:45:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arVDP-0004ng-7y for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 14:45:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arVDK-0001zY-7A for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 14:45:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arVDK-0001zS-3r for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 14:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1arVDJ-0002tA-VL for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 14:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Apr 2016 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23276 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23276-submit@debbugs.gnu.org id=B23276.146083226811041 (code B ref 23276); Sat, 16 Apr 2016 18:45:01 +0000 Original-Received: (at 23276) by debbugs.gnu.org; 16 Apr 2016 18:44:28 +0000 Original-Received: from localhost ([127.0.0.1]:37618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arVCl-0002s1-QJ for submit@debbugs.gnu.org; Sat, 16 Apr 2016 14:44:27 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:64403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arVCk-0002rl-8C for 23276@debbugs.gnu.org; Sat, 16 Apr 2016 14:44:26 -0400 Original-Received: from detlef.gmx.de ([93.209.82.129]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0Mgt3g-1b4mtn1tZ2-00M4Dp; Sat, 16 Apr 2016 20:44:19 +0200 In-Reply-To: (Anders Lindgren's message of "Tue, 12 Apr 2016 13:07:48 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) X-Provags-ID: V03:K0:WbXVL/BgX1IWdx7hYrcpRVgIpvJCCsWwwe9oas8JTtVl6VEZbQV vj5K+WInVBFQX7qRAY2PONU91vfnTnAp3k0VGJXwAhdldUOHq0uw/TpLq25UbwpoBBQ6d+o 1gXAuL6ehYtJDKu6ymdzKJqfDm5Q71Rqmoqqt53ZPsq7aOcQLnVZNUY5uhJjTovQxgPsK38 rmgItrEatgiWp/yqnxyvQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:7ITaygbA+jU=:FvFBX20WTNVQ/ni8UZO/Ap /eprs0/4hamotCGQL0IxH8KFPx+oxKbAnxeAv/C0wI81lvk8jCRI5AsnK5Tv0gV5JdePuZoeq HWi5UHVl0bTFE2AQgzMa+5SiVZh6rRPQWsKySf4JbXzS2ZaaQHdKTeIZOPiCG0OC1115LUKSF 8SVmGRb2HjfgAd0PtlaieLK3aOgIgT+Z9FtD3eb5cEvkKq9+q5MGMYHJRrLJV2guYvaRRxFn0 eEAC9lylUzYyDngqyy9y42ykovE54wovrPrOCqr6669FtKgpnpnVaphiDnt/74RMeiOaXppa3 bqUF4YWi7DugjQdj5dUcF40x199sFM0WRNk0oRMPwUEK/ZlUYXsO1mxtBd/MQrdUm4KUvqeNg kSQW5XbMXfZY5k3VRqEVG++3Im/N62+Mxbp1qp7nosGKnB13bcfSAnyX8y8y3Y1P7pqWItmtA YmvxA5I4lhYyihglAYY22/OEsv/kcVO3OB51mh669JBU2htdFBpaFLE6/xRCbfWP0lWsln6Wl PlX+LnzfadkIxqBr3/318LZw1qREmdABoHoNDzFqBTdrEmsi9jx+J9UTyMhCHBdGxlyD3pAod EumFC/Cz2pK/X8iPIYfuaLqn0xQy2phHHqEjhfmaWDs90dknvxpGJFAx8FetD4wQGhm2nfIr8 qp7yU/vhsRxjC2jHxGOA0+ziAuIO1VhUdYgE0hP1WHh3VBqt6mjOajpQ1R5mye9Ue6Vt4STS7 fHEr8AK04h2Api19SQVUTqinOA/43+K0YUBn8h3MV7WCndC3qOLjbY/u5i+bcZSGbBMWKj9r X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116536 Archived-At: Anders Lindgren writes: > Hi! Hi, > I just had auto-revert crash on me... (Emacs 25.0.92 on Windows. > `debug-on-error' is t.) > > I had a file open in Emacs that was rewritten over and over again by > an external process. My guess is that Emacs decides that it should be > reverted, but when it actually reads the file, it is no longer > present. I've tried to write a test case for this, but I've failed. Do you have a recipe to provoke this error? > I would suggest that auto-revert silently ignores this error. Yep. Does anybody object to install the following patch in the emacs-25 branch? --8<---------------cut here---------------start------------->8--- *** /home/albinus/src/emacs-25/lisp/autorevert.el.~f3653ec446ed95404889cf16c67b2d96b3955f52~ 2016-04-16 20:38:55.247491182 +0200 --- /home/albinus/src/emacs-25/lisp/autorevert.el 2016-04-16 20:36:29.485457375 +0200 *************** *** 684,690 **** ;; not to forget that. This gives undesirable results when ;; the file's mode changes, but that is less common. (let ((buffer-read-only buffer-read-only)) ! (revert-buffer 'ignore-auto 'dont-ask 'preserve-modes))) (when buffer-file-name (when eob (goto-char (point-max))) (dolist (window eoblist) --- 684,691 ---- ;; not to forget that. This gives undesirable results when ;; the file's mode changes, but that is less common. (let ((buffer-read-only buffer-read-only)) ! (ignore-errors ! (revert-buffer 'ignore-auto 'dont-ask 'preserve-modes)))) (when buffer-file-name (when eob (goto-char (point-max))) (dolist (window eoblist) --8<---------------cut here---------------end--------------->8--- > Sincerely, > Anders Lindgren Best regards, Michael.