From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#22440: 25.1.50; package.el fails to install with package-check-signature t Date: Wed, 18 May 2016 16:24:17 -0300 Message-ID: <87vb2b6ufy.fsf@gmail.com> References: <87a8nxxgqu.fsf@udel.edu> <57381F2D.70007@cs.ucla.edu> <3ea72c05-4bdb-3301-aead-ea7eb25947bc@yandex.ru> <5738A8D5.5030206@cs.ucla.edu> <1fe8c642-202d-a037-5125-8fb733e5f414@yandex.ru> <20160518164405.GA9932@holos.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1463599533 11418 80.91.229.3 (18 May 2016 19:25:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 May 2016 19:25:33 +0000 (UTC) Cc: Mark Oteiza , ueno@gnu.org, 22440@debbugs.gnu.org, Dmitry Gutov To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 18 21:25:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b375t-0007ek-Js for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 May 2016 21:25:21 +0200 Original-Received: from localhost ([::1]:46796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b375p-0007nb-Gd for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 May 2016 15:25:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b375g-0007i5-4n for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 15:25:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b375Z-0001fo-Tq for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 15:25:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b375Z-0001fk-QM for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 15:25:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b375Z-0008UR-J2 for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 15:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 May 2016 19:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 22440-submit@debbugs.gnu.org id=B22440.146359947632600 (code B ref 22440); Wed, 18 May 2016 19:25:01 +0000 Original-Received: (at 22440) by debbugs.gnu.org; 18 May 2016 19:24:36 +0000 Original-Received: from localhost ([127.0.0.1]:57273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b375A-0008Tj-G4 for submit@debbugs.gnu.org; Wed, 18 May 2016 15:24:36 -0400 Original-Received: from mail-qg0-f48.google.com ([209.85.192.48]:36304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3757-0008TV-3m for 22440@debbugs.gnu.org; Wed, 18 May 2016 15:24:34 -0400 Original-Received: by mail-qg0-f48.google.com with SMTP id w36so31596741qge.3 for <22440@debbugs.gnu.org>; Wed, 18 May 2016 12:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FrsO85fUVFePq+Q6BKBM70e8zG6l//TZ33D93togPog=; b=e1oL8geGKKkDZQpZ78N9cViAK6SkjBIGPYiCBHSm7R0SOZY1GQRBL+SBtlXy2GyOJo nDmJW5LpqAk8LOHj/W8XqL2h9JWohAAjN+8BZvYntYMAyWniIUszrL/FJRv76BI3fqPT JljogjsfMJ5QhoXn8qNZIca9poqwVt9V9rrcSdRq1yV4tDxEE4FJmfi8voIXk+NoH3G+ nsU56/UmFFseHx6OVA2VDwlHahrmzCxIiR2a5ThGCc+ohULXaEVUsxRcNeCmDK9m4OWw aYSMQJfekUB5ehsq6SqKorNsUNoeDaJRM54eH5irCZUP/cs5I/5a/eOC1EBviViHVzQp k/0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=FrsO85fUVFePq+Q6BKBM70e8zG6l//TZ33D93togPog=; b=e+/sqWaQJRzQsf6NWJikw85zJ9GWnCsrDtXd532zVYCijbPi2hD28rhfJreyB9y/xr tALt/7SHWVZ1LjJ2WJtoI7dPhr2T+llNc4/PFs7kiQd7yst6aqO4FohLFbW3/ynzBx71 w+6WYIs4BC7EUQHJJXeUj6Avv9ph+3Dc/NZ1iwMmwXnSpexzcqz86T9/svTEUIkoTMrq bkWFiaa/WI/PZNf+Tom4CboFRrYbqRxqWRMfHQoUBntQLx2rE7m1TAuvbVXTPrmh4GO0 PgJ03D0p6ksd0s+r+8MZzKEWDrwV8u/+sMozCnsT5D2rz7wXTucFffju+5orvkG4FfI9 9Fag== X-Gm-Message-State: AOPr4FUzbyZmxbYnJzFY8Gq1AsVp/h6McfPppLCyKhAHE/c0jmK9UhDQbKX6unfTkI8I6g== X-Received: by 10.140.223.10 with SMTP id t10mr9856032qhb.96.1463599467552; Wed, 18 May 2016 12:24:27 -0700 (PDT) Original-Received: from Gandalf-Linux.gmail.com ([179.184.224.5]) by smtp.gmail.com with ESMTPSA id f83sm4876258qkb.25.2016.05.18.12.24.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 May 2016 12:24:26 -0700 (PDT) In-Reply-To: (Paul Eggert's message of "Wed, 18 May 2016 11:10:14 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118410 Archived-At: Paul Eggert writes: > I observed the same thing, but as I have no idea how packages ought to work I didn't know whether that was expected. If not, it's a bug too -- > should it get a different bug report or is this all the same bug? Yes, it's a bug. Looks like it was introduced by the commit below. I've CC'd Daiki. 14aec913ac3f0dd408487c0e8327403e0f239964 Author: Daiki Ueno AuthorDate: Wed Feb 17 16:44:16 2016 +0900 Take advantage of new GnuPG version check function * lisp/emacs-lisp/package.el (epg-configuration-find): Declare. (package-refresh-contents): Use `epg-configuration-find' to check if EPG is usable. 1 file changed, 9 insertions(+), 6 deletions(-) lisp/emacs-lisp/package.el | 15 +++++++++------ modified lisp/emacs-lisp/package.el @@ -1452,9 +1452,8 @@ package-initialize (defvar package--downloads-in-progress nil "List of in-progress asynchronous downloads.") -(declare-function epg-check-configuration "epg-config" - (config &optional minimum-version)) -(declare-function epg-configuration "epg-config" ()) +(declare-function epg-configuration-find "epg-config" + (protocol &optional force)) (declare-function epg-import-keys-from-file "epg" (context keys)) ;;;###autoload @@ -1554,11 +1553,15 @@ package-refresh-contents (let ((default-keyring (expand-file-name "package-keyring.gpg" data-directory)) (inhibit-message async)) + (if (get 'package-check-signature 'saved-value) + (when package-check-signature + (epg-configuration-find 'OpenPGP)) + (setq package-check-signature + (if (epg-configuration-find 'OpenPGP) + 'allow-unsigned))) (when (and package-check-signature (file-exists-p default-keyring)) (condition-case-unless-debug error - (progn - (epg-check-configuration (epg-configuration)) - (package-import-keyring default-keyring)) + (package-import-keyring default-keyring) (error (message "Cannot import default keyring: %S" (cdr error)))))) (package--download-and-read-archives async))