From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#23785: Emacs 25: 'Undo' overdoes things. Date: Mon, 20 Jun 2016 16:03:35 +0100 Message-ID: <87vb13ewc8.fsf@russet.org.uk> References: <20160617150245.GB3316@acm.fritz.box> <83r3bvbuu1.fsf@gnu.org> <20160617174535.GD3316@acm.fritz.box> <83oa6zbmvd.fsf@gnu.org> <87ziqjwkrb.fsf@russet.org.uk> <83eg7vaq3z.fsf@gnu.org> <83bn2y9v80.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466435172 25588 80.91.229.3 (20 Jun 2016 15:06:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Jun 2016 15:06:12 +0000 (UTC) Cc: acm@muc.de, 23785@debbugs.gnu.org To: "Stefan Monnier" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 20 17:06:00 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bF0lp-0005zy-7t for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Jun 2016 17:05:49 +0200 Original-Received: from localhost ([::1]:44213 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0lo-0006fj-AH for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Jun 2016 11:05:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0lA-0006Al-K2 for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2016 11:05:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF0l4-0002vJ-Hi for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2016 11:05:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0l4-0002vF-FA for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2016 11:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bF0l4-00007R-Ac for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2016 11:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jun 2016 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23785-submit@debbugs.gnu.org id=B23785.1466435050369 (code B ref 23785); Mon, 20 Jun 2016 15:05:02 +0000 Original-Received: (at 23785) by debbugs.gnu.org; 20 Jun 2016 15:04:10 +0000 Original-Received: from localhost ([127.0.0.1]:47845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0kE-00005s-2y for submit@debbugs.gnu.org; Mon, 20 Jun 2016 11:04:10 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:39695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0kC-00005f-Er for 23785@debbugs.gnu.org; Mon, 20 Jun 2016 11:04:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:References:Message-ID :Date:In-Reply-To:Subject:Cc:To:From; bh=dt57BGTyY1d8t8c2rcKnWrjmEove9tsNCj42mXV+VHY=; b=McYSmCzrIzMpoAJhn9hmCt1PKa OkwnAiTxX05XXTETiz9sjG5sfeUnvkpO7ZJ39NgAIGwbLF8aXt99F7Jsq+pkfoxw157rDnnEeFg7a OdqE4eBwoC5axbbjVYtObGlbgKANYmmCH17Btplnex0c7IEf53sgRA8UAzlMmtaQ2TX7NVP5KFcDv dxDw7adau/shG7RF/2pL1ckcpFrymLw5YL31I3A7L3Xb2dG/1h32Z/vCw4euz82NcsgmMLUXWVBE6 88n9XpG/iTzYQ18EELYeSGX70O48zLZELVhzUeqA2YpnNJq/V6ZJIAVkt5yERwQH7jSTP8rU40Tka brn6OP6w==; Original-Received: from janus-nat-128-240-225-60.ncl.ac.uk ([128.240.225.60]:32765 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bF0k6-003ID7-7M; Mon, 20 Jun 2016 16:04:02 +0100 In-Reply-To: (Phillip Lord's message of "Sun, 19 Jun 2016 23:45:44 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119836 Archived-At: "Phillip Lord" writes: > On Sat, June 18, 2016 8:52 pm, Stefan Monnier wrote: >>> My concern is not with the behavior the proposed change intends to get >>> us, the concern is with the unintended consequences of the change. At >>> this late stage, I'd like to keep the risk of unintended consequences to >>> the minimum, unless we want this change so badly we agree to extend the >>> pretesting by another month or two. >> >> Yes, that's the other side of the coin, indeed. > > So many possibilities! So, final patch possibility -- this one, I think directly fixes the problem -- it ensures that the changes in the buffer result in an undoable change. It's probably less efficient (cause the undo-list will be created, then dumped), but is the most minimal change. My suggestion: this patch goes to Emacs-25. And the previous patch (which automatically adds an undo boundary to current-buffer regardless of changes), goes to master. Phil