From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#23785: Emacs 25: 'Undo' overdoes things. Date: Tue, 21 Jun 2016 15:30:46 +0100 Message-ID: <87vb12ty09.fsf@russet.org.uk> References: <20160617150245.GB3316@acm.fritz.box> <83r3bvbuu1.fsf@gnu.org> <20160617174535.GD3316@acm.fritz.box> <83oa6zbmvd.fsf@gnu.org> <87ziqjwkrb.fsf@russet.org.uk> <83eg7vaq3z.fsf@gnu.org> <83bn2y9v80.fsf@gnu.org> <87vb13ewc8.fsf@russet.org.uk> <83wplj7u2t.fsf@gnu.org> <8737o7aio2.fsf@russet.org.uk> <83fus67kap.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466519492 29732 80.91.229.3 (21 Jun 2016 14:31:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 21 Jun 2016 14:31:32 +0000 (UTC) Cc: acm@muc.de, 23785@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 21 16:31:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bFMhw-0005UL-WE for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Jun 2016 16:31:17 +0200 Original-Received: from localhost ([::1]:52318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFMhw-00081A-DB for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Jun 2016 10:31:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFMhl-0007xu-Cg for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 10:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFMhh-0002xr-UL for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 10:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFMhh-0002xl-Qt for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 10:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bFMhh-0005PO-Mb for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 10:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jun 2016 14:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23785-submit@debbugs.gnu.org id=B23785.146651945420774 (code B ref 23785); Tue, 21 Jun 2016 14:31:01 +0000 Original-Received: (at 23785) by debbugs.gnu.org; 21 Jun 2016 14:30:54 +0000 Original-Received: from localhost ([127.0.0.1]:49867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFMhZ-0005P0-NW for submit@debbugs.gnu.org; Tue, 21 Jun 2016 10:30:53 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:50807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFMhY-0005Oo-K4 for 23785@debbugs.gnu.org; Tue, 21 Jun 2016 10:30:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From; bh=vmADU5P3HDui1dV5MERP+s9vBWmrWgoJgz2gdu0YYcM=; b=BSD+9I0Xoi50hpnpIk9bHi7VbW MbndYtvPL7tUqbPsmZiwvJY3E7AvQjatuY2KgpCNlRrdmpy8sePCMxav/8sgAIGgvAyp2D7sPCGlO m/Dxk2rLr+QjrxyaHqa91WGu7CnPyhX5aGdL6fD7NmYwVzDJtXoQsU+22FYBGSsp4Wzyjx5Srbqn/ al6j9N6rn0PqmRLofXAIvSLj0Yp2WApP9oBbD83F9D5GtmudiiXnJ2vLkjj29C5PFCcSPIVvAILMj Su5f3Sr/vNElRAjPpzUO9FZ8p91kYMP87A4ZOUMCa8Doz5XswAraNTZsla7tgUz37+r2trYJTjQMt gIYMGI4g==; Original-Received: from janus-nat-128-240-225-60.ncl.ac.uk ([128.240.225.60]:33104 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bFMhS-002bOo-Uv; Tue, 21 Jun 2016 15:30:47 +0100 In-Reply-To: <83fus67kap.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Jun 2016 16:17:50 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119886 Archived-At: Eli Zaretskii writes: >> From: phillip.lord@russet.org.uk (Phillip Lord) >> Cc: monnier@iro.umontreal.ca, acm@muc.de, 23785@debbugs.gnu.org >> Date: Mon, 20 Jun 2016 18:12:29 +0100 >> >> >> From: phillip.lord@russet.org.uk (Phillip Lord) >> >> Cc: "Eli Zaretskii" , acm@muc.de, 23785@debbugs.gnu.org >> >> Date: Mon, 20 Jun 2016 16:03:35 +0100 >> >> >> >> My suggestion: this patch goes to Emacs-25. >> > >> > What patch? >> >> Eli, do pay attention! The one that I didn't attach obviously. > > Thanks, please push to the emacs-25 branch, with one change: > >> + /* >> + Temporarily enable the undo-buffer to ensure that the change >> + is marked as an undoable one. Bug #23785. >> + */ > > Please format this comment according to our style. Okay. Stefan, can you have a quick look as well. This function is well out of my depth of understanding. Phil