From: phillip.lord@russet.org.uk (Phillip Lord)
To: Markus Triska <triska@metalevel.at>
Cc: 23871@debbugs.gnu.org
Subject: bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer
Date: Thu, 30 Jun 2016 22:45:00 +0100 [thread overview]
Message-ID: <87vb0qqrkz.fsf@russet.org.uk> (raw)
In-Reply-To: <87poqyy2tc.fsf@metalevel.at> (Markus Triska's message of "Thu, 30 Jun 2016 20:00:31 +0200")
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
Markus Triska <triska@metalevel.at> writes:
> Please see #21722. It shows that point position after undo is different
> from what it was before, just as in this case. I constructed the case
> shown in #21722 due to the issues with undo after process output, and I
> suspect these issues are related. Redisplay may also be involved.
>
>
>> Also, how important is it to have exactly the font you mention and
>> exactly that size? (I tried that font and that size, as well as a few
>> others, but that didn't help in my case.)
>
> The font and even window size definitely have an impact on this
> issue. Please try a different window size, and I hope you can then
> reproduce the issue, or at least #21722.
I believe the following patch fixes #21722.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-missing-point-information-in-undo.patch --]
[-- Type: text/x-diff, Size: 783 bytes --]
From 6687d6162941b7d5a5d7e41c3a7e1b1a1527538f Mon Sep 17 00:00:00 2001
From: Phillip Lord <phillip.lord@russet.org.uk>
Date: Thu, 30 Jun 2016 22:06:00 +0100
Subject: [PATCH] Fix missing point information in undo
* src/undo.c (record_insert): Use record_point instead of
prepare_record.
Addresses Bug# 21722
---
src/undo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/undo.c b/src/undo.c
index be5b270..cafe351 100644
--- a/src/undo.c
+++ b/src/undo.c
@@ -83,7 +83,7 @@ record_insert (ptrdiff_t beg, ptrdiff_t length)
if (EQ (BVAR (current_buffer, undo_list), Qt))
return;
- prepare_record ();
+ record_point (beg);
/* If this is following another insertion and consecutive with it
in the buffer, combine the two. */
--
2.9.0
next prev parent reply other threads:[~2016-06-30 21:45 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 21:47 bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer Markus Triska
2016-06-30 16:38 ` Eli Zaretskii
2016-06-30 18:00 ` Markus Triska
2016-06-30 18:21 ` Eli Zaretskii
2016-06-30 18:52 ` Eli Zaretskii
2016-06-30 21:45 ` Phillip Lord [this message]
2016-07-01 6:31 ` Markus Triska
2016-07-01 7:25 ` Eli Zaretskii
2016-07-01 14:04 ` Phillip Lord
2016-07-01 20:38 ` Markus Triska
2016-07-01 22:12 ` Phillip Lord
2016-07-01 20:49 ` Markus Triska
2016-07-01 22:21 ` Phillip Lord
2016-07-02 5:35 ` Markus Triska
2016-07-02 7:35 ` Eli Zaretskii
2016-07-02 20:21 ` Phillip Lord
2016-07-02 20:53 ` Markus Triska
2016-07-03 3:33 ` Eli Zaretskii
2016-07-03 9:37 ` Phillip Lord
2016-07-03 10:08 ` Markus Triska
2016-07-03 12:55 ` Phillip Lord
2016-07-03 15:30 ` Eli Zaretskii
2016-07-03 20:21 ` Phillip Lord
2016-07-03 18:05 ` Markus Triska
2016-07-03 20:23 ` Phillip Lord
2016-07-03 22:03 ` Markus Triska
2016-07-04 14:38 ` Eli Zaretskii
2016-07-05 16:36 ` Eli Zaretskii
2016-07-05 19:44 ` Phillip Lord
2016-07-05 20:02 ` Markus Triska
2016-07-05 19:47 ` Markus Triska
2016-07-05 20:00 ` Eli Zaretskii
2016-07-03 15:12 ` Eli Zaretskii
2016-07-03 18:09 ` Markus Triska
2016-07-03 19:20 ` Eli Zaretskii
2016-07-03 20:37 ` Phillip Lord
2016-07-03 3:31 ` Eli Zaretskii
2016-07-03 9:39 ` Phillip Lord
2016-07-03 21:33 ` Stefan Monnier
2016-07-04 20:34 ` Phillip Lord
2016-07-04 21:32 ` Stefan Monnier
2016-07-05 8:43 ` Phillip Lord
2016-07-05 20:32 ` Markus Triska
2016-07-05 22:00 ` Stefan Monnier
2016-07-05 22:17 ` Phillip Lord
2016-07-05 22:09 ` Phillip Lord
2016-07-05 23:03 ` Markus Triska
2016-07-06 16:02 ` Phillip Lord
2016-07-06 17:59 ` Markus Triska
2016-08-12 23:03 ` npostavs
2016-08-13 8:02 ` Markus Triska
2016-07-05 8:46 ` undo refactoring Phillip Lord
2016-07-05 21:50 ` Stefan Monnier
2016-07-05 22:22 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb0qqrkz.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=23871@debbugs.gnu.org \
--cc=triska@metalevel.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.