From: "Alex Bennée" <alex.bennee@linaro.org>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks
Date: Fri, 15 Jul 2016 17:39:48 +0100 [thread overview]
Message-ID: <87vb066ejv.fsf@linaro.org> (raw)
Hi,
This seems to have been introduced by commit:
3a9d6296b35e5317c497674d5725eb52699bd3b8
Author: Eli Zaretskii <eliz@gnu.org>
Avoid crashes when buffer modification hooks clobber match data
* src/search.c (Freplace_match): Error out if buffer modification
hooks triggered by buffer changes in replace_range, upcase-region,
and upcase-initials-region clobber the match data needed to be
adjusted for the replacement. (Bug#23869)
1 file changed, 13 insertions(+)
src/search.c | 13 +++++++++++++
I have a org-capture template set up that's triggered by a helper
function:
(defun my-capture-review-tags ()
"Return a list of DCO style tags for current buffer."
(let ((tags))
(save-excursion
(goto-char (point-min))
(while (re-search-forward my-dco-tag-re (point-max) t)
(add-to-list 'tags (match-string-no-properties 0))))
tags))
(defun my-org-maybe-capture-review-tag ()
"Check buffer for DCO tags and if found queue a review comment."
(interactive)
(let ((tags (my-capture-review-tags)))
(when tags
(kill-new (mapconcat 'identity tags "\n"))
(org-capture nil "g"))))
And the following template:
("g" "Save reference to review tag"
entry
(file+headline "review.org" "Review Tags")
"** %a\n%c" :immediate-finish t)
But I'm not sure what's going on. Obviously there is match data setup as
I snarf the tags but I don't care about them by the time I run the
template insert. It's hard to tell what hooks are running that might be
doing something like this.
I tried setting debug-on-message to:
(setq debug-on-message "\\(?:Match data clobbered by\\)")
But it wouldn't trigger at all so I'm a little stumped by what is going
on? Have I done something wrong in my code or triggered a bug somewhere else?
--
Alex Bennée
next reply other threads:[~2016-07-15 16:39 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 16:39 Alex Bennée [this message]
2016-07-15 17:39 ` org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks Eli Zaretskii
2016-07-15 19:12 ` Alex Bennée
2016-07-15 19:37 ` Noam Postavsky
2016-07-15 21:56 ` Alex Bennée
2016-07-16 16:01 ` Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) N. Jackson
2016-07-16 16:11 ` Eli Zaretskii
2016-07-16 17:09 ` John Wiegley
2016-07-17 17:28 ` Alex Bennée
2016-07-17 17:41 ` Eli Zaretskii
2016-07-18 12:24 ` bug#23917: " Robert Pluim
2016-07-18 12:24 ` Robert Pluim
2016-07-18 18:09 ` Eli Zaretskii
2016-07-18 18:09 ` Eli Zaretskii
2016-07-18 19:04 ` John Wiegley
2016-07-18 19:10 ` Eli Zaretskii
2016-07-18 19:10 ` Eli Zaretskii
2016-07-18 19:04 ` John Wiegley
2016-07-19 0:58 ` Stefan Monnier
2016-07-19 2:40 ` Eli Zaretskii
2016-07-19 4:48 ` Stefan Monnier
2016-07-19 4:48 ` Stefan Monnier
2016-07-19 15:35 ` Eli Zaretskii
2016-07-19 16:03 ` Stefan Monnier
2016-07-19 16:03 ` Stefan Monnier
2016-07-19 16:13 ` Eli Zaretskii
2016-07-19 16:13 ` Eli Zaretskii
2016-07-19 17:05 ` bug#23917: " Alex Bennée
2016-07-19 17:05 ` bug#23917: [O] " Alex Bennée
2016-07-19 17:20 ` bug#23917: " Eli Zaretskii
2016-07-19 17:20 ` bug#23917: [O] " Eli Zaretskii
2016-07-19 17:45 ` Alex Bennée
2016-07-19 18:07 ` Sebastian Wiesner
2016-07-19 18:07 ` bug#23917: " Sebastian Wiesner
2016-07-19 18:44 ` bug#23917: [O] " Eli Zaretskii
2016-07-19 18:44 ` bug#23917: " Eli Zaretskii
2016-07-20 9:48 ` bug#23917: " Alex Bennée
2016-07-20 9:48 ` bug#23917: [O] " Alex Bennée
2016-07-20 14:59 ` bug#23917: " Eli Zaretskii
2016-07-20 14:59 ` bug#23917: [O] " Eli Zaretskii
2016-07-19 17:45 ` Alex Bennée
2016-07-20 1:50 ` Stefan Monnier
2016-07-20 1:50 ` Stefan Monnier
2016-07-20 14:55 ` Eli Zaretskii
2016-07-20 14:55 ` Eli Zaretskii
2016-07-20 18:19 ` Stefan Monnier
2016-07-20 18:19 ` Stefan Monnier
2016-07-20 18:55 ` Eli Zaretskii
2016-07-20 18:55 ` Eli Zaretskii
2016-07-20 20:54 ` Stefan Monnier
2016-07-21 0:56 ` npostavs
2016-07-21 1:47 ` Stefan Monnier
2016-07-21 2:34 ` Noam Postavsky
2016-07-21 2:34 ` Noam Postavsky
2016-07-21 3:06 ` Stefan Monnier
2016-07-21 3:06 ` Stefan Monnier
2016-07-21 1:47 ` Stefan Monnier
2016-07-21 2:43 ` Eli Zaretskii
2016-07-21 2:43 ` Eli Zaretskii
2016-07-21 3:00 ` npostavs
2016-07-21 14:26 ` Eli Zaretskii
2016-07-21 14:26 ` Eli Zaretskii
2016-07-22 1:08 ` npostavs
2016-07-22 6:43 ` Eli Zaretskii
2016-07-22 14:01 ` Robert Pluim
2016-07-22 14:01 ` Robert Pluim
2016-07-22 19:30 ` Nicolas Petton
2016-07-22 19:30 ` Nicolas Petton
2016-07-23 4:19 ` npostavs
2016-07-23 4:19 ` npostavs
2016-07-22 6:43 ` Eli Zaretskii
2016-07-23 0:42 ` bug#23917: Re: bug#23917: 25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out N. Jackson
2016-07-23 7:38 ` Eli Zaretskii
2016-07-23 7:38 ` Eli Zaretskii
2016-07-23 0:42 ` bug#23917: " N. Jackson
2016-07-22 1:08 ` bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) npostavs
2016-07-21 3:00 ` npostavs
2016-07-21 7:59 ` bug#23917: 25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out N. Jackson
2016-07-21 8:19 ` Robert Pluim
2016-07-21 8:19 ` Robert Pluim
2016-07-08 12:42 ` Robert Pluim
2016-07-08 14:02 ` Eli Zaretskii
2016-07-08 15:40 ` Robert Pluim
2016-07-08 17:03 ` Eli Zaretskii
2016-07-15 19:46 ` Eli Zaretskii
2016-07-15 19:46 ` Eli Zaretskii
2016-07-08 17:03 ` Eli Zaretskii
2016-07-21 14:24 ` N. Jackson
2016-07-21 14:24 ` N. Jackson
2016-07-21 7:59 ` N. Jackson
2016-07-21 0:56 ` bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) npostavs
2016-07-20 20:54 ` Stefan Monnier
2016-07-19 23:18 ` npostavs
2016-07-19 23:18 ` npostavs
2016-07-19 15:35 ` Eli Zaretskii
2016-07-19 2:40 ` Eli Zaretskii
2016-07-19 15:36 ` Eli Zaretskii
2016-07-19 15:36 ` Eli Zaretskii
2016-07-19 0:58 ` Stefan Monnier
2016-07-21 7:52 ` bug#23917: 25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out N. Jackson
2016-07-21 8:08 ` Robert Pluim
2016-07-21 13:19 ` N. Jackson
2016-07-21 13:19 ` N. Jackson
2016-07-21 8:08 ` Robert Pluim
2016-07-21 7:52 ` N. Jackson
2016-07-18 14:50 ` bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) Kaushal Modi
2016-07-18 14:50 ` Kaushal Modi
[not found] ` <9613abde4dbd48fdb2b5e780101a13a0@HE1PR01MB1898.eurprd01.prod.exchangelabs.com>
2016-07-18 16:59 ` Eric S Fraga
2016-07-18 16:59 ` Eric S Fraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb066ejv.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.