From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#24118: 25.1; [PATCH] Fix a possible crash caused by mapcar1 Date: Sun, 31 Jul 2016 15:18:09 +0200 Message-ID: <87vazmj69a.fsf@linux-m68k.org> References: <86fuqq2cw5.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1469971173 10003 80.91.229.8 (31 Jul 2016 13:19:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 31 Jul 2016 13:19:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24118@debbugs.gnu.org To: Chris Feng Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 31 15:19:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTqeC-0002YJ-04 for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Jul 2016 15:19:16 +0200 Original-Received: from localhost ([::1]:39624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTqe8-0002Od-5i for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Jul 2016 09:19:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTqe2-0002OT-Hj for bug-gnu-emacs@gnu.org; Sun, 31 Jul 2016 09:19:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bTqdy-0000AU-F8 for bug-gnu-emacs@gnu.org; Sun, 31 Jul 2016 09:19:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTqdy-0000AP-Bb for bug-gnu-emacs@gnu.org; Sun, 31 Jul 2016 09:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bTqdy-0000T2-7g for bug-gnu-emacs@gnu.org; Sun, 31 Jul 2016 09:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Jul 2016 13:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24118 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24118-submit@debbugs.gnu.org id=B24118.14699710931734 (code B ref 24118); Sun, 31 Jul 2016 13:19:02 +0000 Original-Received: (at 24118) by debbugs.gnu.org; 31 Jul 2016 13:18:13 +0000 Original-Received: from localhost ([127.0.0.1]:52002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTqdB-0000Rt-EI for submit@debbugs.gnu.org; Sun, 31 Jul 2016 09:18:13 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]:37757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTqd9-0000Rk-Hw for 24118@debbugs.gnu.org; Sun, 31 Jul 2016 09:18:12 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3s2NLp3zMVz3hjJn; Sun, 31 Jul 2016 15:18:10 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3s2NLp2H7Lzvkq7; Sun, 31 Jul 2016 15:18:10 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id AtRIxMMcQs_P; Sun, 31 Jul 2016 15:18:09 +0200 (CEST) X-Auth-Info: WJH677wRXwe7G3D4/loIVDctm67QOFst6r/oIzSI0IcVk60LTzAq6XiGgHFgFpTj Original-Received: from igel.home (ppp-88-217-24-60.dynamic.mnet-online.de [88.217.24.60]) by mail.mnet-online.de (Postfix) with ESMTPA; Sun, 31 Jul 2016 15:18:09 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 450DF2C255D; Sun, 31 Jul 2016 15:18:09 +0200 (CEST) X-Yow: This is PLEASANT! In-Reply-To: <86fuqq2cw5.fsf@gmail.com> (Chris Feng's message of "Sun, 31 Jul 2016 20:46:50 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121735 Archived-At: Chris Feng writes: > diff --git a/src/fns.c b/src/fns.c > index d5a1f74..1804bce 100644 > --- a/src/fns.c > +++ b/src/fns.c > @@ -2524,6 +2524,10 @@ mapcar1 (EMACS_INT leni, Lisp_Object *vals, Lisp_Object fn, Lisp_Object seq) > vals[i] = dummy; > tail = XCDR (tail); > } > + > + /* In case the list was tampered and the loop terminated early. */ > + if (i < leni) > + memclear (vals + i, (leni - i) * word_size); That should not depend on the representation of Qnil. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."