From: Andreas Schwab <schwab@linux-m68k.org>
To: Chris Feng <chris.w.feng@gmail.com>
Cc: 24118@debbugs.gnu.org
Subject: bug#24118: 25.1; [PATCH] Fix a possible crash caused by mapcar1
Date: Sun, 31 Jul 2016 15:18:09 +0200 [thread overview]
Message-ID: <87vazmj69a.fsf@linux-m68k.org> (raw)
In-Reply-To: <86fuqq2cw5.fsf@gmail.com> (Chris Feng's message of "Sun, 31 Jul 2016 20:46:50 +0800")
Chris Feng <chris.w.feng@gmail.com> writes:
> diff --git a/src/fns.c b/src/fns.c
> index d5a1f74..1804bce 100644
> --- a/src/fns.c
> +++ b/src/fns.c
> @@ -2524,6 +2524,10 @@ mapcar1 (EMACS_INT leni, Lisp_Object *vals, Lisp_Object fn, Lisp_Object seq)
> vals[i] = dummy;
> tail = XCDR (tail);
> }
> +
> + /* In case the list was tampered and the loop terminated early. */
> + if (i < leni)
> + memclear (vals + i, (leni - i) * word_size);
That should not depend on the representation of Qnil.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2016-07-31 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 12:46 bug#24118: 25.1; [PATCH] Fix a possible crash caused by mapcar1 Chris Feng
2016-07-31 13:18 ` Andreas Schwab [this message]
2016-07-31 13:33 ` Chris Feng
2016-08-03 1:15 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vazmj69a.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=24118@debbugs.gnu.org \
--cc=chris.w.feng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.