From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string. Date: Fri, 09 Sep 2016 20:07:58 +0200 Message-ID: <87vay56j5t.fsf@toke.dk> References: <20160907153014.15752-1-toke@toke.dk> <87inu7k5z4.fsf@toke.dk> <83bmzzaawr.fsf@gnu.org> <877fank1oc.fsf@toke.dk> <87inu6iim8.fsf@toke.dk> <2563921f-d20d-753b-09eb-c8671bc5b6d6@yandex.ru> <87a8fiidso.fsf@toke.dk> <86d1kdq7cs.fsf@realize.ch> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1473444507 1132 195.159.176.226 (9 Sep 2016 18:08:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Sep 2016 18:08:27 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org, monnier@iro.umontreal.ca, Dmitry Gutov To: Alain Schneble Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 09 20:08:22 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biQDs-00085n-IC for ged-emacs-devel@m.gmane.org; Fri, 09 Sep 2016 20:08:20 +0200 Original-Received: from localhost ([::1]:59565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biQDq-0005U2-GQ for ged-emacs-devel@m.gmane.org; Fri, 09 Sep 2016 14:08:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biQDj-0005T8-JN for emacs-devel@gnu.org; Fri, 09 Sep 2016 14:08:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biQDh-0005Oo-EO for emacs-devel@gnu.org; Fri, 09 Sep 2016 14:08:10 -0400 Original-Received: from mail2.tohojo.dk ([77.235.48.147]:47309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biQDc-0005OA-Cr; Fri, 09 Sep 2016 14:08:04 -0400 X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk 41E4940D5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1473444479; bh=EZTY2W7ntSkBdtBbgDBR/zcn2mGvgVaiCFIeT3WEsV4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=tilRDnLo4uV6z4NoQFEFkq9fkfhwhol3qK/dqtb1LCC6/bfAz0RZsFlIgGwoHwFPS kBWmxQiU+eOSmg6u58iI6ovl4dv0TYmsh0ZY8Sj4jYuF2mq5E8htwqunJyqDq7rTT2 s4XA/HUChpuV2zCsyC/mFqx3capyFheVSF9VHCUA= Original-Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 57A1C8163; Fri, 9 Sep 2016 20:07:58 +0200 (CEST) In-Reply-To: <86d1kdq7cs.fsf@realize.ch> (Alain Schneble's message of "Fri, 9 Sep 2016 20:02:43 +0200") X-Clacks-Overhead: GNU Terry Pratchett X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.235.48.147 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207322 Archived-At: Alain Schneble writes: > Toke H=C3=B8iland-J=C3=B8rgensen writes: > >> Dmitry Gutov writes: >>> >>> Could you post the full recipe? >> >> (url-retrieve-synchronously "http://google.se") ; sets a cookie >> (let* ((url-request-data (encode-coding-string "=C3=A6=C3=B8=C3=A5" 'utf= -8))) >> (url-retrieve-synchronously "http://google.se")) ; crashes > > Just two notes on this: > > 1. This example uses a GET request with some body data. I don't think > that this is a real use case. Of course, with other requests such as > POST, where some body data is typically sent, we might run into the > same issue. Yeah, that was not supposed to be a real-world use case, just the shortest code snippet I could get to crash. The actual request that I ran into this bug with was a PUT. -Toke