From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] org-agenda.el Correct :inherit on
 org-agenda-fontify-priorities
Date: Fri, 04 Nov 2016 13:45:24 +0100
Message-ID: <87vaw3behn.fsf@nicolasgoaziou.fr>
References: <8760o3k19z.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59042)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1c2ds3-0006TV-Qi
	for emacs-orgmode@gnu.org; Fri, 04 Nov 2016 08:45:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1c2ds3-0006SA-2X
	for emacs-orgmode@gnu.org; Fri, 04 Nov 2016 08:45:23 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:47928)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1c2ds2-0006P6-SF
	for emacs-orgmode@gnu.org; Fri, 04 Nov 2016 08:45:22 -0400
In-Reply-To: <8760o3k19z.fsf@gmail.com> (Renato Ferreira's message of "Fri, 04
	Nov 2016 08:06:00 -0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Renato Ferreira <renatofdds@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Renato Ferreira <renatofdds@gmail.com> writes:

> When using:
> (setq org-agenda-fontify-priorities 'cookies)
> (setq org-priority-faces '((65 . "#FF9393") (66 . "#CC9393") (67
> . "#AC7373") (68 . "#7C4343")))
>
> (org-agenda-fontify-priorities) generates an (:inherit nil ...) face
> alist, which ultimately (i can't trace specifically where) causes a lot
> of: "Invalid face reference: nil" "Invalid face attribute :inherit nil"
> when generating the agenda buffer (when it contains tasks with
> priorities).
>
> This issue has been present since 8.3 (and earlier i believe), i've
> always patched locally but now i'm using melpa so it would be great if
> someone could verify and merge this.

Thank you. Could you provide a patch using git format-patch, and tweak
commit message so as to conform to our conventions? E.g.,

  Fixes "Invalid face attribute/reference" errors

  * lisp/org-agenda.el (org-agenda-fontify-priorities): ...

  When using:
  (setq org-agenda-fontify-priorities 'cookies)
  (setq org-priority-faces '((65 . "#FF9393") (66 . "#CC9393") (67
  . "#AC7373") (68 . "#7C4343")))

  (org-agenda-fontify-priorities) generates an (:inherit nil ...) face
  alist, which ultimately (i can't trace specifically where) causes a lot
  of: "Invalid face reference: nil" "Invalid face attribute :inherit nil"
  when generating the agenda buffer (when it contains tasks with
  priorities).


Regards,

-- 
Nicolas Goaziou