Re: [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorities

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Renato Ferreira <renatofdds@gmail.com> writes:

> When using:
> (setq org-agenda-fontify-priorities 'cookies)
> (setq org-priority-faces '((65 . "#FF9393") (66 . "#CC9393") (67
> . "#AC7373") (68 . "#7C4343")))
>
> (org-agenda-fontify-priorities) generates an (:inherit nil ...) face
> alist, which ultimately (i can't trace specifically where) causes a lot
> of: "Invalid face reference: nil" "Invalid face attribute :inherit nil"
> when generating the agenda buffer (when it contains tasks with
> priorities).
>
> This issue has been present since 8.3 (and earlier i believe), i've
> always patched locally but now i'm using melpa so it would be great if
> someone could verify and merge this.

Thank you. Could you provide a patch using git format-patch, and tweak
commit message so as to conform to our conventions? E.g.,

  Fixes "Invalid face attribute/reference" errors

  * lisp/org-agenda.el (org-agenda-fontify-priorities): ...

  When using:
  (setq org-agenda-fontify-priorities 'cookies)
  (setq org-priority-faces '((65 . "#FF9393") (66 . "#CC9393") (67
  . "#AC7373") (68 . "#7C4343")))

  (org-agenda-fontify-priorities) generates an (:inherit nil ...) face
  alist, which ultimately (i can't trace specifically where) causes a lot
  of: "Invalid face reference: nil" "Invalid face attribute :inherit nil"
  when generating the agenda buffer (when it contains tasks with
  priorities).


Regards,

-- 
Nicolas Goaziou