From: Tom Tromey <tom@tromey.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 25714@debbugs.gnu.org, Tom Tromey <tom@tromey.com>
Subject: bug#25714: 25.1.91; make "update" flag work with vc-retrieve-tag in git and hg
Date: Mon, 13 Feb 2017 18:32:38 -0700 [thread overview]
Message-ID: <87vasdzhe1.fsf@tromey.com> (raw)
In-Reply-To: <d2cc2448-fc68-14a8-4d62-a2356862dab9@yandex.ru> (Dmitry Gutov's message of "Tue, 14 Feb 2017 03:07:12 +0200")
>>>>> "Dmitry" == Dmitry Gutov <dgutov@yandex.ru> writes:
Dmitry> Any idea why the (vc-resynch-buffer dir t t t) call at the end of
Dmitry> vc-retrieve-tag doesn't do the job?
I must have tested incorrectly, because when I revert my patch, it still
seems to work now :(
Sorry about that. Maybe you should try it to be sure.
How about this patch, that just removes the comments?
Tom
commit 7f2bcbf75eca6e00a8a428d6c838945e01556c1b
Author: Tom Tromey <tom@tromey.com>
Date: Mon Feb 13 17:24:04 2017 -0700
Make vc-git and vc-hg revert buffers on branch switch
* lisp/vc/vc-git.el (vc-git-retrieve-tag): Remove comment.
* lisp/vc/vc-hg.el (vc-hg-retrieve-tag): Remove comment.
diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index 0f58892..8a22d74 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -1240,9 +1240,7 @@ vc-git-create-tag
(defun vc-git-retrieve-tag (dir name _update)
(let ((default-directory dir))
- (vc-git-command nil 0 nil "checkout" name)
- ;; FIXME: update buffers if `update' is true
- ))
+ (vc-git-command nil 0 nil "checkout" name)))
;;; MISCELLANEOUS
diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el
index 2f9487c..8a2b077 100644
--- a/lisp/vc/vc-hg.el
+++ b/lisp/vc/vc-hg.el
@@ -76,7 +76,7 @@
;; - annotate-extract-revision-at-line () OK
;; TAG SYSTEM
;; - create-tag (dir name branchp) OK
-;; - retrieve-tag (dir name update) OK FIXME UPDATE BUFFERS
+;; - retrieve-tag (dir name update) OK
;; MISCELLANEOUS
;; - make-version-backups-p (file) ??
;; - previous-revision (file rev) OK
@@ -562,7 +562,6 @@ vc-hg-retrieve-tag
"Retrieve the version tagged by NAME of all registered files at or below DIR."
(let ((default-directory dir))
(vc-hg-command nil 0 nil "update" name)
- ;; FIXME: update buffers if `update' is true
;; TODO: update *vc-change-log* buffer so can see @ if --graph
))
next prev parent reply other threads:[~2017-02-14 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 0:29 bug#25714: 25.1.91; make "update" flag work with vc-retrieve-tag in git and hg Tom Tromey
2017-02-14 1:07 ` Dmitry Gutov
2017-02-14 1:32 ` Tom Tromey [this message]
2017-02-14 1:47 ` Dmitry Gutov
2017-02-17 1:03 ` Dmitry Gutov
2017-02-25 4:02 ` bug#25714: done Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vasdzhe1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=25714@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.