From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#25764: 26.0.50; Make some usability improvements to sieve-script management Date: Thu, 16 Feb 2017 13:13:41 -0800 Message-ID: <87vas9rg8q.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1487279659 29691 195.159.176.226 (16 Feb 2017 21:14:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 16 Feb 2017 21:14:19 +0000 (UTC) To: 25764@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 16 22:14:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceTNQ-00071X-NW for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Feb 2017 22:14:08 +0100 Original-Received: from localhost ([::1]:50354 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceTNW-0006Ic-JB for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Feb 2017 16:14:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceTNN-0006GT-Sx for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2017 16:14:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ceTNK-0007Kw-MT for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2017 16:14:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44480) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ceTNK-0007Kc-JB for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2017 16:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ceTNK-000210-8F for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2017 16:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Feb 2017 21:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14872796387727 (code B ref -1); Thu, 16 Feb 2017 21:14:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Feb 2017 21:13:58 +0000 Original-Received: from localhost ([127.0.0.1]:42679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceTNF-00020Z-Ji for submit@debbugs.gnu.org; Thu, 16 Feb 2017 16:13:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceTNC-00020L-GC for submit@debbugs.gnu.org; Thu, 16 Feb 2017 16:13:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ceTN6-0007Eu-0W for submit@debbugs.gnu.org; Thu, 16 Feb 2017 16:13:49 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:45737) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ceTN5-0007Em-TS for submit@debbugs.gnu.org; Thu, 16 Feb 2017 16:13:47 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceTN4-000663-LX for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2017 16:13:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ceTN1-0007BW-FT for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2017 16:13:46 -0500 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:49100) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ceTN1-0007Ax-8s for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2017 16:13:43 -0500 Original-Received: from localhost (71-212-6-137.tukw.qwest.net [71.212.6.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 18BA6BEE28 for ; Thu, 16 Feb 2017 21:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1487279622; bh=Ad+VPovt6KzB8mZk2uBFJpMw/FpI6BsPMNFGc/KdN4M=; h=From:To:Subject:Date:From; b=Hfx8nJpqRv5Jjxh8Sga60fItcWXIyc0efKuYH6I1Dvgs2MAx5TnWHOrKOleOj0q4B nxuFSrxZZ01ZWpLT/0jHGY5XO9yhvLFewbGAXNXUmrh8Uf3iSuelvSFCAEzJvMHqO7 VeDrn8EVOuaZmzAmpVcmU31kk1eESU5h45Ivo6zw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129420 Archived-At: --=-=-= Content-Type: text/plain The attached patch makes some usability improvements to the sieve script management files: exposing more user commands in menus and help, and using the buffer-modified mark to give the user a better sense of what's going on. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Small-improvements-to-sieve-script-usability.patch >From e7c62b1bb8212034cba5502a7dec2c2786f4159f Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Thu, 16 Feb 2017 12:57:53 -0800 Subject: [PATCH] Small improvements to sieve script usability * lisp/net/sieve-mode.el (sieve-mode-menu): Add `sieve-upload-and-kill' to the mode menu. * lisp/net/sieve.el (sieve-manage-mode-menu): Add `sieve-manage-quit' to the mode menu. (sieve-help): Mention quitting in mode help. (sieve-manage-mode): Directly derive from special-mode. (sieve-edit-script): Start off with unmodified buffer. (sieve-upload): Set buffer unmodified after successful upload. Changes are aimed at 1) increasing discoverability of commands and 2) using buffer modification to help users understand what's happening. --- lisp/net/sieve-mode.el | 1 + lisp/net/sieve.el | 22 ++++++++++++---------- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/lisp/net/sieve-mode.el b/lisp/net/sieve-mode.el index 87bb3a245b..cc5fb389e2 100644 --- a/lisp/net/sieve-mode.el +++ b/lisp/net/sieve-mode.el @@ -158,6 +158,7 @@ sieve-mode-map "Sieve Menu." '("Sieve" ["Upload script" sieve-upload t] + ["Upload script and kill" sieve-upload-and-kill t] ["Manage scripts on server" sieve-manage t])) ;; Code for Sieve editing mode. diff --git a/lisp/net/sieve.el b/lisp/net/sieve.el index 665a0a8e15..46cea316e3 100644 --- a/lisp/net/sieve.el +++ b/lisp/net/sieve.el @@ -137,16 +137,15 @@ sieve-manage-mode-map '("Manage Sieve" ["Edit script" sieve-edit-script t] ["Activate script" sieve-activate t] - ["Deactivate script" sieve-deactivate t])) + ["Deactivate script" sieve-deactivate t] + ["Quit and close connection" sieve-manage-quit t])) -(define-derived-mode sieve-manage-mode fundamental-mode "Sieve-manage" +(define-derived-mode sieve-manage-mode special-mode "Sieve-manage" "Mode used for sieve script management." (buffer-disable-undo (current-buffer)) (setq truncate-lines t) (easy-menu-add sieve-manage-mode-menu sieve-manage-mode-map)) -(put 'sieve-manage-mode 'mode-class 'special) - ;; Commands used in sieve-manage mode: (defun sieve-manage-quit () @@ -215,6 +214,7 @@ sieve-edit-script (sieve-mode) (setq sieve-buffer-script-name name) (goto-char (point-min)) + (set-buffer-modified-p nil) (message (substitute-command-keys "Press \\[sieve-upload] to upload script to server.")))) @@ -257,7 +257,7 @@ sieve-help ;; would need minor-mode for log-edit-mode (describe-function 'sieve-mode) (message "%s" (substitute-command-keys - "`\\[sieve-edit-script]':edit `\\[sieve-activate]':activate `\\[sieve-deactivate]':deactivate `\\[sieve-remove]':remove")))) + "`\\[sieve-edit-script]':edit `\\[sieve-activate]':activate `\\[sieve-deactivate]':deactivate `\\[sieve-remove]':remove `\\[sieve-manage-quit]':quit")))) ;; Create buffer: @@ -350,11 +350,13 @@ sieve-upload (with-current-buffer (get-buffer sieve-buffer) (setq err (sieve-manage-putscript (or name sieve-buffer-script-name (buffer-name)) - script sieve-manage-buffer)) - (if (sieve-manage-ok-p err) - (message (substitute-command-keys - "Sieve upload done. Use \\[sieve-manage] to manage scripts.")) - (message "Sieve upload failed: %s" (nth 2 err))))))) + script sieve-manage-buffer))) + (if (sieve-manage-ok-p err) + (progn + (message (substitute-command-keys + "Sieve upload done. Use \\[sieve-manage] to manage scripts.")) + (set-buffer-modified-p nil)) + (message "Sieve upload failed: %s" (nth 2 err)))))) ;;;###autoload (defun sieve-upload-and-bury (&optional name) -- 2.11.1 --=-=-= Content-Type: text/plain In GNU Emacs 26.0.50.26 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.7) of 2017-02-14 built on clem Repository revision: 71b90192dab8de9825904faaabbaf9548d3db2ab Windowing system distributor 'The X.Org Foundation', version 11.0.11901000 --=-=-=--