query about past scheduled events display in agenda

query about past scheduled events display in agenda

[Eric S Fraga]

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

Something has been bothering me (in an æsthetic way) for some
time.  When an event scheduled for the day before is displayed in the
default agenda view, it displays the days overdue as "2" which seems
wrong to me.  I wonder if somebody can give me the justification for
this?

The code in question, with my own change to fix this to display "1" day
overdue in such cases, is:

--8<---------------cut here---------------start------------->8---
@@ -6214,7 +6214,7 @@ scheduled items with an hour specification like [h]h:mm."
 		     (pcase-let ((`(,first ,past) org-agenda-scheduled-leaders))
 		       ;; Show a reminder of a past scheduled today.
 		       (if (and todayp pastschedp)
-			   (format past (1+ diff))
+			   (format past diff)
 			 first))
 		     head level category tags time nil habitp))
 		   (face (cond ((and (not habitp) pastschedp)
--8<---------------cut here---------------end--------------->8---

thanks,
eric

-- 
: Eric S Fraga (0xFFFCF67D), Emacs 26.0.50.1, Org release_9.0.5-370-g9f3a02.dirty

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

Re: query about past scheduled events display in agenda

[Nicolas Goaziou]

Hello,

Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> Something has been bothering me (in an æsthetic way) for some
> time.  When an event scheduled for the day before is displayed in the
> default agenda view, it displays the days overdue as "2" which seems
> wrong to me.  I wonder if somebody can give me the justification for
> this?
>
> The code in question, with my own change to fix this to display "1" day
> overdue in such cases, is:
>
> @@ -6214,7 +6214,7 @@ scheduled items with an hour specification like [h]h:mm."
>  		     (pcase-let ((`(,first ,past) org-agenda-scheduled-leaders))
>  		       ;; Show a reminder of a past scheduled today.
>  		       (if (and todayp pastschedp)
> -			   (format past (1+ diff))
> +			   (format past diff)
>  			 first))
>  		     head level category tags time nil habitp))
>  		   (face (cond ((and (not habitp) pastschedp)

I cannot reproduce it on maint nor on master. Wasn't that fixed some
time ago?

Regards,

-- 
Nicolas Goaziou

Re: query about past scheduled events display in agenda

[Detlef Steuer]

Am Thu, 16 Mar 2017 13:05:42 +0100
schrieb Nicolas Goaziou <mail@nicolasgoaziou.fr>:

> Hello,
> 
> Eric S Fraga <e.fraga@ucl.ac.uk> writes:
> 
> > Something has been bothering me (in an æsthetic way) for some
> > time.  When an event scheduled for the day before is displayed in
> > the default agenda view, it displays the days overdue as "2" which
> > seems wrong to me.  I wonder if somebody can give me the
> > justification for this?
> >
> > The code in question, with my own change to fix this to display "1"
> > day overdue in such cases, is:
> >
> > @@ -6214,7 +6214,7 @@ scheduled items with an hour specification
> > like [h]h:mm." (pcase-let ((`(,first ,past)
> > org-agenda-scheduled-leaders)) ;; Show a reminder of a past
> > scheduled today. (if (and todayp pastschedp)
> > -			   (format past (1+ diff))
> > +			   (format past diff)
> >  			 first))
> >  		     head level category tags time nil habitp))
> >  		   (face (cond ((and (not habitp) pastschedp)  
> 
> I cannot reproduce it on maint nor on master. Wasn't that fixed some
> time ago?

I have a +2 for "something" scheduled for yesterday.
Org git from the morning.

Org mode version 9.0.5 (release_9.0.5-370-g9f3a02

--snippet from *Org Agenda*
WMA:        Sched. 2x:  TODO something
--

--snippet from my org-file
**** TODO something
     SCHEDULED: <2017-03-15 Mi>
--

Just as a data point. 

And a +1 to change this to 1x :-)

Detlef


> 
> Regards,
> 



-- 

"Wisely and slow. Those stumble that run fast."
Shakespeare -- Romeo and Juliet

Dr. Detlef Steuer
Helmut-Schmidt-Universität
Fakultät WiSo
Holstenhofweg 85
22043 Hamburg

Tel:  040/6541-2819
mail: steuer@hsu-hh.de

Re: query about past scheduled events display in agenda

[Eric S Fraga]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

On Thursday, 16 Mar 2017 at 13:45, Detlef Steuer wrote:

[...]

> I have a +2 for "something" scheduled for yesterday.
> Org git from the morning.

Thanks for confirming.  Mine was with yesterday's version of org.

Nicolas, I think you may have been thinking of a different issue
entirely.

-- 
: Eric S Fraga (0xFFFCF67D), Emacs 26.0.50.1, Org release_9.0.5-370-g9f3a02.dirty

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

Re: query about past scheduled events display in agenda

[Nicolas Goaziou]

Hello,

Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> On Thursday, 16 Mar 2017 at 13:45, Detlef Steuer wrote:
>
> [...]
>
>> I have a +2 for "something" scheduled for yesterday.
>> Org git from the morning.
>
> Thanks for confirming.  Mine was with yesterday's version of org.
>
> Nicolas, I think you may have been thinking of a different issue
> entirely.

Indeed. 

However, isn't the current behaviour the right one? I meant, in the
given example, it was scheduled once "yesterday", so it is really the
second time it is scheduled today, hence the "2x". 

Another way to look at it is by some sloppy analogy to algebra: you
write "2 \times{} x" but scarcely "1 \times{} x".

Regards,

-- 
Nicolas Goaziou

Re: query about past scheduled events display in agenda

[Eric Abrahamsen]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Eric S Fraga <e.fraga@ucl.ac.uk> writes:
>
>> On Thursday, 16 Mar 2017 at 13:45, Detlef Steuer wrote:
>>
>> [...]
>>
>>> I have a +2 for "something" scheduled for yesterday.
>>> Org git from the morning.
>>
>> Thanks for confirming.  Mine was with yesterday's version of org.
>>
>> Nicolas, I think you may have been thinking of a different issue
>> entirely.
>
> Indeed. 
>
> However, isn't the current behaviour the right one? I meant, in the
> given example, it was scheduled once "yesterday", so it is really the
> second time it is scheduled today, hence the "2x". 
>
> Another way to look at it is by some sloppy analogy to algebra: you
> write "2 \times{} x" but scarcely "1 \times{} x".

I think people are thinking of it as "number of days I've failed to
complete my scheduled item".

Re: query about past scheduled events display in agenda

[Detlef Steuer]

Am Thu, 16 Mar 2017 21:08:43 +0100
schrieb Nicolas Goaziou <mail@nicolasgoaziou.fr>:

> Hello,
> 
> Eric S Fraga <e.fraga@ucl.ac.uk> writes:
> 
> > On Thursday, 16 Mar 2017 at 13:45, Detlef Steuer wrote:
> >
> > [...]
> >  
> >> I have a +2 for "something" scheduled for yesterday.
> >> Org git from the morning.  
> >
> > Thanks for confirming.  Mine was with yesterday's version of org.
> >
> > Nicolas, I think you may have been thinking of a different issue
> > entirely.  
> 
> Indeed. 
> 
> However, isn't the current behaviour the right one? I meant, in the
> given example, it was scheduled once "yesterday", so it is really the
> second time it is scheduled today, hence the "2x". 
> 
> Another way to look at it is by some sloppy analogy to algebra: you
> write "2 \times{} x" but scarcely "1 \times{} x".
>

Sure, if you read it as 2x scheduled it is correct.

I read it as 1x re-scheduled or 1x overdue.
But: Just cosmetics. For me the second way looks more natural.

Regards
Detlef


> Regards,
> 

Re: query about past scheduled events display in agenda

[Samuel Wales]

i think in terms of days since the date that would be its most recent
appearance.

thus, if yesterday would be its most recent appearance, then it would be 1.

this is consistent with code i have that marks timestamps with the
number of days since the timestamp, with 0 being today.

but yeah, borderline bikeshedding or cosmetic.  :]

-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

The NIH, FDA, and CDC are not there for you.  Not without activism.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.

Re: query about past scheduled events display in agenda

[Eric S Fraga]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

On Thursday, 16 Mar 2017 at 20:08, Nicolas Goaziou wrote:
> However, isn't the current behaviour the right one? I meant, in the
> given example, it was scheduled once "yesterday", so it is really the
> second time it is scheduled today, hence the "2x". 
>
> Another way to look at it is by some sloppy analogy to algebra: you
> write "2 \times{} x" but scarcely "1 \times{} x".

Ah, okay, I see the rationale.  For me, it looks strange because I have
changed the leader to say "Overdue %4d d:" and so the number presented
is 1 more than I would expect.

No worries!  At least I understand why it is the way it is.

Thanks,
eric

-- 
: Eric S Fraga (0xFFFCF67D), Emacs 26.0.50, Org release_9.0.5-378-gf6f02e.dirty

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

Re: query about past scheduled events display in agenda

[Nicolas Goaziou]

Hello,

Detlef Steuer <detlef.steuer@gmx.de> writes:

> Sure, if you read it as 2x scheduled it is correct.
>
> I read it as 1x re-scheduled or 1x overdue.
> But: Just cosmetics. For me the second way looks more natural.

Fair enough. This is now fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: query about past scheduled events display in agenda

[Eric S Fraga]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

On Friday, 17 Mar 2017 at 07:42, Nicolas Goaziou wrote:
> Hello,
>
> Detlef Steuer <detlef.steuer@gmx.de> writes:
>
>> Sure, if you read it as 2x scheduled it is correct.
>>
>> I read it as 1x re-scheduled or 1x overdue.
>> But: Just cosmetics. For me the second way looks more natural.
>
> Fair enough. This is now fixed. Thank you.

Thank you!

-- 
: Eric S Fraga (0xFFFCF67D), Emacs 26.0.50, Org release_9.0.5-378-gf6f02e.dirty

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 194 bytes --]