From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: master 941a2e7: todo-mode: don't assume an ordering of tests Date: Tue, 30 May 2017 10:58:40 +0200 Message-ID: <87vaoiafgf.fsf@rosalinde> References: <20170530005055.14646.47570@vcs0.savannah.gnu.org> <20170530005057.4720C20ACA@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1496134770 18145 195.159.176.226 (30 May 2017 08:59:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 May 2017 08:59:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Glenn Morris To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 30 10:59:22 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFczo-0004Jl-Hu for ged-emacs-devel@m.gmane.org; Tue, 30 May 2017 10:59:20 +0200 Original-Received: from localhost ([::1]:52347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFczr-0003ic-VS for ged-emacs-devel@m.gmane.org; Tue, 30 May 2017 04:59:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFczK-0003iW-Fv for emacs-devel@gnu.org; Tue, 30 May 2017 04:58:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFczF-0003D0-Ih for emacs-devel@gnu.org; Tue, 30 May 2017 04:58:50 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:59117) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFczF-0003AB-8g; Tue, 30 May 2017 04:58:45 -0400 Original-Received: from rosalinde ([83.135.25.138]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MXZNq-1dSIAI3xAs-00WSZB; Tue, 30 May 2017 10:58:41 +0200 In-Reply-To: <20170530005057.4720C20ACA@vcs0.savannah.gnu.org> (Glenn Morris's message of "Mon, 29 May 2017 20:50:56 -0400 (EDT)") X-Provags-ID: V03:K0:yrraYRbhp8XdvoYtXhcHcGqgkD2bg7hNYA+I5fGJNlo3Mk69te8 qmw9YqYeWHgrENjvqGB1sUGaeZp1ejFLt5QlHITV+W1Yx6KkNGQ7aAsJhobDYta3XcSb9WL 1fiickXMamVymk1mXRq+BGRqGpM/BIdPHZegdU81kP9yXdmwHMJXr1lMS6Wz3DPcMRXs7w3 L7BodSfJqHu15ywcww3Pg== X-UI-Out-Filterresults: notjunk:1;V01:K0:jdx3KUgVnzY=:LQ+Cw59foAtlHL0FlhyMPK sWV6SJRLh4UtCBMMyncknMKYfFqoQhydcXDaSSgCmZgGoAEn1R59wKy748B1LT394lcddPPNH t+eXf+xilr50RjxuVauigzpHgwwToGaqfo3liMgj0JUUw1+oF3aUPrvZtM/4FdBaAkKUEg3Dr PF0YN2J2M8+sVicHMMIqHFb9kqai/RwMzXuBB/rpgNbtvQk9mQW9jtZkPPEH9bYLjKJJ034fk smaNawyQ2DS/rbptTYFq1QOvVbOZQVycZw/FmHNQtjpQmdBpc6zlgYsz8OW/Zcc815+/Plahu 0xjkSFUTs4QrzH1YrbImZVJVwUjfoa8emp7eFsVxCX4iBm13thKcCo4pMATYSoYLKsA6hMiUW SFL7hb1Rvn0TccGcpTchCXo+buzZWT8hCNmeYVdrc3exeNb0dFXeGfB/hfbII9RipuF4mGC+w vwswLY/4nUFEnUVbN2XTNPuWZ8jt4xoD4fIWdw/10LieVy0pfuYL6Uhg70TQ5I4MAK94qMPZb lm4aEPULfT4jo2B8z4ATKKziYjF3X+3av3YxCTw1s27zuKSMUu19vQoQUO7DLWUlGM0oxZG3r 3u0V7NH0CJzo3V7ER1lOZUhDBRwfSa20WeK+bKLyTTFf34ZLOFxDoyhKu3T7hAtciBY/kEHo2 VPyiUAXwTwLbadZTZwTtQxtTrZGbOcpZqeG7X268kNUkPiyErSJiSoHDPtHdF5fzu8mtgOelJ 29npDmJtgiRphTVSaZlX/jrCzJkVi0+EKUwWWnQMrahUPkQ92RfNFYD2KZEht+4jj+I7zWAR X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215349 Archived-At: On Mon, 29 May 2017 20:50:56 -0400 (EDT) rgm@gnu.org (Glenn Morris) wrote: > branch: master > commit 941a2e7347e3a0d393e67872e6151be8cc66d9a2 > Author: Glenn Morris > Commit: Glenn Morris > > todo-mode: don't assume an ordering of tests > > * test/lisp/calendar/todo-mode-tests.el (todo-test-todo-quit02) > (todo-test-item-highlighting): Avoid prompting for input file. [...] > @@ -93,6 +95,7 @@ current again." > If the buffer made current by invoking todo-quit in a todo-mode > buffer is buried by quit-window, the todo-mode buffer should not > become current." > + (todo-test-get-archive 2) > (todo-show) > (should (todo-test-is-current-buffer todo-test-file-1)) > (let ((dir (dired default-directory))) > @@ -105,6 +108,7 @@ become current." > (ert-deftest todo-test-item-highlighting () ; bug#27133 > "Test whether `todo-toggle-item-highlighting' highlights whole item. > In particular, all lines of a multiline item should be highlighted." > + (todo-test-get-archive 2) > (todo-show) > (todo-jump-to-category nil "testcat1") ; For test rerun. > (todo-toggle-item-highlighting) When I start emacs with -Q, load the test file, and then either run all tests with `M-x ert RET t RET', or each individually with `M-x ert RET "todo-test-todo-quit02" RET' etc. in any order, also with reruns, all tests pass and I get no prompt for a file. Same when invoking `emacs -batch -l ert -l /path/to/test/lisp/calendar/todo-mode-tests.el -f ert-run-tests-batch-and-exit' from the shell. The tests todo-test-todo-quit02 and todo-test-item-highlighting shouldn't have any need to display an archive buffer. How did you run the tests such that you got prompted for a file and what was the prompt? Steve Berman