From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24046: [PATCH] vc-git: prevent execution of git stash in error cases Date: Sat, 03 Jun 2017 23:00:07 -0400 Message-ID: <87vaoczcco.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1496545154 3445 195.159.176.226 (4 Jun 2017 02:59:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Jun 2017 02:59:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 24046@debbugs.gnu.org To: Alexander Kuleshov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 04 04:59:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHLky-0000aL-2s for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Jun 2017 04:59:08 +0200 Original-Received: from localhost ([::1]:55598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHLl3-0002n4-GH for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Jun 2017 22:59:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHLky-0002my-4M for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2017 22:59:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHLkt-00041T-2O for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2017 22:59:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51775) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHLks-00041N-Td for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2017 22:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHLks-0002RM-J8 for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2017 22:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2017 02:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24046-submit@debbugs.gnu.org id=B24046.14965451169345 (code B ref 24046); Sun, 04 Jun 2017 02:59:02 +0000 Original-Received: (at 24046) by debbugs.gnu.org; 4 Jun 2017 02:58:36 +0000 Original-Received: from localhost ([127.0.0.1]:54452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHLkS-0002Qf-JE for submit@debbugs.gnu.org; Sat, 03 Jun 2017 22:58:36 -0400 Original-Received: from mail-it0-f43.google.com ([209.85.214.43]:38678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHLkR-0002QS-8n for 24046@debbugs.gnu.org; Sat, 03 Jun 2017 22:58:35 -0400 Original-Received: by mail-it0-f43.google.com with SMTP id r63so49991950itc.1 for <24046@debbugs.gnu.org>; Sat, 03 Jun 2017 19:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=C61kQYoe5mqkAM+5/HFumu9s0MXaVqQhgCDcW1ZF9XA=; b=H9RtkfHAT+5kIvUQ+V2qWA2IDaRBHF1seTjW+ow37xVB9bv0u6o8ZmqS0FGAJBfZ1U q8esPz0+hdMsUKIpFYND+qLtcZr5MhqJCP1RQomYrRsm7AWHJjxaNsRuxuwPP+d+5lKb DVOYGr+B7Dh3xcwLkgYnPfPtnzc1YOLLrqnfQnQ4WS7vdf8v5OC/aky+jkHl2ZtdubyW 1k/CnvGhS03Js9sAaxAama/kVL8UvJBM07+b4DySik4AziQHRHMx5XjtgAHv5LFFvQoh D8BcqlprE3SPNkDJraYoafyia8pt+ng1KHYhuF7/U7xnip3Hq06TJvBllCyrX22RH29V pXiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=C61kQYoe5mqkAM+5/HFumu9s0MXaVqQhgCDcW1ZF9XA=; b=W9bdt9LRpWEG/NMCtzVz72L71XQSb+JVotcDHOEf1eRATR8ydhmyHd/fOFgXPz+INy VV5S/6GINFFtJmAUa3U7vP3zOQsl9ZIN3jANykFEqbM1ZcoRBbn5clWHBW+GlguSBMKH 1j/VHi3i+2L57qdr1eItLlxd52FHBEX0N4cnnuAP0t5sgqg9GHsCbF+cQr9lEDknxv+F 1a8TCr+fnEoeIoLa1BxE5y7aPlnA26LPXg71xjA8fbmyUOOm1Qh/G5zoLdI4GTVJCPLp FDFzhWUVidLKBzabZddO5MBk8jqgru5eHh3QmdiIkh/4CTMtEWlFHzDUQ/OH9nrVqVVx HU4Q== X-Gm-Message-State: AODbwcCldSSxpz3mn/704dCqhP5TLXH3NbzuH4shx1ICnRxnTKN7xqDx 3OvtivPBvaEzufkx X-Received: by 10.36.77.211 with SMTP id l202mr6794565itb.74.1496545109628; Sat, 03 Jun 2017 19:58:29 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id u140sm5103508ita.0.2017.06.03.19.58.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Jun 2017 19:58:29 -0700 (PDT) In-Reply-To: (Alexander Kuleshov's message of "Thu, 21 Jul 2016 18:46:18 +0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133242 Archived-At: Alexander Kuleshov writes: > Here is simple patch which adds two additional checks to the vc-git-stash-show > function to check that correct stash name is passed and actually repo > has stashes. I'm not sure this is a good idea, we just end up duplicating checks that 'git stash' is going to perform anyway...