all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Felipe Ochoa <felipe.nospam.ochoa@gmail.com>
To: emacs-devel@gnu.org
Subject: Disabling imenu default of thing-at-point
Date: Mon, 24 Jul 2017 19:10:25 +0200	[thread overview]
Message-ID: <87vamhg3r2.fsf@gmail.com> (raw)

imenu currently uses (thing-at-point 'symbol) to offer a default in
completing read. It's very helpful when symbol at point is one of the
options, but not really useful when not. It's particularly inconvenient
when using ido for completing read (e.g., with ido-ubiquitous), since it
makes M-x imenu RET not do anything instead of jumping to the first
option.

The fix is one-line (below), but the unhelpful (for me) default seems to
be coded explicitly. Would this patch break anyone else's use of imenu?

--- a/lisp/imenu.el
+++ b/lisp/imenu.el
@@ -876,7 +876,7 @@ Return one of the entries in index-alist or nil."
 		    (cdr item)))
 	    index-alist))))
     (when (stringp name)
-      (setq name (or (imenu-find-default name prepared-index-alist) name)))
+      (setq name (imenu-find-default name prepared-index-alist)))
     (cond (prompt)
 	  ((and name (imenu--in-alist name prepared-index-alist))
 	   (setq prompt (format "Index item (default %s): " name)))



             reply	other threads:[~2017-07-24 17:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 17:10 Felipe Ochoa [this message]
2017-07-24 17:39 ` Disabling imenu default of thing-at-point Drew Adams
2017-07-24 17:43   ` Noam Postavsky
     [not found]     ` <CAHp7JggMsvE-A4GL2L1MdEceN4nnR9n3RGYjzpNgF2Zk1TRcjA@mail.gmail.com>
2017-07-25  9:01       ` Felipe Ochoa
     [not found]   ` <CAHp7JgjpdXfqwhO+PcVqAFGMT8Sy271sRgDGQt6_eWTYnSiFaQ@mail.gmail.com>
2017-07-25  9:05     ` Felipe Ochoa
2017-07-25  9:13       ` Felipe Ochoa
2017-07-25  9:21       ` Felipe Ochoa
2017-08-03  8:35         ` Felipe Ochoa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vamhg3r2.fsf@gmail.com \
    --to=felipe.nospam.ochoa@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.