From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24901: Caught mistake in elec-pair.el patch Date: Thu, 17 Aug 2017 21:51:30 -0400 Message-ID: <87vally76l.fsf@users.sourceforge.net> References: <871soaz810.fsf@users.sourceforge.net> <8360dmff2n.fsf@gnu.org> <87valm1a18.fsf@lolita> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1503021027 25943 195.159.176.226 (18 Aug 2017 01:50:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Aug 2017 01:50:27 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 24901@debbugs.gnu.org, rrt@sc3d.org To: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 18 03:50:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diWQR-0005uz-A3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Aug 2017 03:50:15 +0200 Original-Received: from localhost ([::1]:39279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1diWQU-00028m-H0 for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Aug 2017 21:50:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1diWQK-00024a-UX for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 21:50:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1diWQF-0002dL-00 for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 21:50:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34665) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1diWQE-0002cx-S3 for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 21:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1diWQE-00029H-AB for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 21:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Aug 2017 01:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24901 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24901-submit@debbugs.gnu.org id=B24901.15030209998246 (code B ref 24901); Fri, 18 Aug 2017 01:50:02 +0000 Original-Received: (at 24901) by debbugs.gnu.org; 18 Aug 2017 01:49:59 +0000 Original-Received: from localhost ([127.0.0.1]:43346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diWQB-00028w-L7 for submit@debbugs.gnu.org; Thu, 17 Aug 2017 21:49:59 -0400 Original-Received: from mail-it0-f50.google.com ([209.85.214.50]:34992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diWQA-00028i-2h for 24901@debbugs.gnu.org; Thu, 17 Aug 2017 21:49:58 -0400 Original-Received: by mail-it0-f50.google.com with SMTP id 76so1692765ith.0 for <24901@debbugs.gnu.org>; Thu, 17 Aug 2017 18:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=l5g1HzpvGrgSpf4TftyMqmBovGGaFK5exQ3/aWNfmuY=; b=IKbrGmvTrSVgkkuuWsCNYFltfr7eVZMF+qHA3PxvmMqZCRlOtX+eBQD4+Sh9cwzr2i SOgGaPW7mwDznWvqdD56tqI4KWicguzTj1jP2iJSFauIBngL1htNdzDWGKoIoqQa5+aI 7k1874ujq3dvd9wmPcDY5Bs6GtvbtV3Cd/c6/iWiKtXYUacZrCfAGwHLm1vmgAd+Siz0 6jp+uK1hDKb9szcBc006DN0NHS1ZXpaWV9lRoNQ1oRh4QNB6gY9Ou2jJqvUv4YklT5wD G/WD4YbA9CFjM9+RBFMWOB6Qo7zMsqGjEQQFkxKQmcEQPbAA/7zLwwnE2em2cCEFuZUD oP/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=l5g1HzpvGrgSpf4TftyMqmBovGGaFK5exQ3/aWNfmuY=; b=npDorJ2AbTB4iuaQkg3Enz5N+MZjfUeM+okyQOfPRx36S2El7Vl/AY6sFOlE7f3Asu /A+ZgnZSJj1MPaS3jZ2fMYl4vm9yv0IdF7RhHfgKFqg0pCX+aF+D0S0aOMsG6Sxv/fN8 PHAOXfjN3mL4vXGpl0XfgLr1GDLyk+TcwgNki0SgLfeAbE0unjNINplE6kaR1BRr/uPv tJWEAgw/JKF3nVHFh28WhKx+MMikAJnAAnNgZSEkT9bdCyQhpggOCTXBGUswud3F0L3x 8jVbHG9tuH8P3MTmHdFBa7kmlT2Gd3vA4ZW4bGCh4mZMSPkW8pQahPwb4E9svrWkJtYi KIQQ== X-Gm-Message-State: AHYfb5gnR14jp76bVjlr+LAsnwtgspiAQAyG1ftIfHuhCEbRy1QlQiYi kTaus4dQ6hN1VQ== X-Received: by 10.36.241.6 with SMTP id c6mr395090iti.116.1503020992369; Thu, 17 Aug 2017 18:49:52 -0700 (PDT) Original-Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id w207sm198676itc.34.2017.08.17.18.49.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Aug 2017 18:49:51 -0700 (PDT) In-Reply-To: <87valm1a18.fsf@lolita> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 17 Aug 2017 16:36:19 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135888 Archived-At: joaotavora@gmail.com (Jo=C3=A3o T=C3=A1vora) writes: >> As far as I know, the only way to be sure of testing all dependencies >> is deleting all elc files, i.e., a full bootstrap minus the C >> compilation (using ccache can help automate the "minus the C >> compilation" part). > > So is 'find . -iname "*.elc" | xargs rm -f' enough? Actually, now that I think of it, 'rm lisp/loaddefs.el' might be needed too. > What's ccache? https://ccache.samba.org/ ccache is a compiler cache. It speeds up recompilation by caching previous compilations and detecting when the same compilation is being done again. Supported languages are C, C++, Objective-C and Objective-C++. So you can ./configure CC=3D'ccache gcc' and then if you do 'make bootstrap' the C compilation goes by very quickly after the first time. The lisp compilation still takes a long time, but caching the C part at least makes it less painful to use an -O2 optimized build which compiles lisp a bit faster. >> The elisp-mode.el problem is what causes the align.elc failure: the >> byte compiler uses elisp-mode. > > Does this mean you sign off on both patches? Yes, I think they're good (I have just a couple of format trivia nitpicks, below). I'm under the impression that I'm more tolerant of explicit `require' than the average Emacser though. > * lisp/elec-pair.el (electric-pair-pairs): Use backquote and comma. > (electric-pair-text-pairs): Use backquote and comma. This could be * lisp/elec-pair.el (electric-pair-pairs, electric-pair-text-pairs): Use backquote and comma. > (defcustom electric-pair-text-pairs > - '((?\" . ?\" ) > - ((nth 0 electric-quote-chars) . (nth 1 electric-quote-chars)) > - ((nth 2 electric-quote-chars) . (nth 3 electric-quote-chars))) > + `((?\" . ?\" ) Can we get rid of that space before the closing paren while we're here?