all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#27141: 26.0.50; mml-generate-mime-1 broken
@ 2017-05-30  6:09 Katsumi Yamaoka
  2017-05-31 23:21 ` Katsumi Yamaoka
  0 siblings, 1 reply; 14+ messages in thread
From: Katsumi Yamaoka @ 2017-05-30  6:09 UTC (permalink / raw)
  To: 27141; +Cc: larsi

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

Hi,

I noticed this when I forwarded a mail using Gnus.  The problem
is that non-ASCII letters contained in the header of the original
mail will not be encoded properly.  The rough outline of what
`mml-generate-mime-1' does then are:

・Insert the original mail (decoded) into a unibyte buffer
  (that with-temp-buffer of mml.el-[line:619] generates).
・Detect the charset of the contents.
・Encode the contents by that detected charset.
・Insert the encoded contsnts into the other unibyte buffer
  (that with-temp-buffer of mml.el-[line:612] generates).
・Run `mml-to-mime' that encodes the header of the original mail
  using `mail-encode-encoded-word-buffer' (an alias to
  `rfc2047-encode-message-header').

rfc2047's encoder expects human readable text, however, there
are encoded ones as described above.  So, as for at least mail
forwarding, `mml-generate-mime-1' is seriously broken.

The current code looks like WIP to me.  How about reverting it
to the emacs-25 version?  Slightly modernized[1] one is attached.

[1] Don't use old compat functions and string-as-(multi|uni)byte.

In GNU Emacs 26.0.50 (build 1, i686-pc-cygwin, GTK+ Version 3.18.9)
 of 2017-05-30 built on localhost
Windowing system distributor 'The Cygwin/X Project', version 11.0.11900000

[-- Attachment #2: Type: application/emacs-lisp, Size: 9199 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-09-23 18:15 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-30  6:09 bug#27141: 26.0.50; mml-generate-mime-1 broken Katsumi Yamaoka
2017-05-31 23:21 ` Katsumi Yamaoka
2017-06-01  5:20   ` Lars Ingebrigtsen
2017-06-01  6:15     ` Katsumi Yamaoka
2017-06-01  7:17       ` Lars Ingebrigtsen
2017-06-01  8:32         ` Katsumi Yamaoka
2017-09-02 14:05           ` Eli Zaretskii
2017-09-03 23:37             ` Katsumi Yamaoka
2017-09-13 17:36               ` Lars Ingebrigtsen
2017-09-13 18:41                 ` Eli Zaretskii
2017-09-13 18:45                   ` Lars Ingebrigtsen
2017-09-13 19:14                     ` Eli Zaretskii
2017-09-13 19:18                       ` Lars Ingebrigtsen
2019-09-23 18:15                         ` Lars Ingebrigtsen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.