From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#28412: 26.0.50; Let save-some-buffers accept write-contents-functions Date: Mon, 18 Sep 2017 13:53:24 -0700 Message-ID: <87vakfenjv.fsf@ericabrahamsen.net> References: <87bmmikyug.fsf@ericabrahamsen.net> <838thbj32x.fsf@gnu.org> <87377jizy6.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505768065 5456 195.159.176.226 (18 Sep 2017 20:54:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 18 Sep 2017 20:54:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 28412@debbugs.gnu.org To: Kaushal Modi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 18 22:54:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du33P-0000UL-K9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Sep 2017 22:54:07 +0200 Original-Received: from localhost ([::1]:38874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du33V-0001eN-EE for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Sep 2017 16:54:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du33N-0001ce-4Z for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 16:54:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1du33K-0006vo-If for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 16:54:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38231) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1du33K-0006vg-FK for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 16:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1du33K-0004ix-2z for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 16:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2017 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28412-submit@debbugs.gnu.org id=B28412.150576800818113 (code B ref 28412); Mon, 18 Sep 2017 20:54:02 +0000 Original-Received: (at 28412) by debbugs.gnu.org; 18 Sep 2017 20:53:28 +0000 Original-Received: from localhost ([127.0.0.1]:46912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du32l-0004i5-OW for submit@debbugs.gnu.org; Mon, 18 Sep 2017 16:53:27 -0400 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:41068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du32k-0004hy-9X for 28412@debbugs.gnu.org; Mon, 18 Sep 2017 16:53:26 -0400 Original-Received: from localhost (71-35-182-76.tukw.qwest.net [71.35.182.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id D4190C039F; Mon, 18 Sep 2017 20:53:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1505768005; bh=+PPfEYF/kOsWEHLYeukOlgMMbdjLqreSQjDTQp56Mc0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QE1fV80O3ZZBqC7CEXbSWSF8qbrBbmtjTFad7yUX+pTgf7FcO+pKiiVM51W0wA0Ud GLEmQvinwTMR7FWHnLKwt5YiRHtc2NolSB5oH1AU1emNwRUhB5cvTO72JkXhdH2fmZ dGvCaOoRma9PMqJqlMpyhtpKH9FMMldqYyJxcsVs= In-Reply-To: (Kaushal Modi's message of "Mon, 18 Sep 2017 19:23:10 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137085 Archived-At: Kaushal Modi writes: > On Mon, Sep 18, 2017 at 3:12 PM Eric Abrahamsen wrote: > > Also, there don't appear to be any built-in functions or regexps for > dealing with "hidden" buffers, I'm assuming: > > (not (string-prefix-p " " (buffer-name buffer))) > > is okay? > > That crossed my mind too. So I had started looking for its existing implementation, and found this in buff-menu.el inside list-buffers--refresh function: > > (string= (substring name 0 1) " ") > > I was wondering if that should be wrapped into a function like buffer-internal-p (based on the many docstrings like below in buff-menu.el: "By default, the Buffer Menu lists all buffers except those whose names start with a space > (which are for internal use)."). Having a function like this would be better than having that logic implemented in different ways in the emacs core. > > I just don't know the best place to put this function definition. Eli? It might be nice to have something like: (defsubst buffer-internal-p (buf) (eq (aref (buffer-name buf) 0) ?\s))