all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: joaotavora@gmail.com (João Távora)
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 29201@debbugs.gnu.org
Subject: bug#29201: 26.0.90; Flymake skips indicator when a backend reports a diagnostic at EOB
Date: Thu, 09 Nov 2017 21:18:41 +0000	[thread overview]
Message-ID: <87vaiji21a.fsf@gmail.com> (raw)
In-Reply-To: <38b19877-7ddf-673f-f9e0-de422e5251e6@yandex.ru> (Dmitry Gutov's message of "Wed, 8 Nov 2017 01:26:55 +0200")

Dmitry Gutov <dgutov@yandex.ru> writes:

> Maybe flymake-diag-region should check for (eob) and maybe backtrack a
> little. Flycheck, in such situations, highlights the last symbol of
> the buffer.

"Backtracking a little" sounds OK but highlighting the last symbol is a
little more contentious and harder to do (though I'm open to that
argument).

Anyway, this is a simple bug because my original idea was to make this
case behave like the case where the last line is referenced but without
a column indication. Inside flymake-diag-region, this should funnel into
fallback-eol but in this particular case it wasn't doind that because I
forgot that (goto-char one-trillion) doesn't error.

Fixed in 535688a4181ae4052db354ce2b877507f11c9e66.

Thanks,
João





  reply	other threads:[~2017-11-09 21:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 23:26 bug#29201: 26.0.90; Flymake skips indicator when a backend reports a diagnostic at EOB Dmitry Gutov
2017-11-09 21:18 ` João Távora [this message]
2017-11-10  0:02   ` Dmitry Gutov
2017-11-10  5:32     ` João Távora
2017-11-10 11:19       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vaiji21a.fsf@gmail.com \
    --to=joaotavora@gmail.com \
    --cc=29201@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.