From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#29220: 26.0.90; eieio-persistent-read fail to restore saved object. Date: Sat, 18 Nov 2017 21:57:45 -0800 Message-ID: <87vai6yfmu.fsf@ericabrahamsen.net> References: <87y3nga0lv.fsf@killashandra.ballybran.fr> <87po8s8k02.fsf@ericabrahamsen.net> <87zi7udorn.fsf@killashandra.ballybran.fr> <8760aim2a5.fsf@ericabrahamsen.net> <87375j2tzd.fsf@users.sourceforge.net> <87inecwl1v.fsf@killashandra.ballybran.fr> <87y3n81eq7.fsf@users.sourceforge.net> <87h8ts1cfp.fsf@users.sourceforge.net> <87zi7kyzcf.fsf@ericabrahamsen.net> <87efov1zzn.fsf@users.sourceforge.net> <87h8trzc6e.fsf@ericabrahamsen.net> <87bmjz0xez.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1511071219 31675 195.159.176.226 (19 Nov 2017 06:00:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Nov 2017 06:00:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 29220@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 19 07:00:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGIeF-0007Sn-Ji for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 07:00:07 +0100 Original-Received: from localhost ([::1]:52045 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGIeL-00086c-AS for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 01:00:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGIeF-000855-6C for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 01:00:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGIeB-0000af-8K for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 01:00:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38043) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGIeB-0000aW-5A for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 01:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eGIeA-0008PP-RP for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 01:00:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87y3nga0lv.fsf@killashandra.ballybran.fr> Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2017 06:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29220 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.151107119432276 (code B ref -1); Sun, 19 Nov 2017 06:00:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Nov 2017 05:59:54 +0000 Original-Received: from localhost ([127.0.0.1]:46724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGIe2-0008OW-9f for submit@debbugs.gnu.org; Sun, 19 Nov 2017 00:59:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGIdz-0008OD-Vn for submit@debbugs.gnu.org; Sun, 19 Nov 2017 00:59:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGIdt-0000Sz-TC for submit@debbugs.gnu.org; Sun, 19 Nov 2017 00:59:46 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:58928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eGIdt-0000St-Qc for submit@debbugs.gnu.org; Sun, 19 Nov 2017 00:59:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGIds-00083D-LM for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 00:59:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGIdp-0000RK-Km for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 00:59:44 -0500 Original-Received: from [195.159.176.226] (port=49353 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGIdp-0000QO-EO for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 00:59:41 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eGIde-0005Sp-Aa for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 06:59:30 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 43 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:EIXqJmBEseATbRbzJiMZ3hzGsTk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140080 Archived-At: Noam Postavsky writes: > Eric Abrahamsen writes: > >> (defclass person () >> ((name :type string :initarg :name))) >> >> (defclass classy (eieio-persistent) >> ((teacher >> :type person >> :initarg :teacher) >> (students >> :initarg :students :initform (make-hash-table)))) >> >> (setq jane (make-instance 'person :name "Jane")) >> (setq bob (make-instance 'person :name "Bob")) >> >> (setq class (make-instance 'classy >> :teacher jane)) >> (puthash "Bob" bob (slot-value class 'students)) > >> Jane is `read'-able, Bob isn't. `object-write' will recurse and use >> `object-write' on any member objects, but the hashtable gets sent to >> `prin1', which I assume uses `prin1' on all its values instead: > > Yes, but this is the case in emacs-25 as well. The significant > difference seems to be in the class object: > > 25.3: > (eieio--object-class-tag bob) => eieio-class-tag--person > 26: > (eieio--object-class-tag bob) => #2=#s(eieio--class person nil nil > [#s(cl-slot-descriptor name unbound string nil)] #s(hash-table size 65 > test eq rehash-size 1.5 rehash-threshold 0.8125 data (name 0)) nil > ((:name . name)) #1=[] #1# #s(#2# unbound) (:custom-groups nil)) > > In Emacs 25 we have a simple symbol which will round-trip as an `eq' > object, in Emacs 26 we have a structure which will not (and furthermore > has some circularity, requiring print-circle to print readably). Yup, I sure noticed that change when it happened -- it made the already verbose object representations well-nigh unreadable. Looks like it was 8e6f204f44b. I don't know what the right solution is.