From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#28605: 26.0.60; Part of leftmost character hidden Date: Tue, 19 Dec 2017 09:10:33 +0100 Message-ID: <87vah3jfye.fsf@gmail.com> References: <87wp4c750c.fsf@gmail.com> <59D4A45F.5010606@gmx.at> <87tvzfjfcp.fsf@gmail.com> <59D5E8F6.8080002@gmx.at> <87efqikk0x.fsf@gmail.com> <87a815lq3w.fsf@gmail.com> <59D73C6F.3020907@gmx.at> <87o9pk65ae.fsf@gmail.com> <59D74E49.2000605@gmx.at> <87a8145wcr.fsf@gmail.com> <59DCCA92.8090501@gmx.at> <87tvz7m319.fsf@gmail.com> <5A341195.20008@gmx.at> <87zi6gjaed.fsf@gmail.com> <5A38B989.3040402@gmx.at> <471E581E-45F8-4E67-82A1-B974498D1166@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1513670966 30302 195.159.176.226 (19 Dec 2017 08:09:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Dec 2017 08:09:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: ola.nilsson@gmail.com, larsi@gnus.org, 28605@debbugs.gnu.org, kaushal.modi@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 19 09:09:21 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRCxj-00078M-Vw for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Dec 2017 09:09:20 +0100 Original-Received: from localhost ([::1]:57984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRCzc-0003cb-2D for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Dec 2017 03:11:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRCzU-0003br-5N for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 03:11:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRCzO-0001EY-8q for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 03:11:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60701) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRCzO-0001Dn-0H for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 03:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eRCzN-0007tA-LP for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 03:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2017 08:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28605-submit@debbugs.gnu.org id=B28605.151367104430299 (code B ref 28605); Tue, 19 Dec 2017 08:11:01 +0000 Original-Received: (at 28605) by debbugs.gnu.org; 19 Dec 2017 08:10:44 +0000 Original-Received: from localhost ([127.0.0.1]:41149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRCz5-0007sc-LQ for submit@debbugs.gnu.org; Tue, 19 Dec 2017 03:10:43 -0500 Original-Received: from mail-wr0-f181.google.com ([209.85.128.181]:43354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRCz3-0007sP-OK for 28605@debbugs.gnu.org; Tue, 19 Dec 2017 03:10:42 -0500 Original-Received: by mail-wr0-f181.google.com with SMTP id w68so5281580wrc.10 for <28605@debbugs.gnu.org>; Tue, 19 Dec 2017 00:10:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:user-agent:mime-version; bh=eGSLKpKJED8YaHA+zNKDLgqNgFbPnMSKcs3u9clS/IQ=; b=gOW1+Y6I7wxk0ubg5LU4yToKRYEIZh/cYqcAViTX2JTBfM+nM3YzD8MHakIeJ6S6DZ H6xttSOMN8JgQw2g64h9iM1ge+/ocGMkQVU+FnqQrrcD1cov7YuCFjNs1i1JRU02NWJR P3bykbiGstN6dvsnS7SC8IYabt+A2T591Hb2Ff6R2+2KdK2O4CatKTKhd6crwK1XspqF v7cvDS0rk6jjrPZbrlLPEf4h6iSYgoIb6WV9oMEImUvU//Lh8jaNEn7dljvTXIsoc6jt lnix4hyTGzOPQcuguI8rBlJeeXFsVbZLO7FLn/OLeYJ53duSo8T8YFEW3KiYhdWqDCks 4pIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=eGSLKpKJED8YaHA+zNKDLgqNgFbPnMSKcs3u9clS/IQ=; b=lZrZ972aC7rF2KFROCPvwKRSqhTRKq8KUveEW3Xyk3BNOq5+HiIUw44AYdqpT6E+Ct IVxAKWL5TzrHxPAqmCnuqhOQO5PB+UsHKzCnc8QhiSLgL4pYDrdQ67OmCf1t99MEyNPL Tjf5tYei+LQvVbOXe8YMzSleZpP5Gt1C0vBTtUrUMhAx0A+MehMfafP6S5t8JWXplDeT Jo5+DOYSR7QbNuCaj3lplLUw2yK+7gQwDrTWzIRtkdUu9dmhdbTDkXebwwq01zsJ0zRN qRkP3O5msv+QV9WkSoVQgDoYjeqRFwsIMxGwsZXp2vfVCRGR/XgpE3CGCrH0EKo9lOZu n6NQ== X-Gm-Message-State: AKGB3mI5PWdikxSpkGrKbbwsw9r+Ax/FnF7oAFggZjJJIH523tHnNnzk c0UBDRm9ZBd0oU+CGqhYRrE= X-Google-Smtp-Source: ACJfBouqT780Ol0uG50fzNdVn7PcF9bqbDcgWpL1DKEtFHy53JuQxtM9d0NA1RptCeY6X6gxaBXS4w== X-Received: by 10.223.150.178 with SMTP id u47mr1359282wrb.115.1513671035973; Tue, 19 Dec 2017 00:10:35 -0800 (PST) Original-Received: from rpluim-ubuntu ([2a01:e34:ecfc:a860:9d1d:243:d7da:c232]) by smtp.gmail.com with ESMTPSA id g7sm12459884edf.50.2017.12.19.00.10.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Dec 2017 00:10:34 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <471E581E-45F8-4E67-82A1-B974498D1166@gnu.org> (Eli Zaretskii's message of "Tue, 19 Dec 2017 09:56:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141247 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > On December 19, 2017 9:02:33 AM GMT+02:00, martin rudalics wrote: >> > I'm perfectly happy to have it applied by someone with commit rights >> > (my paperwork is complete). As a bugfix I think it should go on the >> > release branch, but that's not my decision to make. >> >> Eli, is it OK to install Robert's patch on the release branch? To me >> it >> seems the best we have so far and any glitches it might add should be >> tolerable. And it could suppress complaints that some faulty behavior >> now already persists through three or four Emacs versions ... >> >> martin > > Please show tbe actual patch you are asking about. This has been a long discussion with quite a few patches, and I'd like to know what I'm asked to approve. Attached. Regards Robert --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Adjust-scrollbar-dimensions-when-scaling.patch >From 074d39597b1cff03053e369cf89ee701874afddb Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Tue, 10 Oct 2017 16:20:50 +0200 Subject: [PATCH] Adjust scrollbar dimensions when scaling 2017-10-10 Robert Pluim * src/gtkutil.c (xg_update_scrollbar_pos): Update width of scrollbar when scaling is in effect (xg_update_horizontal_scrollbar_pos): Update scrollbar size when scaling is in effect. --- src/gtkutil.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gtkutil.c b/src/gtkutil.c index c7d8f92829..88b7fd7e7b 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -3890,7 +3890,7 @@ xg_update_scrollbar_pos (struct frame *f, top /= scale; left /= scale; height /= scale; - left -= (scale - 1) * ((width / scale) >> 1); + width /= scale; /* Clear out old position. */ int oldx = -1, oldy = -1, oldw, oldh; @@ -3966,6 +3966,12 @@ xg_update_horizontal_scrollbar_pos (struct frame *f, GtkWidget *wfixed = f->output_data.x->edit_widget; GtkWidget *wparent = gtk_widget_get_parent (wscroll); gint msl; + int scale = xg_get_scale (f); + + top /= scale; + left /= scale; + height /= scale; + width /= scale; /* Clear out old position. */ int oldx = -1, oldy = -1, oldw, oldh; -- 2.15.0.rc1 --=-=-=--