From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ola.nilsson@gmail.com, larsi@gnus.org, 28605@debbugs.gnu.org,
kaushal.modi@gmail.com
Subject: bug#28605: 26.0.60; Part of leftmost character hidden
Date: Tue, 19 Dec 2017 09:10:33 +0100 [thread overview]
Message-ID: <87vah3jfye.fsf@gmail.com> (raw)
In-Reply-To: <471E581E-45F8-4E67-82A1-B974498D1166@gnu.org> (Eli Zaretskii's message of "Tue, 19 Dec 2017 09:56:10 +0200")
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> On December 19, 2017 9:02:33 AM GMT+02:00, martin rudalics <rudalics@gmx.at> wrote:
>> > I'm perfectly happy to have it applied by someone with commit rights
>> > (my paperwork is complete). As a bugfix I think it should go on the
>> > release branch, but that's not my decision to make.
>>
>> Eli, is it OK to install Robert's patch on the release branch? To me
>> it
>> seems the best we have so far and any glitches it might add should be
>> tolerable. And it could suppress complaints that some faulty behavior
>> now already persists through three or four Emacs versions ...
>>
>> martin
>
> Please show tbe actual patch you are asking about. This has been a long discussion with quite a few patches, and I'd like to know what I'm asked to approve.
Attached.
Regards
Robert
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Adjust-scrollbar-dimensions-when-scaling.patch --]
[-- Type: text/x-diff, Size: 1372 bytes --]
From 074d39597b1cff03053e369cf89ee701874afddb Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Tue, 10 Oct 2017 16:20:50 +0200
Subject: [PATCH] Adjust scrollbar dimensions when scaling
2017-10-10 Robert Pluim <rpluim@gmail.com>
* src/gtkutil.c (xg_update_scrollbar_pos): Update width of
scrollbar when scaling is in effect
(xg_update_horizontal_scrollbar_pos): Update scrollbar size
when scaling is in effect.
---
src/gtkutil.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/gtkutil.c b/src/gtkutil.c
index c7d8f92829..88b7fd7e7b 100644
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -3890,7 +3890,7 @@ xg_update_scrollbar_pos (struct frame *f,
top /= scale;
left /= scale;
height /= scale;
- left -= (scale - 1) * ((width / scale) >> 1);
+ width /= scale;
/* Clear out old position. */
int oldx = -1, oldy = -1, oldw, oldh;
@@ -3966,6 +3966,12 @@ xg_update_horizontal_scrollbar_pos (struct frame *f,
GtkWidget *wfixed = f->output_data.x->edit_widget;
GtkWidget *wparent = gtk_widget_get_parent (wscroll);
gint msl;
+ int scale = xg_get_scale (f);
+
+ top /= scale;
+ left /= scale;
+ height /= scale;
+ width /= scale;
/* Clear out old position. */
int oldx = -1, oldy = -1, oldw, oldh;
--
2.15.0.rc1
next prev parent reply other threads:[~2017-12-19 8:10 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 9:52 bug#28605: 26.0.60; Part of leftmost character hidden Ola Nilsson
2017-09-27 8:12 ` martin rudalics
2017-09-29 7:45 ` Ola Nilsson
2017-09-29 8:36 ` martin rudalics
2017-09-29 10:46 ` Ola Nilsson
2017-09-29 18:18 ` martin rudalics
2017-10-02 9:18 ` Ola Nilsson
2017-10-03 9:15 ` martin rudalics
2017-10-03 9:28 ` Lars Ingebrigtsen
2017-10-03 12:12 ` Ola Nilsson
2017-10-03 13:08 ` Robert Pluim
2017-10-03 15:49 ` Ola Nilsson
2017-10-03 16:58 ` Ola Nilsson
2017-10-04 6:48 ` Ola Nilsson
2017-10-04 9:05 ` martin rudalics
2017-10-04 9:05 ` martin rudalics
2017-10-04 9:59 ` Ola Nilsson
2017-10-04 11:56 ` Robert Pluim
2017-10-05 8:10 ` martin rudalics
2017-10-05 9:42 ` Robert Pluim
2017-10-05 12:46 ` Robert Pluim
2017-10-06 8:18 ` martin rudalics
2017-10-06 8:37 ` Robert Pluim
2017-10-06 9:35 ` martin rudalics
2017-10-06 11:50 ` Robert Pluim
2017-10-07 8:08 ` martin rudalics
2017-10-07 11:53 ` Lars Ingebrigtsen
2017-10-09 8:00 ` martin rudalics
2017-10-09 8:25 ` Lars Ingebrigtsen
2017-10-09 9:16 ` Robert Pluim
2017-10-09 12:21 ` martin rudalics
2017-10-08 9:51 ` Robert Pluim
2017-10-09 8:00 ` martin rudalics
2017-10-09 8:26 ` Lars Ingebrigtsen
2017-10-09 12:22 ` martin rudalics
2017-10-09 13:37 ` Robert Pluim
2017-10-10 8:13 ` martin rudalics
2017-10-10 8:44 ` Robert Pluim
2017-10-10 9:16 ` martin rudalics
2017-10-10 9:31 ` Eli Zaretskii
2017-10-10 9:54 ` Robert Pluim
2017-10-10 11:11 ` Robert Pluim
2017-10-10 13:26 ` martin rudalics
2017-10-10 14:00 ` Robert Pluim
2017-10-11 8:32 ` martin rudalics
2017-10-11 8:37 ` Robert Pluim
2017-10-09 14:18 ` Lars Ingebrigtsen
2017-10-10 8:14 ` martin rudalics
2017-10-10 8:39 ` Robert Pluim
2017-10-10 9:15 ` martin rudalics
2017-10-10 9:46 ` Robert Pluim
2017-10-10 13:25 ` martin rudalics
2017-10-10 8:54 ` Lars Ingebrigtsen
2017-10-10 13:05 ` Ola Nilsson
2017-10-10 13:26 ` martin rudalics
2017-10-10 15:32 ` Robert Pluim
2017-12-15 18:16 ` martin rudalics
2017-12-18 15:58 ` Robert Pluim
2017-12-19 7:02 ` martin rudalics
2017-12-19 7:56 ` Eli Zaretskii
2017-12-19 8:10 ` Robert Pluim [this message]
2017-12-19 16:09 ` Eli Zaretskii
2017-12-20 8:53 ` martin rudalics
2020-09-04 5:05 ` Lars Ingebrigtsen
2017-10-11 6:57 ` Ola Nilsson
2017-10-11 8:32 ` martin rudalics
2017-10-11 8:49 ` Robert Pluim
2017-10-11 9:28 ` martin rudalics
2017-10-11 10:36 ` Robert Pluim
2017-10-11 13:11 ` Ola Nilsson
2017-10-12 8:04 ` martin rudalics
2017-10-12 9:31 ` Robert Pluim
2017-10-13 8:56 ` martin rudalics
2017-10-13 9:58 ` Robert Pluim
2017-10-13 12:46 ` martin rudalics
2017-10-13 13:01 ` Robert Pluim
2017-10-14 8:36 ` martin rudalics
2017-10-14 8:57 ` Robert Pluim
2017-10-14 9:21 ` martin rudalics
2017-10-16 11:41 ` Robert Pluim
2017-10-17 8:57 ` martin rudalics
2017-10-17 10:30 ` Robert Pluim
2017-10-17 13:09 ` martin rudalics
2017-10-19 12:44 ` Robert Pluim
2017-10-20 7:55 ` martin rudalics
2017-10-20 13:41 ` Robert Pluim
2017-10-21 8:04 ` martin rudalics
2017-10-23 10:01 ` Robert Pluim
2017-10-23 11:54 ` martin rudalics
2017-10-23 12:12 ` Robert Pluim
2017-10-24 9:17 ` martin rudalics
2017-10-13 16:18 ` Ola Nilsson
2017-10-14 8:36 ` martin rudalics
2017-10-06 8:18 ` martin rudalics
2017-10-06 8:52 ` Robert Pluim
2017-10-06 9:35 ` martin rudalics
2017-10-05 11:57 ` Ola Nilsson
2017-10-04 9:03 ` martin rudalics
2017-10-03 15:26 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vah3jfye.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=28605@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=larsi@gnus.org \
--cc=ola.nilsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.