From: Cesar Crusius <cesar.crusius@gmail.com>
To: John Wiegley <johnw@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Any interest in an XOAUTH2 patch for smtpmail (Gmail 2-factor auth)?
Date: Sun, 07 Jan 2018 08:50:57 -0800 [thread overview]
Message-ID: <87vagd395a.fsf@gmail.com> (raw)
In-Reply-To: <m2373im3xg.fsf@newartisans.com>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On Sun 07 Jan 2018 at 09:08, John Wiegley wrote:
>>>>>> Cesar Crusius <cesar.crusius@gmail.com> writes:
>
>> 1. All that needs to happen in smtpmail.el is for the
>> 'smtpmail-try-auth-methods' to have the following patch:
>
> Could it be done using advice-add in an ELPA package, while also proposing a
> general mechanism for hooking into this part of smtpmail?
I guess so, although it feels a bit strange to advise a function in
'smtpmail.el' from an 'auth-source' package.
A proper generalization of 'smtp-try-auth-method' is easy, of
course. All you need is to split the test into functions, eg
'smtp-try-plain-auth-method', 'smtp-try-login-auth-method', etc, and
then have 'smtp-try-auth-method' simply call
'smtp-try-<mech>-auth-method.' Then anybody would be able to define
their own and just add them to the 'smtpmail-auth-supported' list.
Do you think it is work working on a patch like this first?
--
Cesar Crusius
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]
next prev parent reply other threads:[~2018-01-07 16:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 2:24 Any interest in an XOAUTH2 patch for smtpmail (Gmail 2-factor auth)? Cesar Crusius
2018-01-06 5:32 ` John Wiegley
2018-01-06 6:13 ` Tim Cross
2018-01-06 6:51 ` Cesar Crusius
2018-01-06 6:50 ` Cesar Crusius
2018-01-07 6:19 ` Cesar Crusius
2018-01-07 9:08 ` John Wiegley
2018-01-07 16:50 ` Cesar Crusius [this message]
2018-01-07 17:42 ` Stefan Monnier
2018-01-07 18:49 ` Cesar Crusius
2018-01-07 18:58 ` Stefan Monnier
2018-01-08 20:08 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vagd395a.fsf@gmail.com \
--to=cesar.crusius@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=johnw@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.