From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#30186: 27.0.50; Password is not hidden in read-passwd Date: Thu, 25 Jan 2018 23:15:41 +0200 Organization: LINKOV.NET Message-ID: <87vafp7i82.fsf@mail.linkov.net> References: <871sikmd6o.fsf@mail.linkov.net> <83zi57qk2w.fsf@gnu.org> <87bmhm7wbw.fsf@mail.linkov.net> <87y3kp8thj.fsf@mail.linkov.net> <87372w8ddp.fsf@mail.linkov.net> <20180125173937.GA3857@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516916616 22725 195.159.176.226 (25 Jan 2018 21:43:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 25 Jan 2018 21:43:36 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 30186@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 25 22:43:32 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eepId-0004V8-Cm for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jan 2018 22:43:11 +0100 Original-Received: from localhost ([::1]:38440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eepKe-0003Fe-1d for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jan 2018 16:45:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eepKT-0003Cl-JS for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 16:45:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eepKQ-0006As-T4 for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 16:45:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35000) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eepKQ-0006Ai-Oq for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 16:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eepKQ-0002V5-Hx for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 16:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2018 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30186 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30186-submit@debbugs.gnu.org id=B30186.15169166439483 (code B ref 30186); Thu, 25 Jan 2018 21:45:02 +0000 Original-Received: (at 30186) by debbugs.gnu.org; 25 Jan 2018 21:44:03 +0000 Original-Received: from localhost ([127.0.0.1]:42890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eepJT-0002St-8c for submit@debbugs.gnu.org; Thu, 25 Jan 2018 16:44:03 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:48842 helo=homiemail-a18.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eepJR-0002SN-G9 for 30186@debbugs.gnu.org; Thu, 25 Jan 2018 16:44:01 -0500 Original-Received: from homiemail-a18.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTP id 5A259258067; Thu, 25 Jan 2018 13:44:00 -0800 (PST) Original-Received: from localhost.linkov.net (m91-129-109-224.cust.tele2.ee [91.129.109.224]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 49FA7258066; Thu, 25 Jan 2018 13:43:59 -0800 (PST) In-Reply-To: <20180125173937.GA3857@ACM> (Alan Mackenzie's message of "Thu, 25 Jan 2018 17:39:38 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142521 Archived-At: >> Do you agree we could remove the effect of >> with-silent-modifications around set-text-properties, >> and leave it only on remove-list-of-text-properties? >> This will help to fix the reported regression. > > I'm not sure about this. Doesn't `set-text-properties' need to be > "protected", too? I'm not sure either. Do you think that `set-text-properties' without `with-silent-modifications' will cause the same problem that you described in http://lists.gnu.org/r/emacs-devel/2015-04/msg00506.html > I'm not sure why you want to do this. Why do you want to do this? Doing yank `C-y' in the minibuffer of `read-passwd' puts dots `.' over the yanked characters using `display' properties, then later `set-text-properties' removes all properties (exposing the yanked characters), but without `with-silent-modifications' it used to put `display' properties back. After the change that added `with-silent-modifications', the hook that puts `display' properties back doesn't run. > One thing which is puzzling me is that `with-silent-modifications' is a > macro which is defined in subr.el, but later in the file. Won't this > invocation of w-s-m get compiled as a function call because of this? `with-silent-modifications' is a macro that let-binds `inhibit-modification-hooks' to `t', thus preventing the hook in `read-passwd' from running.