From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#26298: 26.0.50; Gnus fails to sign mail with PGP Date: Sun, 28 Jan 2018 16:23:02 -0500 Message-ID: <87vaflk79l.fsf@users.sourceforge.net> References: <871sod1zmz.fsf@users.sourceforge.net> <87h92cp9dh.fsf@wilson.bronger.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1517174546 13262 195.159.176.226 (28 Jan 2018 21:22:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 28 Jan 2018 21:22:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 26298@debbugs.gnu.org, Torsten Bronger To: Toon Claes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 28 22:22:21 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efuOu-0002Ua-Ss for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jan 2018 22:22:09 +0100 Original-Received: from localhost ([::1]:37991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efuQv-0007RL-Ou for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jan 2018 16:24:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efuQo-0007QI-FJ for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2018 16:24:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efuQl-0008Lx-8f for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2018 16:24:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38911) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1efuQl-0008Ls-4J for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2018 16:24:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1efuQj-0004WZ-Tb; Sun, 28 Jan 2018 16:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 28 Jan 2018 21:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26298 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: Original-Received: via spool by 26298-submit@debbugs.gnu.org id=B26298.151717459417336 (code B ref 26298); Sun, 28 Jan 2018 21:24:01 +0000 Original-Received: (at 26298) by debbugs.gnu.org; 28 Jan 2018 21:23:14 +0000 Original-Received: from localhost ([127.0.0.1]:46807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efuPx-0004VY-OX for submit@debbugs.gnu.org; Sun, 28 Jan 2018 16:23:13 -0500 Original-Received: from mail-it0-f48.google.com ([209.85.214.48]:55144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efuPv-0004VK-79 for 26298@debbugs.gnu.org; Sun, 28 Jan 2018 16:23:11 -0500 Original-Received: by mail-it0-f48.google.com with SMTP id k131so6034881ith.4 for <26298@debbugs.gnu.org>; Sun, 28 Jan 2018 13:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=F3Ed0lb1rQY+lAdRANrf991qtOzfchicpXFT0JEtePQ=; b=I1xLB5rV2vvTIc2KYl3pv1j/UkyJ5UTl6fIkFQ+O007Wz/WUkWZSGrQt5SGs8Gf5+t opOp/hxXLfQ8DUkh7knQubJ0PtVPBMmw9BX9W0zZGDq2EIKlKhupLvwaTk3U37C5X4tR ShIsJa9qljPZhgnRfeTntb7jXOTJkamINEu4rmCt3SEfJ10Gu0hZMgQFc/xmbZFjROFA W7AE5shSjbrP+m3Hn8L6eB9+0nFJtr4UDJTaxW4ytzkWIOMkGjC7VmErlmhjnAFabxRc iec0bICcPMaU+KkMXG/tugc10vTTLHjZqD80tYJb3in7SDMchbRIRD8X+QXgS1JpGzV/ NnNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=F3Ed0lb1rQY+lAdRANrf991qtOzfchicpXFT0JEtePQ=; b=gaC4p3uFC4pzfBDnzzuRoxqA8HsygugCkHo4phWX1Cw4IO83dgAYPiEPSSFoo9xR/X 0xGRaRk7Dj10jsiLBOtW3L/CQpfbrQNl68AWL0bz931YohIKax6uG3SSeG08dGWjykVn jDrJ1RqSLd6XsIHD/+oYEzKFtubMOtMoij/+qsPlLn/NlB49c+S4w9hu28jzGa6vLrjz /yFqWV8VkoGOJ4j4qUbcYyPDeUqLsexmtR7jOJ4igkutl1/8mnE7bqiG8qWXrl6oly6R KdhsFd6tPHIHRzLFqLPBjxpbqs/2M1kezmfR9a93gxh4Av6kfkQZx/FUOrurbH1cmhWK mE2w== X-Gm-Message-State: AKwxyteEXHNNng0INag7GuCaRAU90q7sv851HDzMj3Ca203lgF9wDZjR aZ5HIltIlKcmikScxm2Dt2ZQWQ== X-Google-Smtp-Source: AH8x224zhmUxbH/RCsxYbiesqoicj6TO6q94WgLZjdCeGWvxRf+cWI00ygNjOmcraPUUFJLc9Tq0MQ== X-Received: by 10.36.74.200 with SMTP id k191mr26258909itb.69.1517174585625; Sun, 28 Jan 2018 13:23:05 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m100sm3178348iod.52.2018.01.28.13.23.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Jan 2018 13:23:04 -0800 (PST) In-Reply-To: (Toon Claes's message of "Sun, 28 Jan 2018 20:39:31 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142623 Archived-At: Toon Claes writes: > On Tue, Aug 15, 2017 at 1:54 AM, Toon Claes wrote: >> npostavs@users.sourceforge.net writes: >> >>> Does the patch at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23619#14 >>> help? >> >> Well, actually it does help. > > One thing though, with this patch, if I enter the incorrect passphrase, > it gives me an error: > > Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil) > mml2015-epg-sign((part (sign . "pgpmime") (tag-location . 803) (contents . ""))) > mml2015-sign((part (sign . "pgpmime") (tag-location . 803) (contents . ""))) I can't reproduce the original bug, but this I can, although with mml1991 (not clear to me how this get's chosen). I think it's just a matter of making the error a bit clearer, e.g.: --- i/lisp/gnus/mml1991.el +++ w/lisp/gnus/mml1991.el @@ -277,6 +277,8 @@ mml1991-epg-sign (mm-decode-content-transfer-encoding cte))) (let* ((pair (mml-secure-epg-sign 'OpenPGP 'clear)) (signature (car pair))) + (unless (stringp signature) + (error "Signature failed")) (delete-region (point-min) (point-max)) (insert (with-temp-buffer diff --git i/lisp/gnus/mml2015.el w/lisp/gnus/mml2015.el index b220a96098..6baae80309 100644 --- i/lisp/gnus/mml2015.el +++ w/lisp/gnus/mml2015.el @@ -958,6 +958,8 @@ mml2015-epg-sign (let* ((pair (mml-secure-epg-sign 'OpenPGP t)) (signature (car pair)) (micalg (cdr pair))) + (unless (stringp signature) + (error "Signature failed")) (goto-char (point-min)) (insert (format "Content-Type: multipart/signed; boundary=\"%s\";\n" boundary)) > When I try again instantly, it does not ask me for the passphrase and > just pops up the same error. When I wait for, I think, about 10 seconds > to retry, it asks for a passphrase again. Hmm, I can't reproduce this one, I guess it's related to gpg version (I have 2.1.18) and how the caching works.