From: Juri Linkov <juri@linkov.net>
To: Leo Liu <sdl.web@gmail.com>
Cc: 30187@debbugs.gnu.org
Subject: bug#30187: master a710f8a: * lisp/comint.el (comint-history-isearch-setup): Check if process is live.
Date: Thu, 08 Feb 2018 23:29:03 +0200 [thread overview]
Message-ID: <87vaf7tbkw.fsf@mail.linkov.net> (raw)
In-Reply-To: <m1vaf8xjf9.fsf@gmail.com> (Leo Liu's message of "Thu, 08 Feb 2018 11:13:46 +0800")
[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]
>> For example, try to set comint-history-isearch to ‘dwim’
>> and type ‘C-r’ in a *Async Shell Command* buffer. It fails with
>>
>> Lisp error: (wrong-type-argument processp nil)
>> process-mark(nil)
>> comint-after-pmark-p()
>> comint-history-isearch-setup()
>> ...
>
> It seems to make a lot of sense to have comint-after-pmark-p return nil
> instead. WDYT?
Good idea. The patch at the end of this message also always checks
if the prompt is empty at the end of the shell buffer to exclude
Async Shell Command buffers and inactive shells.
>> Or even when comint-history-isearch is nil by default, run shell ‘M-x shell’,
>> then exit it, and after “Process shell finished” type ‘M-r’ and any letter
>> to search for it:
>>
>> Lisp error: (wrong-type-argument processp nil)
>> process-mark(nil)
>> comint-delete-input()
>> comint-goto-input(nil)
>> comint-history-isearch-pop-state
>> ...
>>
>> In these cases the history can't be searched because there is no active shell.
>> I wonder what use case do you need in inactive shells without a prompt,
>> so it's impossible to search in the history. How you used to search
>> through the shell history without failing in ‘comint-goto-input’ like
>> in the backtrace above?
>
> My use case is using a function (or in Erlang's lingo a light-weight
> process) to communicate with a remote Erlang shell. So there is no
> process as comint/emacs understands.
Nice, good to know, as these days I completely switched to Elixir.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: comint-after-pmark-p.patch --]
[-- Type: text/x-diff, Size: 1810 bytes --]
diff --git a/lisp/comint.el b/lisp/comint.el
index b4fbfc8..22fbe06 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -1448,17 +1448,18 @@ comint-history-isearch-message-overlay
(defun comint-history-isearch-setup ()
"Set up a comint for using Isearch to search the input history.
Intended to be added to `isearch-mode-hook' in `comint-mode'."
- (when (and (get-buffer-process (current-buffer))
+ (when (and
+ ;; Prompt is not empty like in Async Shell Command buffers
+ ;; or in inactive shells
+ (not (eq (save-excursion
+ (goto-char (comint-line-beginning-position))
+ (forward-line 0)
+ (point))
+ (comint-line-beginning-position)))
(or (eq comint-history-isearch t)
(and (eq comint-history-isearch 'dwim)
;; Point is at command line.
- (comint-after-pmark-p)
- ;; Prompt is not empty like in Async Shell Command buffers
- (not (eq (save-excursion
- (goto-char (comint-line-beginning-position))
- (forward-line 0)
- (point))
- (comint-line-beginning-position))))))
+ (comint-after-pmark-p))))
(setq isearch-message-prefix-add "history ")
(setq-local isearch-search-fun-function
#'comint-history-isearch-search)
@@ -2288,8 +2289,10 @@ comint-skip-prompt
(defun comint-after-pmark-p ()
"Return t if point is after the process output marker."
- (let ((pmark (process-mark (get-buffer-process (current-buffer)))))
- (<= (marker-position pmark) (point))))
+ (let ((process (get-buffer-process (current-buffer))))
+ (when process
+ (let ((pmark (process-mark process)))
+ (<= (marker-position pmark) (point))))))
(defun comint-simple-send (proc string)
"Default function for sending to PROC input STRING.
next prev parent reply other threads:[~2018-02-08 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180206213907.23079.76097@vcs0.savannah.gnu.org>
[not found] ` <20180206213908.03CCC208E4@vcs0.savannah.gnu.org>
2018-02-07 1:19 ` master a710f8a: * lisp/comint.el (comint-history-isearch-setup): Check if process is live Leo Liu
2018-02-07 21:20 ` bug#30187: " Juri Linkov
2018-02-08 3:13 ` Leo Liu
2018-02-08 21:29 ` Juri Linkov [this message]
2018-02-09 2:45 ` Leo Liu
2018-02-11 21:44 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaf7tbkw.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=30187@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.