From: Robert Pluim <rpluim@gmail.com>
To: Jan Synacek <jsynacek@redhat.com>
Cc: 30874@debbugs.gnu.org
Subject: bug#30874: 27.0.50; Emacs crashes
Date: Tue, 03 Apr 2018 11:22:05 +0200 [thread overview]
Message-ID: <87vad8wsoy.fsf@gmail.com> (raw)
In-Reply-To: <CAPsXM8V7bzi62tkWhL=pGHkc_d3+o6Yfs9zJSO9k-9DLtf7jFw@mail.gmail.com> (Jan Synacek's message of "Tue, 3 Apr 2018 10:00:41 +0200")
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
tags 30874 patch
quit
Jan Synacek <jsynacek@redhat.com> writes:
>
> Yes, it does fix the problem for me.
Thanks. Proposed patch for master attached. Eli, should I merge this
bugreport with 30045? The patch fixes that crash for me as well.
Robert
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Ignore-color-fonts-when-using-Xft.patch --]
[-- Type: text/x-patch, Size: 2337 bytes --]
From 1efdd2b9a5cb3880e4878dbc7c918ccac9da2393 Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Tue, 3 Apr 2018 11:06:01 +0200
Subject: [PATCH] Ignore color fonts when using Xft
To: emacs-devel@gnu.org
* src/font.c (syms_of_font): New configuration variable
xft-ignore-color-fonts, default t.
* src/ftfont.c (ftfont_spec_pattern): Tell fontconfig to ignore
color fonts if xft-ignore-color-fonts is t. Bug#30874
---
etc/NEWS | 6 ++++++
src/font.c | 7 +++++++
src/ftfont.c | 7 +++++++
3 files changed, 20 insertions(+)
diff --git a/etc/NEWS b/etc/NEWS
index fd1d04b8a0..177af9f088 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -77,6 +77,12 @@ work right without some adjustment:
\f
* Changes in Emacs 27.1
+---
+** New variable 'xft-ignore-color-fonts'.
+Default t means don't try to load color fonts when using Xft, as they
+often cause crashes. Set it to nil if you really need those fonts.
+(Bug#30874)
+
---
** The new option 'tooltip-resize-echo-area' avoids truncating tooltip text
on GUI frames when tooltips are displayed in the echo area. Instead,
diff --git a/src/font.c b/src/font.c
index a6d3f5d479..fa89805419 100644
--- a/src/font.c
+++ b/src/font.c
@@ -5473,6 +5473,13 @@ Disabling compaction of font caches might enlarge the Emacs memory
footprint in sessions that use lots of different fonts. */);
inhibit_compacting_font_caches = 0;
+ DEFVAR_BOOL ("xft-ignore-color-fonts",
+ Vxft_ignore_color_fonts,
+ doc: /*
+Non-nil means don't query fontconfig for color fonts, since they often
+cause Xft crashes. Only has an effect in Xft builds. Bug#30874. */);
+ Vxft_ignore_color_fonts = 1;
+
#ifdef HAVE_WINDOW_SYSTEM
#ifdef HAVE_FREETYPE
syms_of_ftfont ();
diff --git a/src/ftfont.c b/src/ftfont.c
index c2e093e633..24a92dd52e 100644
--- a/src/ftfont.c
+++ b/src/ftfont.c
@@ -764,6 +764,13 @@ ftfont_spec_pattern (Lisp_Object spec, char *otlayout, struct OpenTypeSpec **ots
if (scalable >= 0
&& ! FcPatternAddBool (pattern, FC_SCALABLE, scalable ? FcTrue : FcFalse))
goto err;
+#ifdef HAVE_XFT
+ /* We really don't like color fonts, they cause Xft crashes. See
+ Bug#30874. */
+ if (Vxft_ignore_color_fonts
+ && ! FcPatternAddBool(pattern, FC_COLOR, FcFalse))
+ goto err;
+#endif
goto finish;
--
2.17.0.rc1.35.g90bbd502d
next prev parent reply other threads:[~2018-04-03 9:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 10:24 bug#30874: 27.0.50; Emacs crashes Jan Synacek
2018-03-20 12:04 ` Eli Zaretskii
2018-03-20 12:12 ` Jan Synacek
2018-03-20 12:44 ` Eli Zaretskii
2018-03-22 12:28 ` Jan Synacek
2018-03-22 13:01 ` Eli Zaretskii
2018-03-22 13:05 ` Jan Synacek
2018-03-22 14:55 ` Eli Zaretskii
2018-03-26 9:12 ` Jan Synacek
2018-03-26 10:33 ` Robert Pluim
2018-03-26 15:25 ` Eli Zaretskii
2018-03-26 16:52 ` Robert Pluim
2018-03-26 17:33 ` Eli Zaretskii
2018-03-26 20:17 ` Robert Pluim
2018-03-26 22:16 ` Robert Pluim
2018-03-27 3:02 ` Eli Zaretskii
2018-03-27 8:57 ` Robert Pluim
2018-03-29 10:25 ` Eli Zaretskii
2018-03-29 16:14 ` Robert Pluim
2018-03-29 17:07 ` Eli Zaretskii
2018-03-30 5:10 ` Glenn Morris
2018-03-30 8:00 ` Eli Zaretskii
2018-03-30 10:36 ` Robert Pluim
2018-03-30 11:46 ` Eli Zaretskii
2018-03-30 13:00 ` Robert Pluim
2018-03-30 13:46 ` Eli Zaretskii
2018-03-31 13:55 ` Robert Pluim
2018-03-31 14:59 ` Eli Zaretskii
2018-04-03 9:24 ` Robert Pluim
2018-04-03 8:00 ` Jan Synacek
2018-04-03 9:22 ` Robert Pluim [this message]
2018-04-03 9:42 ` Eli Zaretskii
2018-04-03 12:52 ` Robert Pluim
2018-03-29 10:35 ` Jan Synacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vad8wsoy.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=30874@debbugs.gnu.org \
--cc=jsynacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.