From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Shahid Newsgroups: gmane.emacs.help Subject: Re: Default value of recenter-redisplay Date: Sun, 29 Apr 2018 22:11:01 +0000 Message-ID: <87vac9ll3t.fsf@gmail.com> References: <87h8nuw1be.fsf@gmail.com> <83po2hsy6s.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1525039773 1926 195.159.176.226 (29 Apr 2018 22:09:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Apr 2018 22:09:33 +0000 (UTC) User-Agent: mu4e 1.0-alpha3; emacs 27.0.50 Cc: help-gnu-emacs@gnu.org To: Eli Zaretskii Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Apr 30 00:09:28 2018 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fCuVc-0000QF-Od for geh-help-gnu-emacs@m.gmane.org; Mon, 30 Apr 2018 00:09:28 +0200 Original-Received: from localhost ([::1]:56947 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fCuXj-0000of-8F for geh-help-gnu-emacs@m.gmane.org; Sun, 29 Apr 2018 18:11:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fCuXI-0000oa-QG for help-gnu-emacs@gnu.org; Sun, 29 Apr 2018 18:11:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fCuXD-0002Ae-OJ for help-gnu-emacs@gnu.org; Sun, 29 Apr 2018 18:11:12 -0400 Original-Received: from mail-qk0-x22b.google.com ([2607:f8b0:400d:c09::22b]:32891) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fCuXD-00029G-IL; Sun, 29 Apr 2018 18:11:07 -0400 Original-Received: by mail-qk0-x22b.google.com with SMTP id c70so5440311qkg.0; Sun, 29 Apr 2018 15:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:message-id:in-reply-to :date:mime-version; bh=eCon0o9n2nHc03FrxfflALeqPt1JtkkGalLbcHEX0+E=; b=DtK8XOn80pApb8/UrahWXOm5rpHfWs1KDsAKp+X3Ngt8f8OpFkPSKUU+xW7nDiKOmR dmJQKIUdbTwDFyRZeJLQbrIiSwG4YT/bIbpRIlN1woQBc6fNkpFXU48wJeM0F5qTmnyh gomLoQWgSVG76Oh62d59aGyIETv/ZqWRYpK+/boXUeRVGqpq8KstbCKA0Ibs7OPUD3JM O1KY8LBlV21elav/3cGx/sRbn6LPTG/ffUHRXiIYosxZRqX/cLbbycJQIr4E6dQnS+29 H1B+wTG/Yaob/CPvnbgvNlT9XrgoHFRe36OaufRKmwGrEVPZntCitfjV/OWlZBJOGQ8B 3KyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :message-id:in-reply-to:date:mime-version; bh=eCon0o9n2nHc03FrxfflALeqPt1JtkkGalLbcHEX0+E=; b=GMvyQBOSxZyfzwwRidzNTqMucgvPlLTBqMty3WT7fECYLP18tmjyRyvyRhZLJuW1f+ +vYO23hTotwX9e5PkTh9doB+/9iP6GW6Ol+L/+pM/fxStp3MZABpLhWmNRGB3vS/31uC mzDPg9mPG05JHL6sHux2Zq+MM2BuvlFIJxViLOjZcEUJ4dZJ1vzKVqcii4oLs5KSTuEj IEs3V5KpqJb91O2MGRIMSOI6eS7SxnfHBZ0dxk+KDl0T0ClLBB5r4GfN9tal12h3DxwV 1NIOgr5Ntza8MGJpi25nmrc0d28Ulj6GF/XxvW6qpPctFUmAtFfj2vdYebQWi8xAuNQb CiOg== X-Gm-Message-State: ALQs6tB0VKQsZI8C4GUBW55HNzjKw/Mjr8Cp7MkmAkcMYhXRLykFDuoH 6V3yOx28sD8K4PBIA02uoUuL8xWV X-Google-Smtp-Source: AB8JxZrDm/uQXjnYOWzs8wmALu9m2tvdtCh1EHTqibkCDUWJw+8YUCwDdTFCm8h3Jl1u8csT0IBwZQ== X-Received: by 10.55.130.67 with SMTP id e64mr8817630qkd.128.1525039866521; Sun, 29 Apr 2018 15:11:06 -0700 (PDT) Original-Received: from de9210e3fd4c (cpe-184-152-55-93.nyc.res.rr.com. [184.152.55.93]) by smtp.gmail.com with ESMTPSA id u50-v6sm5644371qth.0.2018.04.29.15.11.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Apr 2018 15:11:05 -0700 (PDT) In-reply-to: <83po2hsy6s.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22b X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:116636 Archived-At: Eli Zaretskii writes: >> From: John Shahid >> Date: Sun, 29 Apr 2018 14:10:29 +0000 >> >> Today I decided to tackle a flicker issue that happens when the flycheck >> error list is displayed for the current buffer(i.e. by calling >> `flycheck-list-errors' interactively). It turns out the flickering is >> caused by a call to recenter[1] that happens inside a flycheck >> post-command-hook[2]. Setting `recenter-redisplay' to nil fixes the >> issue. > > Btw, everything that was said about using 'recenter' to clean up the > screen mess is only related to invoking that command interactively. > If Flycheck needs to invoke it without causing flickering on TTYs, it > can let-bind recenter-redisplay around the call. Please consider > suggesting that to the Flycheck developer(s). I have given this more thought since my initial post. I understand the arguments for not changing the default behavior and I support them given that I have occasionally used C-l to redraw the frame. That said, I would like to propose something else. I feel that `recenter' is a primitive command that shouldn't combine more than one functionality (i.e. recenter and redisplay). Could we either: 1. introduce a new lisp function for recentering and discourage the use of `recenter' from lisp (i.e. declaring it `interactive-only'), or 2. add a new `recenter-and-redisplay' and bound it to C-l My argument for the change is that the only use case for the redisplay is when called interactively. I don't think the intention of calling `recenter' in lisp code is to also redisplay the frame. I also find it annoying to have to wrap every call to `recenter' in a let-bind. cheers, -js