From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31749: 26.1; Improve eldoc message commands heuristic Date: Wed, 13 Jun 2018 20:10:25 -0400 Message-ID: <87vaamw7m6.fsf@gmail.com> References: <87wovabbae.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528934954 17169 195.159.176.226 (14 Jun 2018 00:09:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 14 Jun 2018 00:09:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31749@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 14 02:09:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTFp7-0004ND-Mi for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2018 02:09:09 +0200 Original-Received: from localhost ([::1]:37403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTFrE-0003Ea-8Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jun 2018 20:11:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTFr1-0003Bg-J2 for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2018 20:11:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTFqy-00036N-DP for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2018 20:11:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39170) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTFqy-00036F-8E for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2018 20:11:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fTFqw-0002w3-9E for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2018 20:11:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jun 2018 00:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31749 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31749-submit@debbugs.gnu.org id=B31749.152893503311248 (code B ref 31749); Thu, 14 Jun 2018 00:11:02 +0000 Original-Received: (at 31749) by debbugs.gnu.org; 14 Jun 2018 00:10:33 +0000 Original-Received: from localhost ([127.0.0.1]:47067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTFqT-0002vG-IT for submit@debbugs.gnu.org; Wed, 13 Jun 2018 20:10:33 -0400 Original-Received: from mail-io0-f182.google.com ([209.85.223.182]:33699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTFqS-0002v0-D5; Wed, 13 Jun 2018 20:10:32 -0400 Original-Received: by mail-io0-f182.google.com with SMTP id d185-v6so5369632ioe.0; Wed, 13 Jun 2018 17:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TqddoY2C+WS3ZuflsOeklqSZYZgrVKSZV4FW8+faRFk=; b=McGo9FNW74gOVrL/MvpOPF9m+wS3YQs2u3kPzGbpY2Z2DsgDH3uRERW5DE7e4TgiXb 98Paq3A0oWRWT8BJl/B0Rh0COVSurgibCxaCCR2dVs71JrfLbr9oH9lM77wIv1mhNXgf HV2++VKVEpGWo6UjkkZkeXCU0YDm6zUamyDbzUslTZETwwtoIBc/Rqz9YE5jZW8ISHos 56vhSBJ1jY0Pas3418wwb/U+4L1zn+NLU+oet7FsP7o8m9X2MoNAB1qmMagdp+fFpWv/ rMCCrufQzyEaT4l6yoKgt89psv9gu//QZfYQzKhlbXhCuPcSBlY2JdEfRs7Yk2UKNjmQ SoWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TqddoY2C+WS3ZuflsOeklqSZYZgrVKSZV4FW8+faRFk=; b=EmkaZ4gy7ccT/y3Wj9i9hZD2V18sLKKWQs9h9rKfI76mtP10p1sVd5tLCcqXAEeuhs V+vxuU5/otJrCN3k7gj5ENzt2LuT86mbXrcdjKL5xv0S+d/EVwvcBiat2s1MGIp+AzzW KWLNcCOSaoTgBis9zhnrbyCKwtGyHnJ8O+UHIvdMhb+oV9Bf1el7AsDtjWwf3X61jIhD GK/T8OnBN6mMZxCVLttMY8+TXajxQOAO1FQ192fkMSO6AQKWc/2NGlgwNQ+QXH1y6y8h Jw8lPsjoztWVqS5ZaOE959JzbM7Sygu/fbaQJ+5gJ14Ihm2JxO59oz3p5XzfRhfaAa+5 Crsw== X-Gm-Message-State: APt69E2bRCj3xI+bTmLhgem4BELx3tsvmc3STF1fqVd8LvK/V94VizHm 345OMJX38VJxbPLGllXFSwi/jQ== X-Google-Smtp-Source: ADUXVKI50HA6kCXTX7S3Mb7PcPQBtT+aCRPOpwN/Zjd56nJkzPkt+IhMpxsYTH9l4tIkyB3X6Z/z1Q== X-Received: by 2002:a6b:b205:: with SMTP id b5-v6mr323978iof.186.1528935026985; Wed, 13 Jun 2018 17:10:26 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id c102-v6sm369939itd.3.2018.06.13.17.10.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Jun 2018 17:10:26 -0700 (PDT) In-Reply-To: <87wovabbae.fsf@gmail.com> (Carlos Pita's message of "Thu, 07 Jun 2018 17:18:33 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147391 Archived-At: severity 31749 wishlist quit Carlos Pita writes: > The current criterion essentially removes the echo area message after > any command not whitelisted in eldoc-message-commands. > > This is problematic since the list of relevant commands is unknown in > advance for evert possible extension package. One could argue that > extension package maintainers are responsible then, but I have had many > problems with eldoc behaving suboptimally in conjunction with company > mode, elpy mode and others (which are all quality extensions) that I > wouldn't put the burden of this on the maintainers. > > Now, I might be completely wrong, but why don't you just check if > (current-message) is nil or not? This way if any command has written to > the echo area eldoc won't override its message. You can still keep the > whitelist in order to force override by eldoc (although I don't see much > value in this). You have probably thought many times about this > alternative and rejected for reasons I'm unable to see, but it's worth > to intent ;) Not sure if anybody's considered this, perhaps you can try it out and see if there are any drawbacks?