From: Noam Postavsky <npostavs@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: 31951@debbugs.gnu.org
Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate
Date: Sun, 24 Jun 2018 09:37:26 -0400 [thread overview]
Message-ID: <87vaa8pap5.fsf@gmail.com> (raw)
In-Reply-To: <87y3f5mq07.fsf@gmail.com> ("João Távora"'s message of "Sat, 23 Jun 2018 17:22:48 +0100")
João Távora <joaotavora@gmail.com> writes:
> If the Emacs client was started without an explicit list of buffers to
> edit, save-some-buffers is called with t for PRED (save all buffers),
> but that was before save-some-buffers-default-predicate existed.
>
> I don't see any reason why save-some-buffers-default-predicate shouldn't
> be respected in server-save-buffers-kill-terminal (of course if ARG is
> non-nil, we do pass t so that the previous behaviour remains).
> ;; If client is bufferless, emulate a normal Emacs exit
> ;; and offer to save all buffers. Otherwise, offer to
> ;; save only the buffers belonging to the client.
> (save-some-buffers
> - arg (if buffers
> - (lambda () (memq (current-buffer) buffers))
> - t))
> + arg (and buffers
> + (lambda () (memq (current-buffer) buffers))
> + (and arg t)))
I think you meant
+ arg (if buffers
+ (lambda () (memq (current-buffer) buffers))
+ (and arg t))
But I'm not sure if this change makes sense, seeing as
save-buffers-kill-emacs also ignores
save-some-buffers-default-predicate:
(defun save-buffers-kill-emacs (&optional arg)
[...]
;; Don't use save-some-buffers-default-predicate, because we want
;; to ask about all the buffers before killing Emacs.
(save-some-buffers arg t)
next prev parent reply other threads:[~2018-06-24 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 16:22 bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate João Távora
2018-06-24 13:37 ` Noam Postavsky [this message]
2018-06-24 20:22 ` João Távora
2018-06-24 20:46 ` Noam Postavsky
2018-06-25 11:07 ` João Távora
2018-06-26 1:53 ` Noam Postavsky
2018-06-26 19:27 ` João Távora
2018-06-27 13:20 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaa8pap5.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31951@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.