From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: netsec 682578f 4/6: Add option to bypass NSM TLS checks on local networks Date: Tue, 17 Jul 2018 17:53:57 +0200 Message-ID: <87va9dg8oa.fsf@gmail.com> References: <20180714170806.8972.58581@vcs0.savannah.gnu.org> <20180714170809.C3A3920456@vcs0.savannah.gnu.org> <87o9f84t89.fsf@gmail.com> <4C758D1D-7C3A-425A-852F-75E03C779E01@gmail.com> <87va9fs3ro.fsf@gmail.com> <83tvoz8bus.fsf@gnu.org> <87fu0jrvye.fsf@gmail.com> <83in5f833i.fsf@gnu.org> <87pnzm8989.fsf@gmail.com> <83o9f57tfz.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531842879 20609 195.159.176.226 (17 Jul 2018 15:54:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Jul 2018 15:54:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 17 17:54:35 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffSJ8-0005FO-G4 for ged-emacs-devel@m.gmane.org; Tue, 17 Jul 2018 17:54:34 +0200 Original-Received: from localhost ([::1]:60119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffSLF-00082m-FR for ged-emacs-devel@m.gmane.org; Tue, 17 Jul 2018 11:56:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffSIf-0006gS-Bq for emacs-devel@gnu.org; Tue, 17 Jul 2018 11:54:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffSIc-0006Ht-8d for emacs-devel@gnu.org; Tue, 17 Jul 2018 11:54:05 -0400 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:41863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffSIc-0006HM-2F; Tue, 17 Jul 2018 11:54:02 -0400 Original-Received: by mail-wr1-x430.google.com with SMTP id j5-v6so1750185wrr.8; Tue, 17 Jul 2018 08:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=qYkxnI8x24vpIwjrVqjYGESpd2+2JewcbCGF3i3D2VM=; b=ClCtoSv9yepX9zTe/N9G/Z1DTX5+Y0ziiyftRIDEQEpm8wseklnfAzsVXuoGQtLmk0 E48JWR1hIWbMSfks/AZfuJMhcGDTIkL49vk/aMDzXfuJg6+cV6FnSYRhDOshCZI5/vEh Vo/aaURszX/yWu9fAQwNvRmw27a+DJCfvB4yNWaLf0gPg+PAorry2zvlOzhYyLkZ18IR fq+HUUrwLmUbst+xE+jGTNacuAzJPUiiqlGlwZ+qLpMgB86CkAuXpk13rOeUVfW9q55g DjMkWwPejtmcSefCwBtLVeh46l+ZocIIN02USewYSYoJXzZA3kg3zyYqCqs95LlZ9CFG GI2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version; bh=qYkxnI8x24vpIwjrVqjYGESpd2+2JewcbCGF3i3D2VM=; b=DE18LIc/rYgFBIryfopcRgDTHY5pJjys/5NMLUHf94lorq9QD+AsERM8ZXxZX2Ue/x nTJFN0ypaP2lRoUCT0P9iGUNO1qbwiU8Xnv5NcKqCon6WQQsIeUaNr33QknY82r5CZ02 nAcCMIylVQSDFYdne7QC75v9s+Kl7w3+IlD4N9hNaiclCTVbKhbE5SAZGgDM9iF0oIF8 brJWEc/q4MEWOS0LLzPQJKbp8/s+SICuMpHMCskD4IPW5W2nxpPSLMwtGh9MaOaCDnNs m1kpbH+icMX+rHAROR7O682wGyLKARvnUCJjZeXufjXUkri6yB7cvnHZ3GAfLzDPCZrm vW2Q== X-Gm-Message-State: AOUpUlEP52HSeeuqkM7O0N85FS5WkNuWfNCdr77BDgAxQ1liQWwQwgSv tv9wjdWF2URvzGgn2t0iBxmwXlnB X-Google-Smtp-Source: AAOMgpf2mJzDUWa+9/FYP38lBBhBWSvKhvQv6Cve7ucxfGvqdNRrT8C277Q+GwjROolfPRcT8UT2MA== X-Received: by 2002:a5d:4701:: with SMTP id y1-v6mr1811883wrq.107.1531842840165; Tue, 17 Jul 2018 08:54:00 -0700 (PDT) Original-Received: from rpluim ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id 185-v6sm2517721wmw.23.2018.07.17.08.53.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Jul 2018 08:53:59 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <83o9f57tfz.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Jul 2018 18:50:08 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::430 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227502 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: emacs-devel@gnu.org >> Date: Tue, 17 Jul 2018 12:09:10 +0200 >> >> Eli Zaretskii writes: >> > >> > Then I think we should test that it's either a unibyte string or a >> > string whose size in bytes is equal to its size in characters, and >> > signal an error if that doesn't hold. >> >> So I tried using STRING_MULTIBYTE, but of course eww uses >> puny-encode-domain on unicode hostnames, and that returns a multibyte >> string that only contains ASCII characters. Rather than opening that >> can of worms, I settled on checking >> >> SBYTES (host) != SCHARS (host) > > This will signal an error for unibyte strings, because there SBYTES is > always -1. So I think you should do this instead: > Ah, I was assuming they'd always be in sync. > STRING_MULTIBYTE (host) && SBYTES (host) != SCHARS (host) OK, that works. Thanks Robert