From: Noam Postavsky <npostavs@gmail.com>
To: Yuri D'Elia <wavexx@thregr.org>
Cc: 27822@debbugs.gnu.org
Subject: bug#27822: [PATCH] do not auto-remove external packages (fixes #27822)
Date: Wed, 08 Aug 2018 21:19:02 -0400 [thread overview]
Message-ID: <87va8kwd4p.fsf@gmail.com> (raw)
In-Reply-To: <877elugljf.fsf@wavexx.thregr.org> (Yuri D'Elia's message of "Tue, 17 Jul 2018 13:16:04 +0200")
Yuri D'Elia <wavexx@thregr.org> writes:
>
>>From 5a4234b3c1289960fd760256aa6399efbd04bfc3 Mon Sep 17 00:00:00 2001
> From: Yuri D'Elia <wavexx@thregr.org>
> Date: Tue, 17 Jul 2018 12:59:35 +0200
> Subject: [PATCH] Do not consider external packages to be removable
>
> Packages which are not directly user-installed shouldn't be autoremoved,
> since they can be setup through a different path (via
> `package-directory-list') where we have no authority over.
The patch looks okay for emacs-26, I'll push in a few days assuming no
objections.
A couple of nitpicks below:
> +(defun package--user-installed-p (pkg)
> + "Check if the package is a user-installed package.
> +PKG is a package name.
I think this is better shortened to
Return non-nil if the package named PKG is user-installed.
> +Checks whether the package was installed into `package-user-dir' where
> +we assume to have control over."
> + (let* ((pkg-desc (cadr (assq pkg package-alist)))
> + (dir (package-desc-dir pkg-desc)))
> + (file-in-directory-p dir package-user-dir)))
> +
> (defun package--removable-packages ()
> "Return a list of names of packages no longer needed.
> These are packages which are neither contained in
> @@ -1763,7 +1772,9 @@ These are packages which are neither contained in
By the way, if you run './autogen --git' you should get nicer headers
for lisp diffs.
> ;; `p' and its dependencies are needed.
> append (cons p (package--get-deps p)))))
> (cl-loop for p in (mapcar #'car package-alist)
> - unless (memq p needed)
> + unless (or (memq p needed)
> + ;; do not auto-remove external packages
Comments should be capitalized and end with a period.
> + (not (package--user-installed-p p)))
> collect p)))
next prev parent reply other threads:[~2018-08-09 1:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 14:46 bug#27822: 26.0.50; package-autoremove and 'package-directory-list Yuri D'Elia
2018-07-17 11:16 ` [PATCH] do not auto-remove external packages (fixes #27822) Yuri D'Elia
2018-07-17 12:40 ` bug#27822: " Stefan Monnier
2018-07-17 12:50 ` Yuri D'Elia
2018-08-07 11:12 ` package.el fix (was Re: [PATCH] do not auto-remove external packages (fixes #27822)) Yuri D'Elia
2018-08-09 1:19 ` Noam Postavsky [this message]
2018-08-09 11:16 ` bug#27822: [PATCH] do not auto-remove external packages (fixes #27822) Yuri D'Elia
2018-08-09 15:24 ` Eli Zaretskii
2018-08-12 1:08 ` Noam Postavsky
2018-07-17 11:16 ` Yuri D'Elia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va8kwd4p.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=27822@debbugs.gnu.org \
--cc=wavexx@thregr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.