From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#32372: [PATCH] Add "uuid" to thing-at-point.el Date: Fri, 10 Aug 2018 06:37:12 +0000 Message-ID: <87va8i20dj.fsf@violet.siamics.net> References: <87h8k88l47.fsf@konghq.com> <87effc8kj1.fsf@konghq.com> <8736vsz0mo.fsf@gmail.com> <878t5j9674.fsf@konghq.com> <87mutzxq3k.fsf@gmail.com> <87600m8vn9.fsf@konghq.com> <87600m48pq.fsf@violet.siamics.net> <8736vny1c8.fsf@konghq.com> <87bmab2yu1.fsf@violet.siamics.net> <87zhxvwf1c.fsf@konghq.com> <87sh3nxjvm.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1533882970 24404 195.159.176.226 (10 Aug 2018 06:36:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Aug 2018 06:36:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: Raimon Grau , "Basil L. Contovounesios" , Noam Postavsky To: 32372@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 10 08:36:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fo11p-0006FF-JD for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Aug 2018 08:36:05 +0200 Original-Received: from localhost ([::1]:54599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fo13w-0006bn-6s for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Aug 2018 02:38:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fo13l-0006ZU-RS for bug-gnu-emacs@gnu.org; Fri, 10 Aug 2018 02:38:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fo13j-0003vC-6q for bug-gnu-emacs@gnu.org; Fri, 10 Aug 2018 02:38:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41289) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fo13i-0003uk-PK for bug-gnu-emacs@gnu.org; Fri, 10 Aug 2018 02:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fo13i-0002Tj-CO for bug-gnu-emacs@gnu.org; Fri, 10 Aug 2018 02:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Aug 2018 06:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32372 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32372-submit@debbugs.gnu.org id=B32372.15338830419474 (code B ref 32372); Fri, 10 Aug 2018 06:38:02 +0000 Original-Received: (at 32372) by debbugs.gnu.org; 10 Aug 2018 06:37:21 +0000 Original-Received: from localhost ([127.0.0.1]:46307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fo131-0002Si-MK for submit@debbugs.gnu.org; Fri, 10 Aug 2018 02:37:21 -0400 Original-Received: from fely.am-1.org ([78.47.74.50]:41762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fo12z-0002Sa-SD for 32372@debbugs.gnu.org; Fri, 10 Aug 2018 02:37:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net ; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:In-Reply-To:Date:References:X-License:Cc:To:Subject:From:Sender: Reply-To:Content-ID:Content-Description; bh=VcyuUpHRtYrLxBh3Ss0EjoaPAB3zHfQR3YuKbmERkT4=; b=CVLGAzuZKZtNT9L+BXLsWW7FCW eYUskNu/VzAYGcknEytzqzC/USu5h3sMhoWZKbJBcCTbX37t7NFh4IywsRpM2oEwGyMxkj7FoAA88 NHKaNcjannWSl1mYKwveRdaC6cLfl7n7pHp9Yi8i0OQVftz0uhk6GDRoOjDjte9m+lS0=; Original-Received: from violet.siamics.net ([2001:470:1f13:1eb::1:1d]) by fely.am-1.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1fo12w-0005UG-78; Fri, 10 Aug 2018 06:37:14 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtp (Exim 4.84_2) (envelope-from ) id 1fo12v-0007gr-1Z; Fri, 10 Aug 2018 06:37:13 +0000 X-License: CC-BY-SA-3.0+ (original contributions only) In-Reply-To: <87sh3nxjvm.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 10 Aug 2018 01:20:13 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149401 Archived-At: >>>>> Basil L Contovounesios writes: >>>>> Raimon Grau writes: >>>>> Ivan Shmakov writes: >>> While either =E2=80=98and=E2=80=99 or =E2=80=98if=E2=80=99 can be used= here, to exactly the same >>> effect, the indentation above is one for =E2=80=98if=E2=80=99; =E2=80= =98and=E2=80=99 should instead >>> look like: >>> (and (thing-at-point-looking-at thing-at-point-uuid-regexp 36) >>> (cons (match-beginning 0) (match-end 0))) >>> I think in this case it=E2=80=99s marginally better to keep indentatio= n and >>> replace =E2=80=98and=E2=80=99 with =E2=80=98if=E2=80=99 than the other= way around. >> What about =E2=80=98when=E2=80=99? Is it ok to use it? Yes. Actually, I=E2=80=99ve somehow confused if with when in the above comment; with if, the indentation will be like: (if (thing-at-point-looking-at thing-at-point-uuid-regexp 36) (cons (match-beginning 0) (match-end 0))) >> One branch 'if' look funny to me but I don=E2=80=99t see many (any?) = =E2=80=98when=E2=80=99 >> in the emacs codebase. > If you grep the codebase you will see countless occurrences of and, > or, if-then, if-then-else, when, unless, etc. > What to use here is a mostly a matter of personal style, and a bit of > a bikeshed at that, so you are likely to get varied opinions. At the > end of the day it doesn=E2=80=99t really matter what you go with. Yes. [=E2=80=A6] --=20 FSF associate member #7257 np. Undercurrent =E2=80=94 Jami Sieber