all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ivan Shmakov <ivan@siamics.net>
To: 32372@debbugs.gnu.org
Cc: Raimon Grau <raimon@konghq.com>,
	"Basil L. Contovounesios" <contovob@tcd.ie>,
	Noam Postavsky <npostavs@gmail.com>
Subject: bug#32372: [PATCH] Add "uuid" to thing-at-point.el
Date: Fri, 10 Aug 2018 06:37:12 +0000	[thread overview]
Message-ID: <87va8i20dj.fsf@violet.siamics.net> (raw)
In-Reply-To: <87sh3nxjvm.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 10 Aug 2018 01:20:13 +0300")

>>>>> Basil L Contovounesios <contovob@tcd.ie> writes:
>>>>> Raimon Grau <raimon@konghq.com> writes:
>>>>> Ivan Shmakov <ivan@siamics.net> writes:

 >>> While either ‘and’ or ‘if’ can be used here, to exactly the same
 >>> effect, the indentation above is one for ‘if’; ‘and’ should instead
 >>> look like:

 >>> (and (thing-at-point-looking-at thing-at-point-uuid-regexp 36)
 >>>      (cons (match-beginning 0) (match-end 0)))

 >>> I think in this case it’s marginally better to keep indentation and
 >>> replace ‘and’ with ‘if’ than the other way around.

 >> What about ‘when’?  Is it ok to use it?

	Yes.  Actually, I’ve somehow confused if with when in the above
	comment; with if, the indentation will be like:

   (if (thing-at-point-looking-at thing-at-point-uuid-regexp 36)
       (cons (match-beginning 0) (match-end 0)))

 >> One branch 'if' look funny to me but I don’t see many (any?) ‘when’
 >> in the emacs codebase.

 > If you grep the codebase you will see countless occurrences of and,
 > or, if-then, if-then-else, when, unless, etc.

 > What to use here is a mostly a matter of personal style, and a bit of
 > a bikeshed at that, so you are likely to get varied opinions.  At the
 > end of the day it doesn’t really matter what you go with.

	Yes.

[…]

-- 
FSF associate member #7257  np. Undercurrent — Jami Sieber





  reply	other threads:[~2018-08-10  6:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-05 23:11 bug#32372: [PATCH] Add "uuid" to thing-at-point.el Raimon Grau
2018-08-05 23:24 ` Raimon Grau
2018-08-06  2:31   ` Noam Postavsky
2018-08-06  9:47     ` Basil L. Contovounesios
2018-08-06  9:48     ` Raimon Grau
2018-08-06 19:16       ` Noam Postavsky
2018-08-07  7:48         ` Raimon Grau
2018-08-07 13:17           ` Ivan Shmakov
2018-08-07 17:45             ` Basil L. Contovounesios
2018-08-09 16:03             ` Raimon Grau
2018-08-09 18:12               ` Ivan Shmakov
2018-08-09 18:50                 ` Raimon Grau
2018-08-09 22:20                   ` Basil L. Contovounesios
2018-08-10  6:37                     ` Ivan Shmakov [this message]
2018-08-11 11:37                       ` Raimon Grau
2018-08-13 11:49                         ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87va8i20dj.fsf@violet.siamics.net \
    --to=ivan@siamics.net \
    --cc=32372@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=npostavs@gmail.com \
    --cc=raimon@konghq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.