From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour Date: Mon, 17 Sep 2018 16:12:19 +0200 Message-ID: <87va74usak.fsf@gmx.de> References: <20180915233623.2746.56778@vcs0.savannah.gnu.org> <20180915233624.2285320442@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1537193427 8588 195.159.176.226 (17 Sep 2018 14:10:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Sep 2018 14:10:27 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Thomas Fitzsimmons Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 17 16:10:23 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1uEH-000283-IO for ged-emacs-devel@m.gmane.org; Mon, 17 Sep 2018 16:10:21 +0200 Original-Received: from localhost ([::1]:35777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1uGO-0000n6-4Z for ged-emacs-devel@m.gmane.org; Mon, 17 Sep 2018 10:12:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1uGI-0000my-3Z for emacs-devel@gnu.org; Mon, 17 Sep 2018 10:12:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1uGE-0004v1-T6 for emacs-devel@gnu.org; Mon, 17 Sep 2018 10:12:26 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:34727) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g1uGE-0004pz-JM for emacs-devel@gnu.org; Mon, 17 Sep 2018 10:12:22 -0400 Original-Received: from detlef.gmx.de ([212.91.249.153]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MUCTO-1gRmqc1RnW-00R3gk; Mon, 17 Sep 2018 16:12:20 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 17 Sep 2018 09:54:07 -0400") X-Provags-ID: V03:K1:IKHJtYel7u0CQNampipSpHEspLDmUX/YhaPP4PM3aia1Yegi1PF Ll3dhNMSlrqWsVGJVMO9VuPo0ChDxP3IIH6rQkARWx5WcaC+OvzhhVqRD2dTLGrY8PXc36p fqL3W0bKXKzeun4aJT6hoGPUoA/5K7KBsVyZhGPdNTNNgM/sx9DtUpQnxtS3z/oyDJXOqVJ xUh3XUQ9+IOREkgiXLmzg== X-UI-Out-Filterresults: notjunk:1;V01:K0:k3loLLp0Cn0=:q0qF3H/dIowdBIWxyEN33h ID7Q46C7D7OM1lyhh6TEGjfRDxvHtphtbkDZMt/6otRlucs5MoVGpDVtsvB1aquq/3jYZTekk ZGLuGfYfsMzzuvAoDhJuHvi+kXCwSiX40BO3oAv8Wiprcfxj9dVe3u+Uk+DT/03g8bPmmNmGG ZuZSZBfI4awTH7zWTibds3IzUtEKsWpU2QvatrWA0FtAT4X4l/O6XEhm+0leBv2vxNaS8vtcT 0YzjwWAnKwOKTX/F2u81bZZv7NOPTLEYYleNWGHGcW8SSrrFTBGquXZCYd3OJy+Q/P54hoILI CcqQpCuMbMS2/x9sP7Ty4tcpwAPnMRjSZ0+0UmMoHcu3VfgoATe4CZCTCvKl9KaW5+HtPwMeZ 6I2tlBfM3IywBsSxn/eXXE8FtxCUC3wuF+1Zv0zgEjBMuimopWp1TK8KNLDwObeOpoFqcCdh5 nTyurzIas3fK8SWlJtkWWmbXJNzBbB/sxq8moCDv4L0Qz2XgWQKiZMXu9uZPy4Odx1c0IC7l9 cN4IsrMd2+33oKtzrsR9ksVr53sg+mRgRQUtX1wEM+kDvMCdCbVYmlIIYY1fqDqDcsMihehLx Nif5ABrSYvXMz7RlUc9hRmKX1Eq9vZDzvvXOdyy1AGAyTQAsjCsIYSzzcAdqbvLpAvUXEIcAV KPoRs4CKTgvXHfsZDWikfFhdgq/vJAU0xi/tfuq56VUN52ROfgWVptYotwgXCTf98qCw/7zVF Zlew5pN26iuag9E6uiTyw5iAcX8rFYp7t+XS0WvxRvQleYuZQ28I6AOtjArGfHR0EK8gTTez X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229895 Archived-At: > ;;;###autoload > (defun advice-remove (symbol function) > - (ad-remove-advice symbol 'around function) > - (ad-activate symbol)) > + ;; Just return nil if there is no advice, rather than signaling an > + ;; error. > + (condition-case nil > + (ad-remove-advice symbol 'around function) > + (error nil)) > + (condition-case nil > + (ad-activate symbol) > + (error nil))) I would write (ignore-errors (ad-remove-advice symbol 'around function)) (ignore-errors (ad-activate symbol)) Best regards, Michael.