From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#17814: 24.3.91; better string manipulation in subr-x Date: Tue, 18 Sep 2018 21:37:20 -0400 Message-ID: <87va72p8rz.fsf@gmail.com> References: <38CF8BF2232E16shigeru.fukaya@gmail.com> <39CF8CAB123C5Fshigeru.fukaya@gmail.com> <3CCF8D06508F70shigeru.fukaya@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1537320975 5080 195.159.176.226 (19 Sep 2018 01:36:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Sep 2018 01:36:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 17814@debbugs.gnu.org, Stefan Monnier To: Shigeru Fukaya Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 19 03:36:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2RPS-000179-LI for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Sep 2018 03:36:06 +0200 Original-Received: from localhost ([::1]:43222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2RRY-0005Aa-WA for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Sep 2018 21:38:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2RRS-00059x-GL for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 21:38:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2RRN-0001oF-Ft for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 21:38:10 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40662) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g2RRJ-0001le-U5 for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 21:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g2RRJ-00034Q-Rp for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 21:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Sep 2018 01:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17814-submit@debbugs.gnu.org id=B17814.153732105011752 (code B ref 17814); Wed, 19 Sep 2018 01:38:01 +0000 Original-Received: (at 17814) by debbugs.gnu.org; 19 Sep 2018 01:37:30 +0000 Original-Received: from localhost ([127.0.0.1]:44920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2RQo-00033O-FH for submit@debbugs.gnu.org; Tue, 18 Sep 2018 21:37:30 -0400 Original-Received: from mail-it0-f46.google.com ([209.85.214.46]:37713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2RQl-000334-Rf; Tue, 18 Sep 2018 21:37:28 -0400 Original-Received: by mail-it0-f46.google.com with SMTP id h20-v6so5673082itf.2; Tue, 18 Sep 2018 18:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Kc7+rMKu5Ygvb3ARA+KL8WtvPy08f4lnYTaA3W4fBYw=; b=HkO3o0+aiDWVdHWk9wncFhdVXLs5q5D4FqKb17/UP31cXDyQP4+UobiSQ2Y8VOMreE 03IA5tHCAhCACsTTHzjZT6xvwfiN6fdAjrvg5v6lQ+L07+pYYjaAID6jXt7iLbYWTs6o +lITD7P4Ozt7kuiAeG79ahENVUZ4vUa265dB+vO7z3hxphLoKTsD8/u8gqI2Px3POk8Z jstUwQa8WsA0EQTRQYRBIyHap7vUQ5XX3zM5sjYPrQleWjPdJFg5C+Xqm6Cf3hibqIKl isBYX8ZOv4dMyj3IddoGdy1mfkaKR4QIoy88ryiFif0eHDWQEOr1KTnPiaoLt3K1n5s4 zZLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Kc7+rMKu5Ygvb3ARA+KL8WtvPy08f4lnYTaA3W4fBYw=; b=KKN82zNvuF3YwRZcm+VhkCdF5DSuwYvotWE/7w9hI5wlLerccRRo69gK+kcKcmFwzh ow0qaYwqnxo36glfjF2oSxo1HZlzK+luzdbnaC5Gqa+QSafFeDASm0kpW19zbAegO0ZZ ofBRq7k4P8guZdoUMfR0gaNZQ+34pD4lZ69fohx/N3Zs3tpVgaHH0VeZ1Yqol2J8Q+zY o6IhvORFEV5082W2lG6HiKbY4KVtrm+yEeyrNSA3PHNf307/xnavgpF1X25cewHiF1He yd5C5zVrq9rq5HfXldPS3i3aIqBBEe8FN5j0Ux83r0dZnxIkuq328nWCYsK9ozMpHAnc nr0Q== X-Gm-Message-State: APzg51CeXKdtdLyvW01D4xp9mqO/u0LsxQ5rFuIdnfTMqL44StByEqQe zHcEOHHgpe1CoolCghuH39rugpIq X-Google-Smtp-Source: ANB0VdZKzVFb515CUOBkbCNxzeT8McdUtppPx68ZVNbn75LUy+VQURX87e+20c20GAsHVsN9GF9gyg== X-Received: by 2002:a24:29cf:: with SMTP id p198-v6mr19320321itp.48.1537321042082; Tue, 18 Sep 2018 18:37:22 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id b3-v6sm4908547itj.32.2018.09.18.18.37.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Sep 2018 18:37:21 -0700 (PDT) In-Reply-To: <3CCF8D06508F70shigeru.fukaya@gmail.com> (Shigeru Fukaya's message of "Sat, 21 Jun 2014 13:07:27 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150426 Archived-At: close 17814 quit Shigeru Fukaya writes: >>The above string-match will fail on a string that has a newline, and the >>subsequent code will use whatever was the old match-data, resulting in >>broken behavior. > > "." in "\\`[\s\t\n\r]*\\(.*?\\)[\s\t\n\r]*\\'" must be "\\(.\\|\n\\)", sorry. > >>Other than that, I don't have any opinion on such changes (I've never >>heard anyone complain about code size or cpu-time of any of those >>functions, so I think it largely doesn't matter either way). > > Using string-trim-to-right and string-trim-to-left creates unnecessary > temporary string if both sides need triming may matter, then? > > Anyway, I think I'm just sending a small proposal. I don't care much > if you throw it away. Thank you for spending your time. An optimization similar to the one proposed here was done for string-trim-to-{left,right} in [1: 1013e0392b]. I think the strim-trim change isn't worth the extra complexity (especially since it's not even entirely clear whether it would be faster/smaller), so I'm closing the bug. [1: 1013e0392b]: 2018-07-13 11:28:16 -0400 Tweak subr-x.el substring functions https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1013e0392b78ee0e2199fb51859dc9e939315f9b