From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: some accept-process-output races fixed; Tramp FIXMEs Date: Mon, 28 Jan 2019 16:37:10 +0100 Message-ID: <87va28g5eh.fsf@gmx.de> References: <46ce72ef-c4cb-1cd1-566a-c305ca92e68c@cs.ucla.edu> <80d86b5a-efb7-87cc-a3db-0a6ad356274d@cs.ucla.edu> <875zujlkhv.fsf@gmx.de> <87tvi0tipl.fsf@gmx.de> <6d537644-9b50-b71d-30a5-e8554e0b845c@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="227750"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Monnier , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 28 16:38:01 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go8z3-000x6M-EN for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2019 16:38:01 +0100 Original-Received: from localhost ([127.0.0.1]:33905 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go8z2-0007FT-6w for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2019 10:38:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go8yv-0007F9-7Q for emacs-devel@gnu.org; Mon, 28 Jan 2019 10:37:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1go8yo-0007jl-Io for emacs-devel@gnu.org; Mon, 28 Jan 2019 10:37:48 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:49253) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1go8yk-0007cr-CT for emacs-devel@gnu.org; Mon, 28 Jan 2019 10:37:44 -0500 Original-Received: from detlef.gmx.de ([79.140.118.103]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MCLQ1-1gwdHX1wLh-009Bfw; Mon, 28 Jan 2019 16:37:14 +0100 X-Provags-ID: V03:K1:0OygesP3jApLb2SumhkpqcoeNov62B5zKhPzQmXfzWcsqzJqU6q hwuMHi2lLB9AXxGQ91y28k6ieRcClk8MA43D4V4Xe/XUJmvgwlRAHiXBYdRnZhDGfVrwZdj HQMwg3N0CU+wg83+LOXlb1gF96UdBv1vb1XncbBoSBMPxznbmm44c2GocRbG02aN40mAWNJ zjv/QYaPZ7QPzYI15kmng== X-UI-Out-Filterresults: notjunk:1;V03:K0:nBXoikbQPjE=:fa2ifgNVJwJZjD+657gWXL C7F/+ewD1acka2w09UfXMBRiaJDlEpZVDmxS5OCVD/GSBCY5ZxGym+6ODl7ws11iRulmG8flz PxB09hJvRxEJIndxJZ2SXMS/Cz8VpFSrDXOpJ7+PAurzgi9TavUkSXzrNBGLFQtTYyeLtc4Vm NwSwbQmzzaCY+wW5rY4YXg/O+wgu7w5gRNvB7zdoMs2En8Zc7dp0T6R49QxfYks9LhNfYrV4T vsmXAYXcaUg7MjkjjegnfUxSZd8tOCvVY9121JpVzFousljCxxbdnAR4/1ysikJU0K4t9rBGI nK2PABpV7yQYEMDSnRKEo8pL6XOfZuOXTLLswLLz99s7SP69hxH5OExvta1C4w9Rl/nxsBalz gZyGuPYtoQ0fIuDgMjNYjDj9EJ4fK6Dy/ayDK/vbL5B3Kfv9ihqRriUNm7IKwYqBnJ8wZF6RZ bleuEWg9vZ2xDE0jY0YTaFam401DNRkL13vpRq4W/H/zpdFyu+k4rftqhmevmlxN4sSZw4H+v FTyPHUjjCZ5m9ef78mZeYcQBG+awVWqYEbBUcxZcsgmOTup1Rbxqm4uU3+sbThqxqDr3s3kpJ 2Q1j00UEZhOxB/fxqe20iYe1Ml8Gb9WEbVZVHAtXGchhzEJmzQj3Fklgny3XAdaYdCXRW8bmN DfjZqFIDw2+tZIXzM9kPHiKo8ZbeuruYXW0ALBf8ajjic4BDupSe2dJmeTn/qMY5zcI2BZMn2 qYZxvoyttyYqYIAgoVERi69TDXbkBg34IrmUJxhAOY9zTPwkgzjcSjxs3vxTt4aT3G4/GuB4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232762 Archived-At: Paul Eggert writes: > 0.1 is not merely suboptimal (i.e., slower than it should be), it's > also incorrect (as it can sometimes lose data due to races). Even if > we must use 0.1 in older Emacs to work around more-serious bugs there, > we should use nil in Emacs master. I've adapted all calls of accept-process-output to use a timeout of either nil or 0. Running Tramp's test suite does not show relevant performance differences for most of the backends, except smb. Here we have a performance boost, (411.009675 sec before, 54.109701 sec after the change). The change works on all Emacsen 24-27, tested on GNU/Linux, with the different backends. So I've taken the risk to apply it w/o compatibility code. Let's see what people report. I plan to test it also on OpenBSD and MS Windows, once I find respective test machines. But this will happen for Emacs 27 only, I believe. Best regards, Michael.