From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#34196: Error in auto-revert-buffers: Wrong type argument Date: Wed, 13 Feb 2019 13:00:43 -0600 Message-ID: <87va1nfr8k.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="109221"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: 34196@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 13 20:01:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gtzmR-000SHH-9d for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Feb 2019 20:01:11 +0100 Original-Received: from localhost ([127.0.0.1]:33776 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtzmQ-00066E-6n for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Feb 2019 14:01:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtzmJ-00065x-RN for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2019 14:01:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtzmI-0004GE-HE for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2019 14:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48021) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtzmI-0004G1-7z for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2019 14:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gtzmI-0001CZ-48 for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2019 14:01:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Feb 2019 19:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34196 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 34196-submit@debbugs.gnu.org id=B34196.15500844564598 (code B ref 34196); Wed, 13 Feb 2019 19:01:02 +0000 Original-Received: (at 34196) by debbugs.gnu.org; 13 Feb 2019 19:00:56 +0000 Original-Received: from localhost ([127.0.0.1]:47302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtzmC-0001C6-1a for submit@debbugs.gnu.org; Wed, 13 Feb 2019 14:00:56 -0500 Original-Received: from mail-ot1-f43.google.com ([209.85.210.43]:36939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gtzm9-0001Bs-JJ for 34196@debbugs.gnu.org; Wed, 13 Feb 2019 14:00:54 -0500 Original-Received: by mail-ot1-f43.google.com with SMTP id b3so6151082otp.4 for <34196@debbugs.gnu.org>; Wed, 13 Feb 2019 11:00:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:cc:subject:date:message-id:mime-version; bh=8SjYsxfruv5UrAPQeNVkN8FAAnSUnUYYDvJmKsQLxP0=; b=Y6Px1jHNsW8Bw3Og6glI2uqcfFiOKwiHOYw8c4X/j1r8yWQTtAQBSKA38IQEwmXNCw 44vKBRSo7dycwJwKmIAhqOzPZObNfYFPU+fN4VQJk6/Yt+StbdRBSML//AMLbtbC+sdG qhZoTSKC9PwRI8oIJY1p/8JAI0PgQXx5wpoVtS1HWAyOeBnINpf75JktpF+eqH2tYvYR svopX93RSu+ETwTG8iCfwBpSKEehv9hzK6T98XXvKmyCYbVvkHph67UnEJ141mj5deHD DC3X7IKKxVC8pm8x6qc2/h8kbkH5iEh3CoGxgl3uaFKOYfhko1hvd9JjRfqwfNsIHjuR VglA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:cc:subject:date:message-id :mime-version; bh=8SjYsxfruv5UrAPQeNVkN8FAAnSUnUYYDvJmKsQLxP0=; b=QtfIkJ16iOC51sImkYl8tdfL9292o75Wcp5k5058tKc29Z8BM5uxqCk72yNlvV0dic 9n/E1usTK1jwqjgSvOAhDikmxm3Z3yTElRbv0Y+puqWWLfBzzPh/Zo6GTZb657J5UHRD 8kN2xynynXbZbhuFoquEWHEir7ObLTjjVJTJ53YPBR6sHDJPbvn31UBqdQHL3VVkUaoq 7AbMHa6HhgMbptLa5XAWF81tm9j6ZgacLGTHBtIEqtm0XTQch7vUqOw3Qd4p856DgUdo Ncy7HV4SDjgCNTrMfzcOPuDc028S1/8QKIvhe282zg3eMYAQLsxsLgtfX7yaUb5WDak4 BEbQ== X-Gm-Message-State: AHQUAuawOEln6fUS0wljxfxvDoI0vkheZgCIbI1+pzJuboKVvQa6XA2K hMJGp3wIW8nQ6jsEAG76JBycK/qR X-Google-Smtp-Source: AHgI3IYO0D5ekw4i5ka8zUeKrw85J4hzxCr/l3SgLnRv7xdHxPkgnPkotBUer/n9o4fYUibo7Hj99w== X-Received: by 2002:aca:1e01:: with SMTP id m1mr1160988oic.156.1550084446248; Wed, 13 Feb 2019 11:00:46 -0800 (PST) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id b23sm38329otq.5.2019.02.13.11.00.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Feb 2019 11:00:45 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155401 Archived-At: Hi Michael - The fix for this bug seems to cause issues if default-directory is nil for any buffer. In particular, you get a wrong type argument where auto-revert-buffers is expecting a string instead of nil. This change fixes the issue for me: Thanks, Alex diff --git a/lisp/autorevert.el b/lisp/autorevert.el index 150693baf1..318b10d4a8 100644 --- a/lisp/autorevert.el +++ b/lisp/autorevert.el @@ -773,7 +773,8 @@ the timer when no buffers need to be checked." (mapcar (lambda (buf) (with-current-buffer buf - (and (or (not (file-remote-p default-directory)) + (and default-directory + (or (not (file-remote-p default-directory)) (file-remote-p default-directory nil t)) buf))) bufs)))