From: Alex Branham <alex.branham@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 34196@debbugs.gnu.org
Subject: bug#34196: Error in auto-revert-buffers: Wrong type argument
Date: Wed, 13 Feb 2019 13:00:43 -0600 [thread overview]
Message-ID: <87va1nfr8k.fsf@gmail.com> (raw)
In-Reply-To: <m2h8dw7nrc.fsf@gmail.com>
Hi Michael -
The fix for this bug seems to cause issues if default-directory is nil
for any buffer. In particular, you get a wrong type argument where
auto-revert-buffers is expecting a string instead of nil.
This change fixes the issue for me:
Thanks,
Alex
diff --git a/lisp/autorevert.el b/lisp/autorevert.el
index 150693baf1..318b10d4a8 100644
--- a/lisp/autorevert.el
+++ b/lisp/autorevert.el
@@ -773,7 +773,8 @@ the timer when no buffers need to be checked."
(mapcar
(lambda (buf)
(with-current-buffer buf
- (and (or (not (file-remote-p default-directory))
+ (and default-directory
+ (or (not (file-remote-p default-directory))
(file-remote-p default-directory nil t))
buf)))
bufs)))
next prev parent reply other threads:[~2019-02-13 19:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 15:36 bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode Aaron Jensen
2019-01-27 14:34 ` Aaron Jensen
2019-01-27 14:52 ` Aaron Jensen
2019-01-27 17:25 ` Michael Albinus
2019-02-04 15:06 ` Michael Albinus
[not found] ` <CAHyO48wRgVX-eNUHQXADEhOh3fHksVggxjKu23-=G_PSZzy-iQ@mail.gmail.com>
2019-02-05 12:51 ` Michael Albinus
2019-02-05 16:43 ` Aaron Jensen
2019-02-05 17:59 ` Michael Albinus
2019-02-05 18:14 ` Aaron Jensen
2019-02-05 19:22 ` Michael Albinus
2019-02-05 19:27 ` Aaron Jensen
2019-02-05 20:07 ` Michael Albinus
2019-02-05 22:41 ` Aaron Jensen
2019-02-06 8:11 ` Michael Albinus
2019-02-13 19:00 ` Alex Branham [this message]
2019-02-13 23:09 ` bug#34196: Error in auto-revert-buffers: Wrong type argument Michael Albinus
2019-02-14 17:05 ` Alex Branham
2019-02-14 20:25 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va1nfr8k.fsf@gmail.com \
--to=alex.branham@gmail.com \
--cc=34196@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.