From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups Date: Thu, 11 Apr 2019 10:57:03 -0700 Message-ID: <87v9zke87k.fsf@ericabrahamsen.net> References: <87d0ls32ke.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="61878"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Katsumi Yamaoka , 35233@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 11 19:58:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEdxj-000Ft3-Kw for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 19:58:11 +0200 Original-Received: from localhost ([127.0.0.1]:52942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEdxi-0003g5-Kh for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 13:58:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEdxb-0003fd-El for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 13:58:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEdxa-0001iB-8y for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 13:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41598) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEdxZ-0001hv-Ma for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 13:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEdxZ-0004uP-IK; Thu, 11 Apr 2019 13:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 11 Apr 2019 17:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35233 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch Original-Received: via spool by 35233-submit@debbugs.gnu.org id=B35233.155500543318815 (code B ref 35233); Thu, 11 Apr 2019 17:58:01 +0000 Original-Received: (at 35233) by debbugs.gnu.org; 11 Apr 2019 17:57:13 +0000 Original-Received: from localhost ([127.0.0.1]:55142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEdwm-0004tO-Rs for submit@debbugs.gnu.org; Thu, 11 Apr 2019 13:57:13 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:58416 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEdwk-0004tB-9m for 35233@debbugs.gnu.org; Thu, 11 Apr 2019 13:57:11 -0400 Original-Received: from localhost (97-126-87-168.tukw.qwest.net [97.126.87.168]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 4CEFBFA05C; Thu, 11 Apr 2019 17:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1555005424; bh=7/19vHHPMPvFSxpDngmh7hEGqqwehqyjcZ22qatZYHs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZI5G8qnH4nOL9Xfbna/TuuZA0TaI2ExpPn2iJu7y3M1u1s24mCA3AebIN0M610ipp apaOoDHS1ed6SFqtPqlHjmPwZETP6OsieVXqO/7iSQMEC6w92UgobtxMSiLIkeQM+3 s4Nk6F5rUSAfQaC8ZCVltvUy2E4c+7cqGjqGMs34= In-Reply-To: <87d0ls32ke.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 11 Apr 2019 17:54:25 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157514 Archived-At: "Basil L. Contovounesios" writes: > The recent move to hash-tables[1] introduced the following regression: > > 0. HOME=$(mktemp -d) emacs -Q > 1. (setq gnus-select-method '(nntp "news.gwene.org")) C-j > 2. M-x gnus RET s M-d > Wrong number of arguments: #, 1 > > Passing string-lessp to sort further leads to the following: > > 3. Steps 0-2 as above. > Wrong type argument: vectorp, #s(hash-table ...) > > Replacing (intern group gnus-description-hashtb) with just group, and > repeating steps 0-2 as above, reveals that > gnus-group-describe-all-groups inserts the group name twice, rather than > the group name followed by its description. This regression predates > the move to hash-tables[2]. > > [1: c1b63af445]: Change Gnus hash tables into real hash tables > 2019-03-22 10:23:30 -0700 > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c1b63af4458e92bad33da0def2b15c206656e2fa > > [2: 3982245371]: Sort groups before inserting them into the group buffer > 2016-02-13 18:45:11 +1100 > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3982245371c0b8e17b4d96d16ed4b1d87c0ffc25 > > Patch fixing these to follow. Ugh, thank you for catching those very stupid mistakes!