From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 34915-done@debbugs.gnu.org
Subject: bug#34915: 27.0.50; Wdired regression with ls -F
Date: Fri, 26 Apr 2019 17:20:30 +0100 [thread overview]
Message-ID: <87v9z0g2lt.fsf@tcd.ie> (raw)
In-Reply-To: <87r29o3g47.fsf@gmx.net> (Stephen Berman's message of "Fri, 26 Apr 2019 18:07:04 +0200")
tags 34915 fixed
close 34915
quit
Stephen Berman <stephen.berman@gmx.net> writes:
> On Fri, 26 Apr 2019 14:56:57 +0100 "Basil L. Contovounesios" <contovob@tcd.ie> wrote:
>
>> Thanks. I noticed an opportunity for a tiny bit of reuse:
> [...]
>
> I'm not sure the two uses justify a new function, but I don't oppose
> it.
I'll leave it for now.
>> Which makes me wonder: is there no Dired function that
>> wdired--restore-dired-filename-prop can reuse for finding the boundaries
>> of a file name? Is dired-move-to-end-of-filename not suitable? It
>> seems to perform similar checks for symlinks and --classify.
>
> dired-move-to-end-of-filename doesn't work in wdired-mode because the
> dired-filename text property it uses was removed to fix bug#32173, and
> wdired--restore-dired-filename-prop was added to compensate. I couldn't
> come up with a more elegant solution.
Thanks for explaining and for working on this. Since your patch fixed
the bug, I'm closing this report.
--
Basil
next prev parent reply other threads:[~2019-04-26 16:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 13:43 bug#34915: 27.0.50; Wdired regression with ls -F Basil L. Contovounesios
2019-04-12 12:23 ` Stephen Berman
2019-04-12 12:58 ` Basil L. Contovounesios
2019-04-12 13:06 ` Stephen Berman
2019-04-25 17:28 ` Stephen Berman
2019-04-26 13:56 ` Basil L. Contovounesios
2019-04-26 16:07 ` Stephen Berman
2019-04-26 16:20 ` Basil L. Contovounesios [this message]
2019-04-26 13:57 ` Basil L. Contovounesios
2019-05-30 19:51 ` Ken Brown
2019-06-26 16:28 ` Ken Brown
2019-06-26 16:57 ` Stephen Berman
2019-12-30 19:38 ` Mattias Engdegård
2020-09-20 18:14 ` Lars Ingebrigtsen
2020-09-21 9:42 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9z0g2lt.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=34915-done@debbugs.gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.