From: Noam Postavsky <npostavs@gmail.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: 35668@debbugs.gnu.org
Subject: bug#35668: 26.2; default value of `dired-omit-files'
Date: Sun, 12 May 2019 12:47:44 -0400 [thread overview]
Message-ID: <87v9yfhb67.fsf@gmail.com> (raw)
In-Reply-To: <dda24749-d556-4965-bd61-afbf3c705612@default> (Drew Adams's message of "Fri, 10 May 2019 06:41:49 -0700 (PDT)")
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
Drew Adams <drew.adams@oracle.com> writes:
> As mentioned in passing in bug #34911, I think the default value should
> be this:
>
> "\\`\\.?#\\|\\`\\.\\'\\|\\`\\.\\.\\'"
>
> instead of this:
>
> "^\\.?#\\|^\\.$\\|^\\.\\.$"
Right, I'd also escape the "." with [], because so many backslashes make
my eyes hurt.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 947 bytes --]
From 1be76f5272236d8238cf8a39ed96732478ea6e39 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sun, 12 May 2019 12:42:35 -0400
Subject: [PATCH] Fix dired-omit-files regexp (Bug#35668)
* lisp/dired-x.el (dired-omit-files): Match beginning and of string,
rather than beginning of end of line.
---
lisp/dired-x.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/dired-x.el b/lisp/dired-x.el
index defc541ddc..3b78ec47d9 100644
--- a/lisp/dired-x.el
+++ b/lisp/dired-x.el
@@ -159,7 +159,7 @@ (define-minor-mode dired-omit-mode
(put 'dired-omit-mode 'safe-local-variable 'booleanp)
-(defcustom dired-omit-files "^\\.?#\\|^\\.$\\|^\\.\\.$"
+(defcustom dired-omit-files "\\`[.]?#\\|\\`[.][.]?\\'"
"Filenames matching this regexp will not be displayed.
This only has effect when `dired-omit-mode' is t. See interactive function
`dired-omit-mode' (\\[dired-omit-mode]) and variable
--
2.11.0
next prev parent reply other threads:[~2019-05-12 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 13:41 bug#35668: 26.2; default value of `dired-omit-files' Drew Adams
2019-05-12 16:47 ` Noam Postavsky [this message]
2019-05-19 14:36 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9yfhb67.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=35668@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.